[obs-commits] [openSUSE/open-build-service] 9f3537: Add page and show_all parameters, when reading...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9f35370bb92c45aaba1d7d59a2af9f21c98044b1 https://github.com/openSUSE/open-build-service/commit/9f35370bb92c45aaba1d7d... Author: Eduardo Navarro <enavarro@suse.com> Date: 2020-09-21 (Mon, 21 Sep 2020) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/views/webui/users/notifications/_notifications_list.html.haml Log Message: ----------- Add page and show_all parameters, when reading... ... a notification. This will preserve the current pagination page and if all the results are shown, when a notification is marked as read. Commit: df316fe5302048c46edc24fe2d972e76d72c7cce https://github.com/openSUSE/open-build-service/commit/df316fe5302048c46edc24... Author: Eduardo Navarro <enavarro@suse.com> Date: 2020-09-21 (Mon, 21 Sep 2020) Changed paths: M src/api/app/helpers/webui/notification_helper.rb Log Message: ----------- Don't preserve the "page" parameter when changing... ... from "Show all" to "Show less", and viceversa. For example, keeping the second page of results when they change from being paginated from bunchs of 25 to bunchs of 300 results, brings no value. Commit: e0adca52ee87fc2bcb6f19cf3b3644ea018a8ce4 https://github.com/openSUSE/open-build-service/commit/e0adca52ee87fc2bcb6f19... Author: Eduardo Navarro <enavarro@suse.com> Date: 2020-09-21 (Mon, 21 Sep 2020) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb Log Message: ----------- Take the user to the last pagination page, when ... ... marking as read the only notification of the last page. This way, a page with no results will not be shown. Commit: 993e9c15e5176e0b1ceb50580eb8fec219d591a7 https://github.com/openSUSE/open-build-service/commit/993e9c15e5176e0b1ceb50... Author: Dany Marcoux <danymarcoux@gmail.com> Date: 2020-09-21 (Mon, 21 Sep 2020) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/helpers/webui/notification_helper.rb M src/api/app/views/webui/users/notifications/_notifications_list.html.haml Log Message: ----------- Merge pull request #10184 from eduardoj/fix_10173_notifications_preserve_pagination Marking a notification as read: couple of fixes Compare: https://github.com/openSUSE/open-build-service/compare/72ec94280f7b...993e9c...
participants (1)
-
Dany Marcoux