Branch: refs/heads/depfu/update/srcapi/rubocop-0.60.0 Home: https://github.com/openSUSE/open-build-service Commit: a5ec667bf08c5e259c60180dab1398385bd01844 https://github.com/openSUSE/open-build-service/commit/a5ec667bf08c5e259c6018... Author: depfu[bot] <depfu[bot]@users.noreply.github.com> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop to version 0.60.0 Commit: 0b442dda0bd87325634d093b88ecb2d9f1b615a2 https://github.com/openSUSE/open-build-service/commit/0b442dda0bd87325634d09... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/views/webui/project/monitor.html.erb M src/api/app/views/webui/project/refresh_monitor.html.erb Log Message: ----------- Refactor conversion of current time in project monitor page We've been fetching the 'DateTime' and afterwards did some string replacement which made the produced string look (almost) identical[*] to what 'Time.now.to_s' would produce. Instead of doing all that we now just use 'Time.now'. Time.now.to_s: "2018-10-30 13:25:52 +0000" DateTime.now.to_s.sub('T', ' '): "2018-10-30 13:26:11+00:00" The change itself was needed / demanded by Rubocop: https://github.com/rubocop-hq/ruby-style-guide#date--time Commit: c926b74c2025e9cc84392f8d0d4dd3d5678bbd59 https://github.com/openSUSE/open-build-service/commit/c926b74c2025e9cc84392f... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request.rb M src/api/spec/features/webui/requests_spec.rb Log Message: ----------- Use Time.now for auto accept / auto cleanup Active Record internally converts the time accept_at string to datetime which means we can safely use Time.now (the produced request xml does not change). Also the conversion and comparison of Time and DateTime is still working after this change. The change itself was needed / demanded by Rubocop: https://github.com/rubocop-hq/ruby-style-guide#date--time Commit: 12c90dbe0a1e856381764274e5a014479f57a049 https://github.com/openSUSE/open-build-service/commit/12c90dbe0a1e8563817642... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- Use Time.now when comparing times Rubocop prefers using 'Time.now' over 'DateTime.now'[*]. Since comparing objects of both classes works as expected, it's safe to change this. [*] https://github.com/rubocop-hq/ruby-style-guide#date--time Commit: 47f890f0bf568aeee3c601cce3d8b7ad105a0268 https://github.com/openSUSE/open-build-service/commit/47f890f0bf568aeee3c601... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/spec/models/cloud/backend/upload_job_spec.rb M src/api/spec/models/comment_spec.rb M src/api/test/functional/maintenance_test.rb Log Message: ----------- Update tests to not use DateTime This is needed to silence the Rubocop Style/DateTime cop. Details at: https://github.com/rubocop-hq/ruby-style-guide#date--time https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Rails/Date Commit: 4309ed5b74a8f5bcddc9acfbda316ca45f42cf29 https://github.com/openSUSE/open-build-service/commit/4309ed5b74a8f5bcddc9ac... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/models/obs_factory/distribution_strategy_opensuse_leap15.rb M src/api/lib/pretty_nested_errors/key_and_messages_parser.rb Log Message: ----------- Solve Rubocop offenses: Style/MutableConstant Commit: 63ed40de1ada5acefb3b014acfaf117988bfc35f https://github.com/openSUSE/open-build-service/commit/63ed40de1ada5acefb3b01... Author: Dany Marcoux <danymarcoux@gmail.com> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/app/controllers/request_controller.rb M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request.rb M src/api/app/models/cloud/backend/upload_job.rb Log Message: ----------- Solve Style/DateTime rubocop offenses Details at: https://github.com/rubocop-hq/ruby-style-guide#date--time https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Rails/Date Commit: cfee844d2dc5033c3980b35a00a59120acdd1dd4 https://github.com/openSUSE/open-build-service/commit/cfee844d2dc5033c3980b3... Author: Stephan Kulow <coolo@suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/spec/models/cloud/backend/upload_job_spec.rb M src/api/spec/models/comment_spec.rb Log Message: ----------- Avoid to_time casts as it puzzles rubocop Compare: https://github.com/openSUSE/open-build-service/compare/a2ed01381af0...cfee84... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.