[openSUSE/open-build-service] dfd579: Replace rescuing `Exception` with `StandardError`
![](https://seccdn.libravatar.org/avatar/9181eb84f9c35729a3bad740fb7f9d93.jpg?s=120&d=mm&r=g)
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: dfd5795f5d6da613ac554ad948c27bc8e76a51d7 https://github.com/openSUSE/open-build-service/commit/dfd5795f5d6da613ac554a... Author: Eduardo Navarro <enavarro@suse.com> Date: 2023-03-02 (Thu, 02 Mar 2023) Changed paths: M src/api/app/controllers/person_controller.rb M src/api/app/controllers/public_controller.rb Log Message: ----------- Replace rescuing `Exception` with `StandardError` `Exception` is the root of Ruby's exception hierarchy. Rescuing from `Exception` will apply rescue to any error, including subclasses such as `SyntaxError`, `LoadError`, and `Interrupt`. In the controllers of our Rails application, we need to rescue from exceptons thrown from the basecode, not other ones. Commit: 339a5025b272a34910f8e43bdae08ef6fc5399a1 https://github.com/openSUSE/open-build-service/commit/339a5025b272a34910f8e4... Author: Dani Donisa <dani.doni@gmail.com> Date: 2023-03-03 (Fri, 03 Mar 2023) Changed paths: M src/api/app/controllers/person_controller.rb M src/api/app/controllers/public_controller.rb Log Message: ----------- Merge pull request #13927 from eduardoj/fix/replace_exception_with_standarderror Replace rescuing `Exception` with `StandardError` Compare: https://github.com/openSUSE/open-build-service/compare/4ce8a0eb8945...339a50...
participants (1)
-
Dani Donisa