Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6acdb3022115419e849ffc088580db90b58cfb92 https://github.com/openSUSE/open-build-service/commit/6acdb3022115419e849ffc... Author: Björn Geuken Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/api/spec/models/user_spec.rb Log Message: ----------- [ci] Provide tests for password related tests of user model Commit: a60da39a04c2eacc8bc2ced103234551970a42d9 https://github.com/openSUSE/open-build-service/commit/a60da39a04c2eacc8bc2ce... Author: Björn Geuken Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/api/app/models/user.rb Log Message: ----------- [api] Store available password hashing algorithms in constant variable and drop the two methods that were storing them before. Commit: 2193e49698af8d2987fdb7cece069f0f80908d44 https://github.com/openSUSE/open-build-service/commit/2193e49698af8d2987fdb7... Author: Björn Geuken Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/api/app/models/user.rb A src/api/db/migrate/20170315190919_define_default_password_hashing_algorythm.rb M src/api/db/structure.sql M src/api/spec/models/user_spec.rb Log Message: ----------- [api] Define default password hash type on db level The before validation callback was setting empty password hash types to 'md5' already, which de facto made it the default. Defining this on db level should help to simplify the code. This also adds a separate validation for that attribute, and drops the old one (which doesn't work btw...). Commit: c0431c9dfcb692e96474614433a829403046011b https://github.com/openSUSE/open-build-service/commit/c0431c9dfcb692e9647461... Author: Björn Geuken Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/api/app/models/unregistered_user.rb M src/api/app/models/user.rb A src/api/db/migrate/20170315200936_drop_password_crypted_from_users.rb M src/api/db/structure.sql M src/api/test/fixtures/users.yml Log Message: ----------- [api] Drop password_crypted collumn of users table This attribute isn't used anywhere in our code. Commit: 7453160b33baa3d71370e4d4f94d4f88f71a8a5f https://github.com/openSUSE/open-build-service/commit/7453160b33baa3d71370e4... Author: Björn Geuken Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/api/app/models/user.rb Log Message: ----------- [api] Use ActiveModel::Dirty in user model ActiveModel::Dirty provides a nice set of helper methods to track and handle changes of attributes of a model. This allows us to remove a number of custom code that previously was taking care of this. Commit: 1b71af4eb2cb00ec9310ef13d97a22e8737fba6a https://github.com/openSUSE/open-build-service/commit/1b71af4eb2cb00ec9310ef... Author: Björn Geuken Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/api/spec/models/user_spec.rb Log Message: ----------- [ci] Fetch default hash types to be tested from user model This ensures that user password related tests are run against all hash types defined by User::PASSWORD_HASH_TYPES. Which means that any newly added hash type get's tested automatically. Commit: 73a30a3e637e91c0cdf9983c42235c7f2d1ce74f https://github.com/openSUSE/open-build-service/commit/73a30a3e637e91c0cdf998... Author: Björn Geuken Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/api/app/models/user.rb M src/api/spec/models/user_spec.rb Log Message: ----------- [api] Fix setting last_logged_in_at on user creation Commit: 0284a2a932703d923ce58df9aac1fcb31a809c5f https://github.com/openSUSE/open-build-service/commit/0284a2a932703d923ce58d... Author: Björn Geuken Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/api/app/models/user.rb M src/api/spec/models/user_spec.rb Log Message: ----------- [api] Fix validation of password_hash_type This fixes validation of password_hash_type and adds validation tests for it. Since that validation interferes with the password_hash_type inclusion validation, I had to replace it with a custom one. Commit: e332dc16ffb9391a0ece20f6a97293defdff2dad https://github.com/openSUSE/open-build-service/commit/e332dc16ffb9391a0ece20... Author: Björn Geuken Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/api/app/models/unregistered_user.rb M src/api/app/models/user.rb A src/api/db/migrate/20170315190919_define_default_password_hashing_algorythm.rb A src/api/db/migrate/20170315200936_drop_password_crypted_from_users.rb M src/api/db/structure.sql M src/api/spec/models/user_spec.rb M src/api/test/fixtures/users.yml Log Message: ----------- Merge pull request #2837 from bgeuken/add_tests_for_user_password_stuff Add tests for user password related methods and a few cleanups Compare: https://github.com/openSUSE/open-build-service/compare/a3401c5f4ce9...e332dc...