[obs-commits] [openSUSE/open-build-service] 2ea563: [api] ldap: Simplify checking of Config values
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 2ea5631f3f200a38bc6c62e95e912090472c5c28 https://github.com/openSUSE/open-build-service/commit/2ea5631f3f200a38bc6c62... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-07-27 (Thu, 27 Jul 2017) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] ldap: Simplify checking of Config values This shortens the code for checking if a value for a certain configuration option matches what we inspect. When a key value pair does not exist in the Config store, the return value for that non-existing key is nil. Therefore we can skip checking the existence of a key and just query andcompare it in one go. Commit: bc94bcede182865a2e10f4bc5a590c3e1840de32 https://github.com/openSUSE/open-build-service/commit/bc94bcede182865a2e10f4... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-07-27 (Thu, 27 Jul 2017) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] Refactor UserLdapStrategy::initialize_ldap_con Refactors the loop we use to retry connecting to the LDAP server. Commit: 8477eba8507db1d09d3c5af2822b7f2ae894772f https://github.com/openSUSE/open-build-service/commit/8477eba8507db1d09d3c5a... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-07-27 (Thu, 27 Jul 2017) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] ldap: further refactor user_in_group_ldap? Commit: db44312746793b8dc46651af48de231f827d0cc6 https://github.com/openSUSE/open-build-service/commit/db44312746793b8dc46651... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-07-27 (Thu, 27 Jul 2017) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [ci] ldap: Remove superfluous loop This removes an iteration that only ran 1 time. Commit: bc6aa3d4bb96378cad7c1b32ba4cabe1e36f43f0 https://github.com/openSUSE/open-build-service/commit/bc6aa3d4bb96378cad7c1b... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-07-27 (Thu, 27 Jul 2017) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Merge pull request #3443 from bgeuken/ldap_refactor_config_usage Ldap refactor config usage Compare: https://github.com/openSUSE/open-build-service/compare/d490d69190d7...bc6aa3...
participants (1)
-
Björn Geuken