Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 0c9260b8cfba25e1df1a561cb3c06437c2dda3be https://github.com/openSUSE/open-build-service/commit/0c9260b8cfba25e1df1a56... Author: ncounter Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/assets/stylesheets/webui/notifications.scss M src/api/app/components/notification_filter_component.html.haml M src/api/app/views/webui/shared/_check_box.haml Log Message: ----------- Notification filters: from links to checkboxes Commit: 42a8100fdba63ce4a2b02d3b5d2570dff283d0bd https://github.com/openSUSE/open-build-service/commit/42a8100fdba63ce4a2b02d... Author: ncounter Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/components/notification_filter_component.rb M src/api/app/controllers/concerns/webui/notifications_filter.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/models/notification.rb M src/api/app/views/webui/users/notifications/_update.js.erb M src/api/app/views/webui/users/notifications/index.html.haml Log Message: ----------- Filters counting Commit: 25de5e715c452081306eeaadefbb4f38f0e7485b https://github.com/openSUSE/open-build-service/commit/25de5e715c452081306eea... Author: ncounter Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: R src/api/app/components/notification_filter_link_component.html.haml R src/api/app/components/notification_filter_link_component.rb R src/api/spec/components/notification_filter_link_component_spec.rb R src/api/spec/components/previews/notification_filter_link_component_preview.rb Log Message: ----------- Drop no longer used component Commit: 29ab9631321e3a3184680d35679f4093f65dd7ba https://github.com/openSUSE/open-build-service/commit/29ab9631321e3a3184680d... Author: ncounter Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/components/notification_filter_component.html.haml M src/api/app/controllers/concerns/webui/notifications_filter.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/queries/groups_for_filter_finder.rb M src/api/app/queries/projects_for_filter_finder.rb M src/api/app/views/webui/shared/_check_box.haml M src/api/app/views/webui/users/notifications/_notifications_list.html.haml M src/api/app/views/webui/users/notifications/index.html.haml M src/api/spec/components/notification_filter_component_spec.rb M src/api/spec/components/previews/notification_filter_component_preview.rb M src/api/spec/controllers/webui/users/notifications_controller_spec.rb M src/api/spec/features/webui/users/notifications_spec.rb Log Message: ----------- Handle multiple filter parameters Commit: f9114a71198ff4472af457d7a353bd20b5e4755f https://github.com/openSUSE/open-build-service/commit/f9114a71198ff4472af457... Author: ncounter Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/controllers/concerns/webui/notifications_filter.rb M src/api/app/controllers/webui/users/notifications_controller.rb Log Message: ----------- Move filtering logic to the filter class Commit: 0490456fc3cf96b0455a6af109b118bdab712fa4 https://github.com/openSUSE/open-build-service/commit/0490456fc3cf96b0455a6a... Author: ncounter Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/components/notification_action_bar_component.rb M src/api/app/controllers/webui/users/notifications_controller.rb Log Message: ----------- Force select action button to 'Read' in case of mixed selection Commit: 251e0695604bcb32ed4fa3f35c21f39f7ad05e99 https://github.com/openSUSE/open-build-service/commit/251e0695604bcb32ed4fa3... Author: Dario Leidi Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/components/notification_filter_component.html.haml Log Message: ----------- @count[<key>] is never nil Commit: 68a3ba28e12fa903a1186aa2bcda602c8c0c2b81 https://github.com/openSUSE/open-build-service/commit/68a3ba28e12fa903a1186a... Author: Dario Leidi Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb Log Message: ----------- Make use of Ruby smartness Commit: 8556b3119b88374f9196334bf6c269dac4e2ce57 https://github.com/openSUSE/open-build-service/commit/8556b3119b88374f919633... Author: Dario Leidi Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb Log Message: ----------- Fix setting shared variable in a before_action Commit: d9d5d0e93e1fdff698837284f0866b58bf442e8d https://github.com/openSUSE/open-build-service/commit/d9d5d0e93e1fdff6988372... Author: Dario Leidi Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/controllers/concerns/webui/notifications_filter.rb Log Message: ----------- Redundant assignment dropped Commit: 59b1753ecfb49ea837eef01cd2b074c2c0185cd9 https://github.com/openSUSE/open-build-service/commit/59b1753ecfb49ea837eef0... Author: Dario Leidi Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/views/webui/users/notifications/index.html.haml Log Message: ----------- Move complex logic away from view to the controller Commit: 518cc49d9824cbacda2f63f3fdcfded26810d280 https://github.com/openSUSE/open-build-service/commit/518cc49d9824cbacda2f63... Author: ncounter Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/components/notification_filter_component.html.haml M src/api/app/components/notification_filter_component.rb Log Message: ----------- Prevent possible clashing key names Commit: 7df21b40c8fc951a91ae69c4f1584711c8fca14c https://github.com/openSUSE/open-build-service/commit/7df21b40c8fc951a91ae69... Author: ncounter Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/components/notification_action_bar_component.rb M src/api/app/components/notification_filter_component.html.haml M src/api/app/components/notification_filter_component.rb M src/api/app/controllers/concerns/webui/notifications_filter.rb M src/api/app/controllers/webui/users/notifications_controller.rb A src/api/app/views/webui/shared/_radio_button.haml Log Message: ----------- Make notification state filter a radio button Commit: 7dffa6f95f1d641a726a0781710f579901e7c1fb https://github.com/openSUSE/open-build-service/commit/7dffa6f95f1d641a726a07... Author: ncounter Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/controllers/concerns/webui/notifications_filter.rb M src/api/app/controllers/person/notifications_controller.rb M src/api/app/controllers/webui/users/notifications_controller.rb Log Message: ----------- Rename toward consistency Commit: 2dee7194dbf351c7a994598f0b2cb2004ee6fcb8 https://github.com/openSUSE/open-build-service/commit/2dee7194dbf351c7a99459... Author: ncounter Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb Log Message: ----------- Before action does not return anything Commit: abc0817740121fa6adf7fc727838f559f851956b https://github.com/openSUSE/open-build-service/commit/abc0817740121fa6adf7fc... Author: ncounter Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb Log Message: ----------- Wrap only really affected lines Commit: 8a4ff22f09901aba78f08a4b79d12058f41c8c37 https://github.com/openSUSE/open-build-service/commit/8a4ff22f09901aba78f08a... Author: Dario Leidi Date: 2024-05-31 (Fri, 31 May 2024) Changed paths: M src/api/app/assets/stylesheets/webui/notifications.scss M src/api/app/components/notification_action_bar_component.rb M src/api/app/components/notification_filter_component.html.haml M src/api/app/components/notification_filter_component.rb R src/api/app/components/notification_filter_link_component.html.haml R src/api/app/components/notification_filter_link_component.rb M src/api/app/controllers/concerns/webui/notifications_filter.rb M src/api/app/controllers/person/notifications_controller.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/models/notification.rb M src/api/app/queries/groups_for_filter_finder.rb M src/api/app/queries/projects_for_filter_finder.rb M src/api/app/views/webui/shared/_check_box.haml A src/api/app/views/webui/shared/_radio_button.haml M src/api/app/views/webui/users/notifications/_notifications_list.html.haml M src/api/app/views/webui/users/notifications/_update.js.erb M src/api/app/views/webui/users/notifications/index.html.haml M src/api/spec/components/notification_filter_component_spec.rb R src/api/spec/components/notification_filter_link_component_spec.rb M src/api/spec/components/previews/notification_filter_component_preview.rb R src/api/spec/components/previews/notification_filter_link_component_preview.rb M src/api/spec/controllers/webui/users/notifications_controller_spec.rb M src/api/spec/features/webui/users/notifications_spec.rb Log Message: ----------- Merge pull request #16183 from ncounter/notification-filters Notification filters: multiple selection Compare: https://github.com/openSUSE/open-build-service/compare/f0a161b8c537...8a4ff2... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications