Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 753d34abca9d343507843ec8a76fb85f873b4a0d https://github.com/openSUSE/open-build-service/commit/753d34abca9d343507843e... Author: Stephan Kulow <coolo@suse.de> Date: 2019-05-14 (Tue, 14 May 2019) Changed paths: M src/api/app/controllers/request_controller.rb M src/api/app/models/bs_request_action.rb Log Message: ----------- Move set_sourceupdate_default to an explicit action in the controller The default is in the UI view, so it's all about the API controller and that one knows when to call it, no reason to 'fix it' in the check functions of the model Commit: 54e8b50b3817ea672f96ed44ee042570b7245eaf https://github.com/openSUSE/open-build-service/commit/54e8b50b3817ea672f96ed... Author: Stephan Kulow <coolo@suse.de> Date: 2019-05-14 (Tue, 14 May 2019) Changed paths: M src/api/app/controllers/application_controller.rb M src/api/app/controllers/build/file_controller.rb M src/api/app/controllers/build_controller.rb M src/api/app/controllers/cloud/upload_jobs_controller.rb M src/api/app/controllers/comments_controller.rb M src/api/app/controllers/message_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/published_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/source_attribute_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/source_project_config_controller.rb M src/api/app/controllers/source_project_controller.rb M src/api/app/controllers/source_project_meta_controller.rb M src/api/app/controllers/staging/staged_requests_controller.rb M src/api/app/controllers/staging/staging_projects_controller.rb M src/api/app/controllers/statistics_controller.rb M src/api/app/controllers/status/checks_controller.rb M src/api/app/controllers/status_messages_controller.rb M src/api/app/controllers/webui/cloud/azure/configurations_controller.rb M src/api/app/controllers/webui/cloud/azure/upload_jobs_controller.rb M src/api/app/controllers/webui/cloud/ec2/configurations_controller.rb M src/api/app/controllers/webui/cloud/ec2/upload_jobs_controller.rb M src/api/app/controllers/webui/cloud/upload_job/logs_controller.rb M src/api/app/controllers/webui/cloud/upload_jobs_controller.rb M src/api/app/controllers/webui/comments_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/projects/maintained_projects_controller.rb M src/api/app/controllers/webui/projects/project_configuration_controller.rb M src/api/app/controllers/webui/projects/rebuild_times_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/session_controller.rb M src/api/app/controllers/webui/staging/excluded_requests_controller.rb M src/api/app/controllers/webui/staging/projects_controller.rb M src/api/app/controllers/webui/staging/workflows_controller.rb M src/api/app/controllers/webui/status_messages_controller.rb M src/api/app/controllers/webui/user_controller.rb M src/api/app/controllers/webui/users/announcements_controller.rb M src/api/app/controllers/webui/users/rss_tokens_controller.rb M src/api/app/controllers/webui/users/subscriptions_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/controllers/webui2/comments_controller.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/helpers/webui/user_helper.rb M src/api/app/jobs/consistency_check_job.rb M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/jobs/staging_project_accept_job.rb M src/api/app/jobs/staging_project_copy_job.rb M src/api/app/mixins/has_attributes.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_maintenance_incident.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/bs_request_permission_check.rb M src/api/app/models/concerns/staging_project.rb M src/api/app/models/maintenance_incident.rb M src/api/app/models/package.rb M src/api/app/models/patchinfo.rb M src/api/app/models/project.rb M src/api/app/models/relationship.rb M src/api/app/models/review.rb M src/api/app/models/service.rb M src/api/app/models/staging/workflow.rb M src/api/app/models/update_notification_events.rb M src/api/app/models/user.rb M src/api/app/models/worker_status.rb M src/api/app/services/staging/staging_project_validator.rb M src/api/config/environments/production.rb M src/api/lib/authenticator.rb M src/api/lib/feature_switch/feature.rb M src/api/spec/controllers/webui/session_controller_spec.rb M src/api/spec/factories/bs_requests.rb M src/api/spec/factories/project.rb M src/api/test/unit/bs_request_test.rb M src/api/test/unit/package_remove_test.rb M src/api/test/unit/package_test.rb M src/api/test/unit/project_remove_test.rb M src/api/test/unit/project_test.rb Log Message: ----------- Deprecate User.current Highlight the intention of the code accessing the current user. If there should be a user session, use User.session!, if you don't care use User.session - or if you want a fallback user use User.possibly_nobody Commit: 126b1946ae448bdc4ed856ddbbf8064581cf4cb2 https://github.com/openSUSE/open-build-service/commit/126b1946ae448bdc4ed856... Author: Ana María Martínez Gómez <anamaria@martinezgomez.name> Date: 2019-05-14 (Tue, 14 May 2019) Changed paths: M src/api/app/controllers/application_controller.rb M src/api/app/controllers/build/file_controller.rb M src/api/app/controllers/build_controller.rb M src/api/app/controllers/cloud/upload_jobs_controller.rb M src/api/app/controllers/comments_controller.rb M src/api/app/controllers/message_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/published_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/source_attribute_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/source_project_config_controller.rb M src/api/app/controllers/source_project_controller.rb M src/api/app/controllers/source_project_meta_controller.rb M src/api/app/controllers/staging/staged_requests_controller.rb M src/api/app/controllers/staging/staging_projects_controller.rb M src/api/app/controllers/statistics_controller.rb M src/api/app/controllers/status/checks_controller.rb M src/api/app/controllers/status_messages_controller.rb M src/api/app/controllers/webui/cloud/azure/configurations_controller.rb M src/api/app/controllers/webui/cloud/azure/upload_jobs_controller.rb M src/api/app/controllers/webui/cloud/ec2/configurations_controller.rb M src/api/app/controllers/webui/cloud/ec2/upload_jobs_controller.rb M src/api/app/controllers/webui/cloud/upload_job/logs_controller.rb M src/api/app/controllers/webui/cloud/upload_jobs_controller.rb M src/api/app/controllers/webui/comments_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/projects/maintained_projects_controller.rb M src/api/app/controllers/webui/projects/project_configuration_controller.rb M src/api/app/controllers/webui/projects/rebuild_times_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/session_controller.rb M src/api/app/controllers/webui/staging/excluded_requests_controller.rb M src/api/app/controllers/webui/staging/projects_controller.rb M src/api/app/controllers/webui/staging/workflows_controller.rb M src/api/app/controllers/webui/status_messages_controller.rb M src/api/app/controllers/webui/user_controller.rb M src/api/app/controllers/webui/users/announcements_controller.rb M src/api/app/controllers/webui/users/rss_tokens_controller.rb M src/api/app/controllers/webui/users/subscriptions_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/controllers/webui2/comments_controller.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/helpers/webui/user_helper.rb M src/api/app/jobs/consistency_check_job.rb M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/jobs/staging_project_accept_job.rb M src/api/app/jobs/staging_project_copy_job.rb M src/api/app/mixins/has_attributes.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_maintenance_incident.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/bs_request_permission_check.rb M src/api/app/models/concerns/staging_project.rb M src/api/app/models/maintenance_incident.rb M src/api/app/models/package.rb M src/api/app/models/patchinfo.rb M src/api/app/models/project.rb M src/api/app/models/relationship.rb M src/api/app/models/review.rb M src/api/app/models/service.rb M src/api/app/models/staging/workflow.rb M src/api/app/models/update_notification_events.rb M src/api/app/models/user.rb M src/api/app/models/worker_status.rb M src/api/app/services/staging/staging_project_validator.rb M src/api/config/environments/production.rb M src/api/lib/authenticator.rb M src/api/lib/feature_switch/feature.rb M src/api/spec/controllers/webui/session_controller_spec.rb M src/api/spec/factories/bs_requests.rb M src/api/spec/factories/project.rb M src/api/test/unit/bs_request_test.rb M src/api/test/unit/package_remove_test.rb M src/api/test/unit/package_test.rb M src/api/test/unit/project_remove_test.rb M src/api/test/unit/project_test.rb Log Message: ----------- Merge pull request #7550 from coolo/more_current_user Deprecate User.current Compare: https://github.com/openSUSE/open-build-service/compare/194af5474de3...126b19...