[obs-commits] [openSUSE/open-build-service] 6f6740: Fix `notifiable_id` for comments in Notification
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6f6740bc8586f0d803a0c0a4880f932231c041bd https://github.com/openSUSE/open-build-service/commit/6f6740bc8586f0d803a0c0... Author: Eduardo Navarro <enavarro@suse.com> Date: 2020-03-23 (Mon, 23 Mar 2020) Changed paths: M src/api/app/models/comment.rb Log Message: ----------- Fix `notifiable_id` for comments in Notification In case of a notification of a comment, `notifiable_id` was filled with the bs_request id. Now we fill it with the comment id. Co-authored-by: David Kang <dkang@suse.com> Co-authored-by: Saray Cabrera Padrón <scabrerapadron@suse.de> Commit: 56e63917829594277009091411c42b1b9982dec0 https://github.com/openSUSE/open-build-service/commit/56e6391782959427700909... Author: Eduardo Navarro <enavarro@suse.com> Date: 2020-03-23 (Mon, 23 Mar 2020) Changed paths: M src/api/app/jobs/send_event_emails_job.rb M src/api/app/models/notification.rb M src/api/app/models/review.rb A src/api/app/views/notifications/_actions.text.erb A src/api/app/views/notifications/_add_role_action.text.erb A src/api/app/views/notifications/_change_devel_action.text.erb A src/api/app/views/notifications/_delete_action.text.erb A src/api/app/views/notifications/_group_action.text.erb A src/api/app/views/notifications/_set_bugowner_action.text.erb A src/api/app/views/notifications/_submit_action.text.erb A src/api/app/views/notifications/comment_for_package.text.erb A src/api/app/views/notifications/comment_for_project.text.erb A src/api/app/views/notifications/comment_for_request.text.erb A src/api/app/views/notifications/request_create.text.erb A src/api/app/views/notifications/request_statechange.text.erb A src/api/app/views/notifications/review_wanted.text.erb M src/api/app/views/webui/feeds/notifications.rss.builder Log Message: ----------- Read RSS feeds also from the new polymorphic fields ... ... from Notifications. Add new notifiable relationship with reviews. Add new templates for RSS feeds that make use of the new polymorphic fields. Don't include the diff of a submit request in a RSS notification. That's too much information for a RSS feed summary. Co-authored-by: David Kang <dkang@suse.com> Co-authored-by: Saray Cabrera Padrón <scabrerapadron@suse.de> Commit: 3e8407b9d099c584b6ec3a10ab9b3d5ea0191cca https://github.com/openSUSE/open-build-service/commit/3e8407b9d099c584b6ec3a... Author: Eduardo Navarro <enavarro@suse.com> Date: 2020-03-23 (Mon, 23 Mar 2020) Changed paths: M src/api/spec/controllers/webui/feeds_controller_spec.rb Log Message: ----------- Adapt notification controller tests to new notifications We now use the new polymorphic notification columns. Co-authored-by: David Kang <dkang@suse.com> Commit: 130cc0c32526541e1b2479aa1a5005501648bb75 https://github.com/openSUSE/open-build-service/commit/130cc0c32526541e1b2479... Author: Eduardo Navarro <enavarro@suse.com> Date: 2020-03-23 (Mon, 23 Mar 2020) Changed paths: M src/api/app/jobs/send_event_emails_job.rb Log Message: ----------- Refactor SendEventEmailsJob perform method Get rid of error prone pluralized `create_rss_notifications` method. Move code out of the `rescue` clause. Co-authored-by: David Kang <dkang@suse.com> Co-authored-by: Saray Cabrera Padrón <scabrerapadron@suse.de> Commit: 0445e7add1f13e906f50aec493d73d327144256d https://github.com/openSUSE/open-build-service/commit/0445e7add1f13e906f50ae... Author: Victor Pereira <vpereira@suse.de> Date: 2020-03-23 (Mon, 23 Mar 2020) Changed paths: M src/api/app/jobs/send_event_emails_job.rb M src/api/app/models/comment.rb M src/api/app/models/notification.rb M src/api/app/models/review.rb A src/api/app/views/notifications/_actions.text.erb A src/api/app/views/notifications/_add_role_action.text.erb A src/api/app/views/notifications/_change_devel_action.text.erb A src/api/app/views/notifications/_delete_action.text.erb A src/api/app/views/notifications/_group_action.text.erb A src/api/app/views/notifications/_set_bugowner_action.text.erb A src/api/app/views/notifications/_submit_action.text.erb A src/api/app/views/notifications/comment_for_package.text.erb A src/api/app/views/notifications/comment_for_project.text.erb A src/api/app/views/notifications/comment_for_request.text.erb A src/api/app/views/notifications/request_create.text.erb A src/api/app/views/notifications/request_statechange.text.erb A src/api/app/views/notifications/review_wanted.text.erb M src/api/app/views/webui/feeds/notifications.rss.builder M src/api/spec/controllers/webui/feeds_controller_spec.rb Log Message: ----------- Merge pull request #9249 from eduardoj/read-from-new-notification-columns Read RSS feeds also from new polymorphic notification columns Compare: https://github.com/openSUSE/open-build-service/compare/b326dd818f1f...0445e7...
participants (1)
-
Victor Pereira