[obs-commits] [openSUSE/open-build-service] e1c8d3: [webui] Add understandable flash message in Kiwi
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e1c8d384a28e3494721cc5d6c4eb425b966b377b https://github.com/openSUSE/open-build-service/commit/e1c8d384a28e3494721cc5... Author: David Kang <dkang@suse.com> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/app/controllers/webui/kiwi/images_controller.rb M src/api/app/models/kiwi/package.rb M src/api/app/models/kiwi/repository.rb M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_package_empty_name/1_3_3_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_package_empty_name/1_3_3_2.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_package_empty_name/1_3_3_3.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_repositories_data/1_3_1_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_repositories_data/1_3_1_2.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_repositories_data/1_3_1_3.yml A src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_repositories_data/1_3_1_4.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_packages_data/1_3_4_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_packages_data/1_3_4_2.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_packages_data/1_3_4_3.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/with_use_project_repositories/1_3_2_2_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/with_use_project_repositories/1_3_2_2_2.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/with_use_project_repositories/1_3_2_2_3.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/without_use_project_repositories/1_3_2_1_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/without_use_project_repositories/1_3_2_1_2.yml M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb M src/api/spec/models/kiwi/repository_spec.rb Log Message: ----------- [webui] Add understandable flash message in Kiwi We added a more understandable error message in the Kiwi Editor and also in the file view when the importation has a failure due to an invalid kiwi file. Commit: 31d1a632d469a20cddfd3cdb2bcb5c7efa3d90d2 https://github.com/openSUSE/open-build-service/commit/31d1a632d469a20cddfd3c... Author: David Kang <dkang@suse.com> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/app/assets/javascripts/webui/application/kiwi_editor.js M src/api/app/assets/stylesheets/webui/application/kiwi_image.scss M src/api/app/views/webui/kiwi/images/_package_fields.html.haml M src/api/app/views/webui/kiwi/images/_repository_fields.html.haml Log Message: ----------- [webui] Highlight elements in Kiwi Editor We highlighted the repositories and packages that are not valid. Commit: ba6550b0f2b58ff1c9939e0e896cb7a2119c9195 https://github.com/openSUSE/open-build-service/commit/ba6550b0f2b58ff1c9939e... Author: David Kang <dkang@suse.com> Date: 2017-10-18 (Wed, 18 Oct 2017) Changed paths: M src/api/app/assets/stylesheets/webui/application/kiwi_image.scss M src/api/app/controllers/webui/kiwi/images_controller.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/models/kiwi/image.rb M src/api/app/models/kiwi/repository.rb M src/api/app/views/layouts/webui/_flash.html.haml M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb Log Message: ----------- [webui] Improve Kiwi error message Commit: 3faeb2e351d57153be48a670182b8d6dd619adb9 https://github.com/openSUSE/open-build-service/commit/3faeb2e351d57153be48a6... Author: David Kang <dkang@suse.com> Date: 2017-10-18 (Wed, 18 Oct 2017) Changed paths: M src/api/spec/cassettes/Webui_Kiwi_ImagesController/GET_import_from_package/without_a_kiwi_file/1_1_1_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_package_empty_name/1_3_3_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_package_empty_name/1_3_3_2.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_package_empty_name/1_3_3_3.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_repositories_data/1_3_1_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_repositories_data/1_3_1_2.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_repositories_data/1_3_1_3.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_packages_data/1_3_4_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_packages_data/1_3_4_2.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_packages_data/1_3_4_3.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/with_use_project_repositories/1_3_2_2_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/with_use_project_repositories/1_3_2_2_2.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/with_use_project_repositories/1_3_2_2_3.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/without_use_project_repositories/1_3_2_1_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/without_use_project_repositories/1_3_2_1_2.yml M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb M src/api/spec/models/kiwi/image_spec.rb Log Message: ----------- [ci] Update test and cassettes releated to Kiwi Commit: 3c23ca48fce90ed41dd51f5bd8a833642e41352b https://github.com/openSUSE/open-build-service/commit/3c23ca48fce90ed41dd51f... Author: David Kang <dkang@suse.com> Date: 2017-10-18 (Wed, 18 Oct 2017) Changed paths: A src/api/app/helpers/webui/flash_helper.rb M src/api/app/helpers/webui/webui_helper.rb A src/api/spec/helpers/webui/flash_helper_spec.rb M src/api/spec/rails_helper.rb Log Message: ----------- [ci] Add test for flash_content helper We added test for flash_content helper and also included Haml::Helpers. Commit: d5df057ceeb98b767e524fe7c8f085bed76fa462 https://github.com/openSUSE/open-build-service/commit/d5df057ceeb98b767e524f... Author: David Kang <dkang@suse.com> Date: 2017-10-18 (Wed, 18 Oct 2017) Changed paths: M src/api/app/assets/javascripts/webui/application/kiwi_editor.js M src/api/app/assets/stylesheets/webui/application/kiwi_image.scss M src/api/app/controllers/webui/kiwi/images_controller.rb A src/api/app/helpers/webui/flash_helper.rb M src/api/app/models/kiwi/image.rb M src/api/app/models/kiwi/package.rb M src/api/app/models/kiwi/repository.rb M src/api/app/views/layouts/webui/_flash.html.haml M src/api/app/views/webui/kiwi/images/_package_fields.html.haml M src/api/app/views/webui/kiwi/images/_repository_fields.html.haml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/GET_import_from_package/without_a_kiwi_file/1_1_1_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_package_empty_name/1_3_3_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_package_empty_name/1_3_3_2.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_package_empty_name/1_3_3_3.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_repositories_data/1_3_1_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_repositories_data/1_3_1_2.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_repositories_data/1_3_1_3.yml A src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_invalid_repositories_data/1_3_1_4.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_packages_data/1_3_4_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_packages_data/1_3_4_2.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_packages_data/1_3_4_3.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/with_use_project_repositories/1_3_2_2_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/with_use_project_repositories/1_3_2_2_2.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/with_use_project_repositories/1_3_2_2_3.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/without_use_project_repositories/1_3_2_1_1.yml M src/api/spec/cassettes/Webui_Kiwi_ImagesController/POST_update/with_valid_repositories_data/without_use_project_repositories/1_3_2_1_2.yml M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb A src/api/spec/helpers/webui/flash_helper_spec.rb M src/api/spec/models/kiwi/image_spec.rb M src/api/spec/models/kiwi/repository_spec.rb M src/api/spec/rails_helper.rb Log Message: ----------- Merge pull request #3981 from DavidKang/kiwi-editor-flash-messages Kiwi Editor - Add understandable flash message Compare: https://github.com/openSUSE/open-build-service/compare/63f43b5880c3...d5df05...
participants (1)
-
David Kang