Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 52b180d9abd592ad375187704ab2002fb09bdb42 https://github.com/openSUSE/open-build-service/commit/52b180d9abd592ad375187... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-07-22 (Sun, 22 Jul 2018) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request.rb M src/api/spec/models/bs_request_spec.rb Log Message: ----------- Move request creation from request controller to model This removes quite some duplication in the controller. The conditional setting of optional request action attributes could be removed because the default values of these attributes are null. So setting source_package to params[:devel_package], where params[:devel_package] is nil, won't alter the created object. The explicit setting of request state 'new' got dropped, because there is a callback that sets any newly created request to state new. Commit: a25c7cfb28780845a814e7f606990b6efdf79360 https://github.com/openSUSE/open-build-service/commit/a25c7cfb28780845a814e7... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-07-22 (Sun, 22 Jul 2018) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- Rename variable in request controller: req -> request Commit: 2bd0dba1a8f102bb677f8ffbb20e27199076b677 https://github.com/openSUSE/open-build-service/commit/2bd0dba1a8f102bb677f8f... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2018-07-23 (Mon, 23 Jul 2018) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request.rb M src/api/spec/models/bs_request_spec.rb Log Message: ----------- Merge pull request #5423 from bgeuken/update_request_creation_in_webui_controller Update request creation in webui controller Compare: https://github.com/openSUSE/open-build-service/compare/50299519e5b3...2bd0db... **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.