Branch: refs/heads/2.6 Home: https://github.com/openSUSE/open-build-service Commit: dfa9ce9367878372ad6f1a39fdee0ca72814c395 https://github.com/openSUSE/open-build-service/commit/dfa9ce9367878372ad6f1a... Author: Jan Blunck <jblunck@infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] Fail authentication if we are not able to bind with user credentials We need to fail the authentication here because otherwise we create the user in OBS without the proper permissions. Signed-off-by: Jan Blunck <jblunck@infradead.org> Commit: f079df9e85c625a2f644b248d1bfe6a1d08e3fc6 https://github.com/openSUSE/open-build-service/commit/f079df9e85c625a2f644b2... Author: Jan Blunck <jblunck@infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] Fix UserLdapStrategy.initialize_ldap_con() error handling The code needs to check if the bind was successful before calling unbind(): LDAP::InvalidDataError: The LDAP handler has already unbound. from /srv/www/obs/api/app/models/user_ldap_strategy.rb:574:in `err' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:574:in `rescue in initialize_ldap_con' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:551:in `initialize_ldap_con' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:382:in `block in find_with_ldap' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:380:in `times' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:380:in `find_with_ldap' Signed-off-by: Jan Blunck <jblunck@infradead.org> Commit: 118683d20a509da66c99e185920e631140ccd9d0 https://github.com/openSUSE/open-build-service/commit/118683d20a509da66c99e1... Author: Jan Blunck <jblunck@infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb A src/api/test/unit/user_ldap_strategy_test.rb Log Message: ----------- [api] Extract authenticate_with_local() method from UserLdapStrategy.find_with_ldap() This refactoring extracts the local authentication into a separate function. They main purpose though was to move the extraction of user information *AFTER* the authentication is successful. Signed-off-by: Jan Blunck <jblunck@infradead.org> Commit: b837f15ec754715f2c001eb36a4993d00868ad17 https://github.com/openSUSE/open-build-service/commit/b837f15ec754715f2c001e... Author: Jan Blunck <jblunck@infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] Indention fix in UserLdapStrategy.find_with_ldap() This is a whitespace only change. Signed-off-by: Jan Blunck <jblunck@infradead.org> Commit: e595bb67f64b17a0208ef5e5cd544eb8e7a9b131 https://github.com/openSUSE/open-build-service/commit/e595bb67f64b17a0208ef5... Author: Jan Blunck <jblunck@infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb M src/api/test/unit/user_ldap_strategy_test.rb Log Message: ----------- [api] Support Distinguished Name to User Principal Name conversion for LDAP user email This is described in http://technet.microsoft.com/en-us/library/cc977992.aspx and can be used in cases the full email address of the person object is not available. Signed-off-by: Jan Blunck <jblunck@infradead.org> Compare: https://github.com/openSUSE/open-build-service/compare/aa6d4e02c56c...e595bb...