[openSUSE/open-build-service] 151e25: Extract workflow validations into three custom val...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 151e258ed11ccbbadc581c3cf46d684ba05a1995 https://github.com/openSUSE/open-build-service/commit/151e258ed11ccbbadc581c... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2021-07-20 (Tue, 20 Jul 2021) Changed paths: M src/api/app/models/token/errors.rb M src/api/app/models/workflow.rb A src/api/app/models/workflow/errors.rb M src/api/app/models/workflow/step/branch_package_step.rb M src/api/app/services/workflows/yaml_to_workflows_service.rb A src/api/app/validators/workflow_event_and_action_validator.rb A src/api/app/validators/workflow_filters_validator.rb A src/api/app/validators/workflow_steps_validator.rb Log Message: ----------- Extract workflow validations into three custom validators The event and action coming from the webhooks are no longer validated inside the BranchPackageStep but at the Workflow level. All the validations we have to do for Workflow are now splitted in three custom validators: - WorkflowEventAndActionValidator - WorkflowStepsValidator - WorkflowFiltersValidator Rename Workflow#workflow method to Workflow#workflow_instructions. Both Workflow and BranchPackageStep models are now ActiveModel and we use attribute accessors. However, we need to overwrite their initializers to include `with_indifferent_access` for the hashes. Co-authored-by: Daniel Donisa <daniel.donisa@suse.com> Co-authored-by: Dany Marcoux <dmarcoux@suse.com> Co-authored-by: Rubhan Azeem <rubhan.azeem@suse.com> Co-authored-by: Saray Cabrera Padrón <scabrerapadron@suse.de> Commit: f251cde499f983dcc44b168c32deb5eab218d2b9 https://github.com/openSUSE/open-build-service/commit/f251cde499f983dcc44b16... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2021-07-20 (Tue, 20 Jul 2021) Changed paths: A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/but_we_don_t_provide_a_source_package/behaves_like_source_package_not_provided/1_1_1_2_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/but_we_don_t_provide_a_source_package/behaves_like_source_package_not_provided/1_2_1_2_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/but_we_don_t_provide_source_project/behaves_like_source_project_not_provided/1_1_1_1_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/but_we_don_t_provide_source_project/behaves_like_source_project_not_provided/1_2_1_1_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_failed_when_project_name_is_invalid/1_1_1_3_3_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_failed_when_source_package_does_not_exist/1_1_1_3_2_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_failed_without_branch_permissions/1_1_1_3_4_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_3.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_4.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_5.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_6.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_2_1_3_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_2_1_3_1_2.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_2_1_3_1_3.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_2_1_3_1_4.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_2_1_3_1_5.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_2_1_3_1_6.yml M src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/only_reports_for_repositories_and_architectures_matching_the_filters.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_1_4_1_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_1_4_1_1_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_1_4_1_1_4.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_1_4_1_1_5.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_1_4_1_1_6.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_1_4_1_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_1_4_1_1_2.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_1_4_1_1_4.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_1_4_1_1_5.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_1_4_1_1_6.yml M src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/updates__branch_request_file_including_new_commit_sha.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_1_1_4_2_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_1_1_4_2_1_2.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_2_1_4_2_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_2_1_4_2_1_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/but_we_don_t_provide_a_source_package/behaves_like_source_package_not_provided/1_1_2_2_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/but_we_don_t_provide_a_source_package/behaves_like_source_package_not_provided/1_2_2_2_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/but_we_don_t_provide_source_project/behaves_like_source_project_not_provided/1_1_2_1_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/but_we_don_t_provide_source_project/behaves_like_source_project_not_provided/1_2_2_1_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_failed_when_project_name_is_invalid/1_1_2_3_3_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_failed_when_source_package_does_not_exist/1_1_2_3_2_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_failed_without_branch_permissions/1_1_2_3_4_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_3.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_4.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_5.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_6.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_2_2_3_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_2_2_3_1_2.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_2_2_3_1_3.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_2_2_3_1_4.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_2_2_3_1_5.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_2_2_3_1_6.yml M src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/only_reports_for_repositories_and_architectures_matching_the_filters.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_2_4_1_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_2_4_1_1_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_2_4_1_1_4.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_2_4_1_1_5.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_2_4_1_1_6.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_2_4_1_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_2_4_1_1_2.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_2_4_1_1_4.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_2_4_1_1_5.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_2_4_1_1_6.yml M src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/updates__branch_request_file_including_new_commit_sha.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_1_2_4_2_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_1_2_4_2_1_2.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_2_2_4_2_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_2_2_4_2_1_2.yml M src/api/spec/models/token/workflow_spec.rb M src/api/spec/models/workflow/step/branch_package_step_spec.rb M src/api/spec/models/workflow_spec.rb A src/api/spec/validators/workflow_event_and_action_validator_spec.rb Log Message: ----------- Add specs for new Workflow custom validators Add specific spec for WorkflowEventAndActionValidator. Add specs for validations inside the models' specs. Co-authored-by: Daniel Donisa <daniel.donisa@suse.com> Co-authored-by: Dany Marcoux <dmarcoux@suse.com> Co-authored-by: Rubhan Azeem <rubhan.azeem@suse.com> Co-authored-by: Saray Cabrera Padrón <scabrerapadron@suse.de> Commit: 4c6753e444932f4d432cb8d495ca1f2f8cc83f09 https://github.com/openSUSE/open-build-service/commit/4c6753e444932f4d432cb8... Author: Dani Donisa <daniel.donisa@suse.com> Date: 2021-07-21 (Wed, 21 Jul 2021) Changed paths: M src/api/app/models/token/errors.rb M src/api/app/models/workflow.rb A src/api/app/models/workflow/errors.rb M src/api/app/models/workflow/step/branch_package_step.rb M src/api/app/services/workflows/yaml_to_workflows_service.rb A src/api/app/validators/workflow_event_and_action_validator.rb A src/api/app/validators/workflow_filters_validator.rb A src/api/app/validators/workflow_steps_validator.rb A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/but_we_don_t_provide_a_source_package/behaves_like_source_package_not_provided/1_1_1_2_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/but_we_don_t_provide_a_source_package/behaves_like_source_package_not_provided/1_2_1_2_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/but_we_don_t_provide_source_project/behaves_like_source_project_not_provided/1_1_1_1_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/but_we_don_t_provide_source_project/behaves_like_source_project_not_provided/1_2_1_1_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_failed_when_project_name_is_invalid/1_1_1_3_3_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_failed_when_source_package_does_not_exist/1_1_1_3_2_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_failed_without_branch_permissions/1_1_1_3_4_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_3.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_4.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_5.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_6.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_2_1_3_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_2_1_3_1_2.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_2_1_3_1_3.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_2_1_3_1_4.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_2_1_3_1_5.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_2_1_3_1_6.yml M src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/only_reports_for_repositories_and_architectures_matching_the_filters.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_1_4_1_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_1_4_1_1_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_1_4_1_1_4.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_1_4_1_1_5.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_1_4_1_1_6.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_1_4_1_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_1_4_1_1_2.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_1_4_1_1_4.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_1_4_1_1_5.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_1_4_1_1_6.yml M src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/updates__branch_request_file_including_new_commit_sha.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_1_1_4_2_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_1_1_4_2_1_2.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_2_1_4_2_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_2_1_4_2_1_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/but_we_don_t_provide_a_source_package/behaves_like_source_package_not_provided/1_1_2_2_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/but_we_don_t_provide_a_source_package/behaves_like_source_package_not_provided/1_2_2_2_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/but_we_don_t_provide_source_project/behaves_like_source_project_not_provided/1_1_2_1_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/but_we_don_t_provide_source_project/behaves_like_source_project_not_provided/1_2_2_1_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_failed_when_project_name_is_invalid/1_1_2_3_3_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_failed_when_source_package_does_not_exist/1_1_2_3_2_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_failed_without_branch_permissions/1_1_2_3_4_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_3.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_4.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_5.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_6.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_2_2_3_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_2_2_3_1_2.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_2_2_3_1_3.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_2_2_3_1_4.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_2_2_3_1_5.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_2_2_3_1_6.yml M src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/only_reports_for_repositories_and_architectures_matching_the_filters.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_2_4_1_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_2_4_1_1_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_2_4_1_1_4.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_2_4_1_1_5.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_1_2_4_1_1_6.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_2_4_1_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_2_4_1_1_2.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_2_4_1_1_4.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_2_4_1_1_5.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/1_2_2_4_1_1_6.yml M src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_already_existed/behaves_like_successful_update_event_when_the_branch_package_already_exists/updates__branch_request_file_including_new_commit_sha.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_1_2_4_2_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_1_2_4_2_1_2.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_2_2_4_2_1_1.yml R src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_branched_package_did_not_exist/behaves_like_non-existent_branched_package/1_2_2_4_2_1_2.yml M src/api/spec/models/token/workflow_spec.rb M src/api/spec/models/workflow/step/branch_package_step_spec.rb M src/api/spec/models/workflow_spec.rb A src/api/spec/validators/workflow_event_and_action_validator_spec.rb Log Message: ----------- Merge pull request #11386 from danidoni/extract-workflow-validations-from-branch-package-step Refactor workflow moving validations to custom validators Compare: https://github.com/openSUSE/open-build-service/compare/fd09adba1838...4c6753...
participants (1)
-
Dani Donisa