[openSUSE/open-build-service] 3f7e10: Fix APIMatcher being to greedy
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3f7e10e48c00cbe09ecdf5bc005f135c06e8e0ea https://github.com/openSUSE/open-build-service/commit/3f7e10e48c00cbe09ecdf5... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2022-07-25 (Mon, 25 Jul 2022) Changed paths: M src/api/app/controllers/concerns/rescue_authorization_handler.rb Log Message: ----------- Fix APIMatcher being to greedy The APIMatcher sets the request format to XML if it's unset. That lead to render_error being used in the WebUI namespace which does now know about this helper. Let's use render directly instead. Fixes #12850 Commit: 4f97f4392ed4dcb9cff186519b26e0ca61d0aaae https://github.com/openSUSE/open-build-service/commit/4f97f4392ed4dcb9cff186... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2022-07-25 (Mon, 25 Jul 2022) Changed paths: A src/api/spec/controllers/concerns/rescue_authorization_handler_spec.rb Log Message: ----------- Spec out RescueAuthorizationHandler Commit: 1ee1913cb83d0aefcc10cb12bbaa8e744ad3eb44 https://github.com/openSUSE/open-build-service/commit/1ee1913cb83d0aefcc10cb... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2022-07-25 (Mon, 25 Jul 2022) Changed paths: M src/api/spec/controllers/webui/repositories_controller_spec.rb Log Message: ----------- Test status not message content The important part is that it's forbidden, not what it spews... Commit: 84e692053b17e63271bef06addb5d398217a10e4 https://github.com/openSUSE/open-build-service/commit/84e692053b17e63271bef0... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2022-07-25 (Mon, 25 Jul 2022) Changed paths: M src/api/spec/controllers/webui/feeds_controller_spec.rb Log Message: ----------- Remove superflouous test The ProjectPolicy is tested in the ProjectPolicy spec Commit: 98c47b7af79c49b5804b74c3522c8827cca997bb https://github.com/openSUSE/open-build-service/commit/98c47b7af79c49b5804b74... Author: Lukas Krause <lkrause@suse.de> Date: 2022-07-25 (Mon, 25 Jul 2022) Changed paths: M src/api/app/controllers/concerns/rescue_authorization_handler.rb A src/api/spec/controllers/concerns/rescue_authorization_handler_spec.rb M src/api/spec/controllers/webui/feeds_controller_spec.rb M src/api/spec/controllers/webui/repositories_controller_spec.rb Log Message: ----------- Merge pull request #12859 from hennevogel/refactoring/requests-without-format Handle requests without format in RescueAuthorizationHandler Compare: https://github.com/openSUSE/open-build-service/compare/7381b16358d8...98c47b...
participants (1)
-
Lukas Krause