[openSUSE/open-build-service] 336339: Get rid of `find_by_attribute_type` Project class ...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3363394c9128057b71438bf8e0c54b2181b93c53 https://github.com/openSUSE/open-build-service/commit/3363394c9128057b71438b... Author: Eduardo Navarro <enavarro@suse.com> Date: 2024-08-29 (Thu, 29 Aug 2024) Changed paths: M src/api/app/controllers/search_controller.rb M src/api/app/jobs/project_create_auto_cleanup_requests_job.rb M src/api/app/models/branch_package.rb M src/api/app/models/branch_package/lookup_incident_package.rb M src/api/app/models/concerns/project_maintenance.rb M src/api/app/models/owner_search/base.rb M src/api/app/models/project.rb M src/api/app/services/user_service/involved.rb Log Message: ----------- Get rid of `find_by_attribute_type` Project class method It only abstracts what Rails already provides with its Active Record Query interface methods. Also, the `find_by` part of the method is confusing. Commit: ca74727e465cf574ed19cf80a5bc9d1daaa7c012 https://github.com/openSUSE/open-build-service/commit/ca74727e465cf574ed19cf... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2024-08-29 (Thu, 29 Aug 2024) Changed paths: M src/api/app/controllers/search_controller.rb M src/api/app/jobs/project_create_auto_cleanup_requests_job.rb M src/api/app/models/branch_package.rb M src/api/app/models/branch_package/lookup_incident_package.rb M src/api/app/models/concerns/project_maintenance.rb M src/api/app/models/owner_search/base.rb M src/api/app/models/project.rb M src/api/app/services/user_service/involved.rb Log Message: ----------- Merge pull request #16773 from eduardoj/refactoring/project_find_by_attribute_type Get rid of `find_by_attribute_type` Project class method Compare: https://github.com/openSUSE/open-build-service/compare/42b16ef9d57f...ca7472... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications
participants (1)
-
Henne Vogelsang