[openSUSE/open-build-service] 4b6c8b: Use dom_id for mark_as_read_or_unread_button
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4b6c8b067c5265b8d1d97851ac70d2e5571857b8 https://github.com/openSUSE/open-build-service/commit/4b6c8b067c5265b8d1d978... Author: Dany Marcoux <dmarcoux@posteo.de> Date: 2022-02-14 (Mon, 14 Feb 2022) Changed paths: M src/api/app/helpers/webui/notification_helper.rb Log Message: ----------- Use dom_id for mark_as_read_or_unread_button This is what ActionView uses to associate records with DOM elements. Let's use it too! https://api.rubyonrails.org/classes/ActionView/RecordIdentifier.html#method-... The generated ID is slightly different, `dom_id` uses underscores instead of dashes. So before, it was `update-notification-123`, now it's `update_notification_123`. It's not an issue, as we don't refer to this ID in any code. Commit: 180163979e2f4825cbcc6a538755927f4b272dbc https://github.com/openSUSE/open-build-service/commit/180163979e2f4825cbcc6a... Author: Dany Marcoux <danymarcoux@gmail.com> Date: 2022-02-14 (Mon, 14 Feb 2022) Changed paths: M src/api/app/helpers/webui/notification_helper.rb Log Message: ----------- Merge pull request #12203 from dmarcoux/notifications-dom_id Use dom_id for mark_as_read_or_unread_button Compare: https://github.com/openSUSE/open-build-service/compare/a3e7a4d13bc9...180163...
participants (1)
-
Dany Marcoux