[obs-commits] [openSUSE/open-build-service] 410c58: Cache Package#show file list
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 410c5813bb83fb5c8f139edc393f609922a6f5e9 https://github.com/openSUSE/open-build-service/commit/410c5813bb83fb5c8f139e... Author: Christian Bruckmayer <cbruckmayer@suse.com> Date: 2018-12-12 (Wed, 12 Dec 2018) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock M src/api/app/assets/javascripts/webui/application.js.erb M src/api/app/assets/javascripts/webui2/application.js A src/api/app/views/webui/package/_file.html.erb M src/api/app/views/webui/package/_files_view.html.erb A src/api/app/views/webui2/webui/package/_file.html.haml M src/api/app/views/webui2/webui/package/_files_view.html.haml Log Message: ----------- Cache Package#show file list InfluxDB performance measuring showed that this view is a bottleneck on Package#show with a mean render time of ~ 280 ms (bootstrap) and 160 ms (bentoo). Therefore we introduce now collection caching. We also need to introduce timeago_tag jquery gem to be able to cache the table otherwise the timeago would be cached as well causing wrong results. Commit: 09fa6b5e3d4eddb05af766cb51235a3aaaf6fe99 https://github.com/openSUSE/open-build-service/commit/09fa6b5e3d4eddb05af766... Author: Christian Bruckmayer <cbruckmayer@suse.com> Date: 2018-12-12 (Wed, 12 Dec 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- Remove unnecessary backend call from Package#show We already have the file list requested, we don't need to ask the backend again about the _service file. This removes ~100ms from the request time. Commit: 5eedd936ed8f0a8a51bd972f7d3a89768880802c https://github.com/openSUSE/open-build-service/commit/5eedd936ed8f0a8a51bd97... Author: Christian Bruckmayer <cbruckmayer@suse.com> Date: 2018-12-12 (Wed, 12 Dec 2018) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock M src/api/app/assets/javascripts/webui/application.js.erb M src/api/app/assets/javascripts/webui2/application.js M src/api/app/controllers/webui/package_controller.rb A src/api/app/views/webui/package/_file.html.erb M src/api/app/views/webui/package/_files_view.html.erb A src/api/app/views/webui2/webui/package/_file.html.haml M src/api/app/views/webui2/webui/package/_files_view.html.haml Log Message: ----------- Merge pull request #6590 from ChrisBr/package/performance Improve Package#show performance Compare: https://github.com/openSUSE/open-build-service/compare/a030960c21be...5eedd9... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Christian Bruckmayer