[openSUSE/open-build-service] 80be06: Add little improvements
Branch: refs/heads/workflow_token Home: https://github.com/openSUSE/open-build-service Commit: 80be06a13e4b5848cc280a5e54d4e2589901fd4f https://github.com/openSUSE/open-build-service/commit/80be06a13e4b5848cc280a... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2021-05-03 (Mon, 03 May 2021) Changed paths: M src/api/app/controllers/trigger_workflow_controller.rb M src/api/app/models/token/workflow.rb M src/api/app/services/trigger_controller_service/scm_extractor.rb Log Message: ----------- Add little improvements - Drop unnecessary curly brackets from method parameters. - Don't assign to variable values that are going to be used only once. - Add .with_indifferent_access to SCMExtractor resulting payload. - Adjust comments. - Rename 'accepted*_event_and_action' to 'allowed*_event_and_action' to be consistent with the constant names (ALLOWED_GITHUB_ACTIONS, ALLOWED_GITLAB_ACTIONS). Commit: 23d9fd950e8d8e08609a96565d08dd55ddc8638a https://github.com/openSUSE/open-build-service/commit/23d9fd950e8d8e08609a96... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2021-05-03 (Mon, 03 May 2021) Changed paths: M src/api/app/controllers/trigger_workflow_controller.rb M src/api/app/models/token/workflow.rb M src/api/app/services/trigger_controller_service/scm_extractor.rb Log Message: ----------- Merge pull request #11072 from saraycp/little_fixes Add little improvements Compare: https://github.com/openSUSE/open-build-service/compare/a7abd1c27a81...23d9fd...
participants (1)
-
Saray Cabrera Padrón