[openSUSE/open-build-service] 9b3805: Create an AddedUserToGroup event when a user is ad...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9b3805e20fd2e5e53afeb20264e8dd6d97ca1d31 https://github.com/openSUSE/open-build-service/commit/9b3805e20fd2e5e53afeb2... Author: Steven R. Baker <steven@stevenrbaker.com> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: A src/api/app/models/event/added_user_to_group.rb M src/api/app/models/groups_user.rb Log Message: ----------- Create an AddedUserToGroup event when a user is added to a group. Commit: 9736b9bf4d9a16258473635dac4db1859f62f5ae https://github.com/openSUSE/open-build-service/commit/9736b9bf4d9a1625847363... Author: Steven R. Baker <steven@stevenrbaker.com> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: A src/api/app/models/event/removed_user_from_group.rb M src/api/app/models/group.rb Log Message: ----------- Create a RemovedUserFromGroup event when a user is removed from a group. Commit: 9516f84b3bce9a57ba068598c96a8947bc32533b https://github.com/openSUSE/open-build-service/commit/9516f84b3bce9a57ba0685... Author: Steven R. Baker <steven@stevenrbaker.com> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/models/event/base.rb Log Message: ----------- Add the notification events for the new event type. Commit: 21ed4ca2f3e302e6609af4bea56918fda9a22539 https://github.com/openSUSE/open-build-service/commit/21ed4ca2f3e302e6609af4... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/models/event/added_user_to_group.rb M src/api/app/models/event/removed_user_from_group.rb M src/api/app/models/event_subscription.rb M src/api/app/services/notification_service/notifier.rb Log Message: ----------- Add user receiver_role Commit: 47f5524d2be22fef1be697634488b226fb72af8f https://github.com/openSUSE/open-build-service/commit/47f5524d2be22fef1be697... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/models/event_subscription/for_channel_form.rb Log Message: ----------- Discard new events from RSS Events: AddedUserToGroup and RemovedUserFromGroup. Commit: 423350a4b3f55af2934268456229849cbe0e9bce https://github.com/openSUSE/open-build-service/commit/423350a4b3f55af2934268... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/models/group.rb M src/api/app/models/groups_user.rb Log Message: ----------- Pass User#login instead of the object to payload There is no need to pass the whole object to the event payload, we can retrieve the object later. Same for Group#title. Commit: 375fa56c4fd89feecc19feffd3bff978de1ce001 https://github.com/openSUSE/open-build-service/commit/375fa56c4fd89feecc19fe... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/models/event/added_user_to_group.rb M src/api/app/models/event/removed_user_from_group.rb M src/api/app/models/group.rb M src/api/app/models/groups_user.rb Log Message: ----------- Store in payload who added the user to the group Mention who in subject. It might not exist if it was the application and not a user who added the user. That happens in request acceptance, for example. Commit: 13f732fa1bb430166956037cf85104200719f805 https://github.com/openSUSE/open-build-service/commit/13f732fa1bb43016695603... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/models/event/added_user_to_group.rb M src/api/app/models/event/removed_user_from_group.rb Log Message: ----------- Define originator Commit: c3931cb70c9d3f0ab40e2b4501c3dae77cddf3e3 https://github.com/openSUSE/open-build-service/commit/c3931cb70c9d3f0ab40e2b... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/services/notification_service/notifier.rb Log Message: ----------- Discard new kinds of notifications from RSS Commit: d61ebe4cd26bfcc0c4df5232910190d041eb959b https://github.com/openSUSE/open-build-service/commit/d61ebe4cd26bfcc0c4df52... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/models/event/added_user_to_group.rb M src/api/app/models/event/removed_user_from_group.rb M src/api/app/services/notification_service/notifier.rb Log Message: ----------- Define parameters_for_notification on new events Also add the new type of notifiable: GroupsUser. Commit: 75406df5944c521b9bd5d0f90b74103a37fe876c https://github.com/openSUSE/open-build-service/commit/75406df5944c521b9bd5d0... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: A src/api/app/queries/outdated_notifications_finder/group.rb M src/api/app/services/notification_service/web_channel.rb Log Message: ----------- Add OutdatedNotificationsFinder::Group Commit: c3a370d6a99b80661047e3ceb9f908c9295511bc https://github.com/openSUSE/open-build-service/commit/c3a370d6a99b80661047e3... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/services/notified_projects.rb Log Message: ----------- Handle notifiable type Group NotifiedProject Commit: fae32715855f9e7025d3c4ffe4e573f028ce8bd2 https://github.com/openSUSE/open-build-service/commit/fae32715855f9e7025d3c4... Author: Lukas Krause <lkrause@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/components/notification_component.rb M src/api/app/components/notification_notifiable_link_component.rb Log Message: ----------- Add notification link and avatar for group add/remove Commit: 45f19e37dd04e800e582e24bcbb97a24519373be https://github.com/openSUSE/open-build-service/commit/45f19e37dd04e800e582e2... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/components/notification_avatars_component.rb Log Message: ----------- Handle Group in NotificationAvatarsComponent Commit: 3ed75db9cc2819018a8ecace6bc54916b126b5a9 https://github.com/openSUSE/open-build-service/commit/3ed75db9cc2819018a8eca... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/components/notification_component.rb Log Message: ----------- Use a group icon for the new events For both AddedUserToGroup and RemovedUserFromGroup (which was missing before). Commit: be9683599fe0c651a7be0e0c7e0c9eef8784e08e https://github.com/openSUSE/open-build-service/commit/be9683599fe0c651a7be0e... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/controllers/concerns/webui/notifications_filter.rb M src/api/app/controllers/person/notifications_controller.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/models/notification.rb M src/api/app/views/webui/users/notifications/_notification_filter.html.haml Log Message: ----------- Add filter for the new kinds of notifications Filter member_on_groups include both added and removed users. Commit: 126f22c8aa5bf79c2a6ad5848e0bc8ac084ee83d https://github.com/openSUSE/open-build-service/commit/126f22c8aa5bf79c2a6ad5... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/.haml-lint_todo.yml Log Message: ----------- Exclude haml-lint complain about ViewLengh The linter complains with "ViewLength: View template is too long". As there will be a refactoring soon, we can exclude it for now. It's added to .haml-lint_todo.yml with `haml-lint --auto-gen-config`. Commit: 4a8c43c0e21c32290cca2bfbc34fb256d746fd07 https://github.com/openSUSE/open-build-service/commit/4a8c43c0e21c32290cca2b... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: A src/api/app/views/event_mailer/added_user_to_group.html.haml A src/api/app/views/event_mailer/added_user_to_group.text.erb A src/api/app/views/event_mailer/removed_user_from_group.html.haml A src/api/app/views/event_mailer/removed_user_from_group.text.erb M src/api/spec/factories/event_subscriptions.rb M src/api/spec/mailers/event_mailer_spec.rb Log Message: ----------- Add emails for Group notifications Add mailer specs as well. Commit: b830cc57c8bb82f1f5ddd1580e87bc9cc0ccc136 https://github.com/openSUSE/open-build-service/commit/b830cc57c8bb82f1f5ddd1... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/lib/tasks/dev/notifications.rake M src/api/lib/tasks/dev/rake_support.rb Log Message: ----------- Add test data about Group notifications Commit: baa7530ef9680278b4df813a65dc7ea3aba622f4 https://github.com/openSUSE/open-build-service/commit/baa7530ef9680278b4df81... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/components/notification_notifiable_link_component.rb Log Message: ----------- Add link only if the group still exists Commit: 032cc0f8ab91d9c54456d80006e2abf41159426d https://github.com/openSUSE/open-build-service/commit/032cc0f8ab91d9c54456d8... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/controllers/concerns/webui/notifications_filter.rb M src/api/app/controllers/person/notifications_controller.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/models/event/added_user_to_group.rb M src/api/app/models/event/removed_user_from_group.rb M src/api/app/models/event_subscription.rb M src/api/app/models/group.rb M src/api/app/models/groups_user.rb M src/api/app/models/notification.rb M src/api/app/views/webui/users/notifications/_notification_filter.html.haml M src/api/spec/factories/event_subscriptions.rb M src/api/spec/mailers/event_mailer_spec.rb Log Message: ----------- Replace receiver role from user to member Remove leftovers added_user_to_groups and removed_user_from_groups Commit: abdba00915cc7167735352cc18b199787b522abd https://github.com/openSUSE/open-build-service/commit/abdba00915cc7167735352... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/app/queries/outdated_notifications_finder/group.rb Log Message: ----------- Fix OutdatedNotificationsFinder::Group The goal is to avoid many notifications about the same topic. There will always be only one notification about user U added as a member of group G. Even if someone adds and removes U from G many times. Commit: 342842fbac02576e758f3914e7e4201458acc633 https://github.com/openSUSE/open-build-service/commit/342842fbac02576e758f39... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2024-06-13 (Thu, 13 Jun 2024) Changed paths: M src/api/.haml-lint_todo.yml M src/api/app/components/notification_avatars_component.rb M src/api/app/components/notification_component.rb M src/api/app/components/notification_notifiable_link_component.rb M src/api/app/controllers/concerns/webui/notifications_filter.rb M src/api/app/controllers/person/notifications_controller.rb M src/api/app/controllers/webui/users/notifications_controller.rb A src/api/app/models/event/added_user_to_group.rb M src/api/app/models/event/base.rb A src/api/app/models/event/removed_user_from_group.rb M src/api/app/models/event_subscription.rb M src/api/app/models/event_subscription/for_channel_form.rb M src/api/app/models/group.rb M src/api/app/models/groups_user.rb M src/api/app/models/notification.rb A src/api/app/queries/outdated_notifications_finder/group.rb M src/api/app/services/notification_service/notifier.rb M src/api/app/services/notification_service/web_channel.rb M src/api/app/services/notified_projects.rb A src/api/app/views/event_mailer/added_user_to_group.html.haml A src/api/app/views/event_mailer/added_user_to_group.text.erb A src/api/app/views/event_mailer/removed_user_from_group.html.haml A src/api/app/views/event_mailer/removed_user_from_group.text.erb M src/api/app/views/webui/users/notifications/_notification_filter.html.haml M src/api/lib/tasks/dev/notifications.rake M src/api/lib/tasks/dev/rake_support.rb M src/api/spec/factories/event_subscriptions.rb M src/api/spec/mailers/event_mailer_spec.rb Log Message: ----------- Merge pull request #16242 from saraycp/notify_users_on_groups Notify users on groups Compare: https://github.com/openSUSE/open-build-service/compare/4d320ee1198a...342842... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications
participants (1)
-
Henne Vogelsang