[obs-commits] [openSUSE/open-build-service] 7cb86e: [frontend] Fix slow hash performance (rubocop)
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7cb86ed1d23af77c62f8621c43ca45c068988d8a https://github.com/openSUSE/open-build-service/commit/7cb86ed1d23af77c62f862... Author: Stephan Kulow <coolo@suse.de> Date: 2018-06-25 (Mon, 25 Jun 2018) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/models/user.rb Log Message: ----------- [frontend] Fix slow hash performance (rubocop) `Hash#keys.include?` is less efficient than `Hash#key?` because the former allocates a new array and then performs an O(n) search through that array, while `Hash#key?` does not allocate any array and performs a faster O(1) search for the key. Commit: 7fcb0db401e39ab23630083bec074171b191bebb https://github.com/openSUSE/open-build-service/commit/7fcb0db401e39ab2363008... Author: Christian Bruckmayer <cbruckmayer@suse.com> Date: 2018-06-26 (Tue, 26 Jun 2018) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/models/user.rb Log Message: ----------- Merge pull request #5207 from coolo/fix_hash_performance [frontend] Fix slow hash performance (rubocop) Compare: https://github.com/openSUSE/open-build-service/compare/42ede7820b2e...7fcb0d... **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Christian Bruckmayer