[obs-commits] [openSUSE/open-build-service] 3a3c98: Migrate group edit to Bootstrap
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3a3c984b8bbe0d4d5b422fddf0ad6cd722671266 https://github.com/openSUSE/open-build-service/commit/3a3c984b8bbe0d4d5b422f... Author: Eduardo Navarro <enavarro@suse.com> Date: 2018-12-06 (Thu, 06 Dec 2018) Changed paths: M src/api/app/controllers/webui/groups_controller.rb A src/api/app/controllers/webui2/groups_controller.rb A src/api/app/views/webui2/webui/groups/_add_user_modal.html.haml M src/api/app/views/webui2/webui/groups/_breadcrumb_items.html.haml A src/api/app/views/webui2/webui/groups/_remove_user_modal.html.haml M src/api/app/views/webui2/webui/groups/show.html.haml M src/api/config/routes.rb Log Message: ----------- Migrate group edit to Bootstrap Instead of using a tokenfield in a new screen it has been added: - A delete icon for each row in the table, for deleting a user. - An "Add user" link, for adding a user using a modal with an autocomplete box. This way we don't use tokenfield, that is currently not maintained. Commit: c1b9b8cda8c94687bb9b066a6c548e344585eaf8 https://github.com/openSUSE/open-build-service/commit/c1b9b8cda8c94687bb9b06... Author: Eduardo Navarro <enavarro@suse.com> Date: 2018-12-06 (Thu, 06 Dec 2018) Changed paths: A src/api/spec/bootstrap/features/webui/groups_spec.rb A src/api/spec/cassettes/Groups/add_a_user.yml A src/api/spec/cassettes/Groups/visit_group_page.yml R src/api/spec/features/webui/groups_spec.rb Log Message: ----------- Migrate group edit tests to Bootstrap Commit: 8d9a3237968e36c264db980f2ba0799bfacc28c4 https://github.com/openSUSE/open-build-service/commit/8d9a3237968e36c264db98... Author: Dany Marcoux <dmarcoux@posteo.de> Date: 2018-12-06 (Thu, 06 Dec 2018) Changed paths: M src/api/app/controllers/webui/groups_controller.rb A src/api/app/controllers/webui2/groups_controller.rb A src/api/app/views/webui2/webui/groups/_add_user_modal.html.haml M src/api/app/views/webui2/webui/groups/_breadcrumb_items.html.haml A src/api/app/views/webui2/webui/groups/_remove_user_modal.html.haml M src/api/app/views/webui2/webui/groups/show.html.haml M src/api/config/routes.rb A src/api/spec/bootstrap/features/webui/groups_spec.rb A src/api/spec/cassettes/Groups/add_a_user.yml A src/api/spec/cassettes/Groups/visit_group_page.yml R src/api/spec/features/webui/groups_spec.rb Log Message: ----------- Merge pull request #6451 from eduardoj/bootstrap_group_edit Migrate group edit to Bootstrap Compare: https://github.com/openSUSE/open-build-service/compare/fb6978a4f271...8d9a32... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Dany Marcoux