[openSUSE/open-build-service] 6a56f3: Only set the acceptinfo oxsrcmd5/xsrcmd5 attr if t...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6a56f31f1ccaf772f86e136d784a2821d52d8cfb https://github.com/openSUSE/open-build-service/commit/6a56f31f1ccaf772f86e13... Author: Marcus Huewe <suse-tux@gmx.de> Date: 2021-06-25 (Fri, 25 Jun 2021) Changed paths: M src/backend/bs_srcserver Log Message: ----------- Only set the acceptinfo oxsrcmd5/xsrcmd5 attr if the link can be expanded The old code sets the oxsrcmd5/xsrcmd5 attribute of the <acceptinfo/> element even if the corresponding link cannot be expanded. In this case, the oxsrcmd5/xsrcmd5 refers to the unexpanded sources, which contradicts the purpose of the oxsrcmd5/xsrcmd5. In order to fix this, only set these attributes if the correponding links can be expanded. If a link cannot be expanded, BSSrcServer::Link::handlelinks either dies or returns an error string, where the latter is not checked by the old code. Hence, only set the oxsrcmd5/xsrcmd5 if handlelinks returns a reference. Commit: aa810ff69d5eac4c5032c1149ff0c4bd1fe7d8e2 https://github.com/openSUSE/open-build-service/commit/aa810ff69d5eac4c5032c1... Author: Marcus Huewe <suse-tux@gmx.de> Date: 2021-06-28 (Mon, 28 Jun 2021) Changed paths: M src/backend/bs_srcserver Log Message: ----------- Merge branch 'fix_acceptinfo_xsrcmd5' of https://github.com/marcus-h/open-build-service Only set the acceptinfo oxsrcmd5/xsrcmd5 attr if the link can be expanded. Compare: https://github.com/openSUSE/open-build-service/compare/4f0ed1526c59...aa810f...
participants (1)
-
Marcus Hüwe