[obs-commits] [openSUSE/open-build-service] ba7fa1: [api] dynamic :action segment is deprecated
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ba7fa140f4a53e2051f1bac0b65eb4241c0eec6a https://github.com/openSUSE/open-build-service/commit/ba7fa140f4a53e2051f1ba... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2016-11-16 (Wed, 16 Nov 2016) Changed paths: M src/api/config/routes.rb Log Message: ----------- [api] dynamic :action segment is deprecated Using a dynamic :action segment in a route is deprecated and will be removed in Rails 5.1. I have changed `get 'public/status/:action' => 'status#index'` by `get "public/status/method_name" => "status#method_name"` for any of the method in the status controller. Note that this is not exactly the same as what we used to have, as before routes like `public/status/permitted_attributes` and `public/status/auth_method` were available. But I think that we do not want this routes to be available, so this fix the deprecation warning and the fact that this kind of routes are available. Commit: 99f0085f8fc256abd7a716d44f947bd06766e616 https://github.com/openSUSE/open-build-service/commit/99f0085f8fc256abd7a716... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2016-11-16 (Wed, 16 Nov 2016) Changed paths: M src/api/config/routes.rb Log Message: ----------- [api] Move the public/status routes Move the public/status routes to the status controller section as all this routes are using methods in this controller, so from my point of view it makes more sense that they are there. Commit: e950c8836e1b20e8d740c2cfb19e2379b16c7a4d https://github.com/openSUSE/open-build-service/commit/e950c8836e1b20e8d740c2... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-11-16 (Wed, 16 Nov 2016) Changed paths: M src/api/config/routes.rb Log Message: ----------- Merge pull request #2335 from Ana06/action_deprecated dynamic :action segment is deprecated & unexpected routes are available Compare: https://github.com/openSUSE/open-build-service/compare/a2215cc272dc...e950c8...
participants (1)
-
Björn Geuken