Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 3ee580b44f87f060a0f1f68fd4797f6bb96935a0
https://github.com/openSUSE/open-build-service/commit/3ee580b44f87f060a0f1f6...
Author: Björn Geuken
Date: 2019-03-01 (Fri, 01 Mar 2019)
Changed paths:
M src/api/app/controllers/webui/package_controller.rb
M src/api/app/controllers/webui/packages/build_reason_controller.rb
M src/api/app/controllers/webui/packages/job_history_controller.rb
M src/api/app/controllers/webui/projects/project_configuration_controller.rb
M src/api/app/controllers/webui/webui_controller.rb
M src/api/spec/controllers/webui/package_controller_spec.rb
M src/api/spec/controllers/webui/projects/project_configuration_controller_spec.rb
Log Message:
-----------
Use correct exception when a record can not be found
In 4a505f1b34f37350159b782563eacbc4fd0700a1 the "nextstatus"
code was replaced by raising an exception which is handled by OBS
and causes a 404 view to be rendered.
But since ActionController::RoutingError exceptions also indicate
a bug in OBS we also notify errbit, our exception tracker, about
such errors.
This was causing our exception tracker to be spammed.
Instead we now send ActiveRecord::RecordNotFound exceptions, which
renders a 404 without notifying errbit.
Fixes #7080
Commit: 6e0ad054e036ad4e0cf12d64cce4c095cfa45efd
https://github.com/openSUSE/open-build-service/commit/6e0ad054e036ad4e0cf12d...
Author: Eduardo J
Date: 2019-03-01 (Fri, 01 Mar 2019)
Changed paths:
M src/api/app/controllers/webui/package_controller.rb
M src/api/app/controllers/webui/packages/build_reason_controller.rb
M src/api/app/controllers/webui/packages/job_history_controller.rb
M src/api/app/controllers/webui/projects/project_configuration_controller.rb
M src/api/app/controllers/webui/webui_controller.rb
M src/api/spec/controllers/webui/package_controller_spec.rb
M src/api/spec/controllers/webui/projects/project_configuration_controller_spec.rb
Log Message:
-----------
Merge pull request #7084 from bgeuken/fix_issue_7080
Use correct exception when a record can not be found
Compare: https://github.com/openSUSE/open-build-service/compare/f9d4e6000552...6e0ad0...