[openSUSE/open-build-service] 7840ee: Remove unneeded path parameter for creating an ...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7840ee1a7cbcd7ae16fe214f4f9ae609e76e222c https://github.com/openSUSE/open-build-service/commit/7840ee1a7cbcd7ae16fe21... Author: Eduardo Navarro <enavarro@suse.com> Date: 2021-01-14 (Thu, 14 Jan 2021) Changed paths: M docs/api/api/api.txt M src/api/app/controllers/issue_trackers_controller.rb Log Message: ----------- Remove unneeded path parameter for creating an ... ... issue tracker from apidocs documentation. The `POST` route for issue trackers doesn't require an issue tracker id in path parameters. And the `create` method in the controller doesn't make use of any path parameters. Also replace `bnc` as an example of ids with `<id>`, in the comments, for the description of the route related to the controller method. Commit: 148a8ce9f6e76219643a3318214126235dd8257a https://github.com/openSUSE/open-build-service/commit/148a8ce9f6e76219643a33... Author: Eduardo Navarro <enavarro@suse.com> Date: 2021-01-14 (Thu, 14 Jan 2021) Changed paths: M src/api/app/controllers/issue_trackers_controller.rb M src/api/app/controllers/issues_controller.rb M src/api/config/routes/api_routes.rb Log Message: ----------- Rename 'id' issue tracker parameter to 'name' The 'id' was used for this parameter because it is the default for resources in Rails, but looking at how it is being used, it is clearly a name. Commit: 0b7639fcc1106238238e1faba464b2f21344bbca https://github.com/openSUSE/open-build-service/commit/0b7639fcc1106238238e1f... Author: Eduardo Navarro <enavarro@suse.com> Date: 2021-01-14 (Thu, 14 Jan 2021) Changed paths: M src/api/app/controllers/issues_controller.rb Log Message: ----------- Remove 'before_action' filter for not defined actions A filter that is defined only for :create, :update, and :destroy can be removed, if none of those actions are defined. Commit: ed3bac8e464fb54a00fdc9f8ab1ca3ca3397c18d https://github.com/openSUSE/open-build-service/commit/ed3bac8e464fb54a00fdc9... Author: Eduardo J <enavarro@suse.com> Date: 2021-01-18 (Mon, 18 Jan 2021) Changed paths: M docs/api/api/api.txt M src/api/app/controllers/issue_trackers_controller.rb M src/api/app/controllers/issues_controller.rb M src/api/config/routes/api_routes.rb Log Message: ----------- Merge pull request #10628 from eduardoj/fix_issue_trackers_apidocs Remove not needed path parameter for creating an issue tracker from apidocs documentation Compare: https://github.com/openSUSE/open-build-service/compare/b79e782bd143...ed3bac...
participants (1)
-
Eduardo J.