Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 30a61951b0bd7a859356033d76cef77cd92a1659 https://github.com/openSUSE/open-build-service/commit/30a61951b0bd7a85935603... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-03-29 (Thu, 29 Mar 2018) Changed paths: M src/api/app/models/bs_request_action/differ/for_source.rb Log Message: ----------- [frontend] Store file size limit in constant Commit: dd0e466832d43b96286bc03351484716fe95ccc4 https://github.com/openSUSE/open-build-service/commit/dd0e466832d43b96286bc0... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-03-29 (Thu, 29 Mar 2018) Changed paths: M src/api/spec/controllers/webui/request_controller_spec.rb Log Message: ----------- [frontend] Move diff related test into context block Commit: 2042b46010bc85ef39d010df84bf9d500d652c17 https://github.com/openSUSE/open-build-service/commit/2042b46010bc85ef39d010... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-03-29 (Thu, 29 Mar 2018) Changed paths: M src/api/app/models/bs_request_action/differ.rb Log Message: ----------- [frontend] Fix NoMethodError caused by missing module Found when running some tests without using our VCR cassettes: NoMethodError: undefined method `new' for BsRequestAction::Differ::ForSource:Module Shared Example Group: "a full diff not requested for" called from ./spec/controllers/webui/request_controller_spec.rb:128 # ./app/models/bs_request_action/differ.rb:8:in `sourcediff' # ./app/models/bs_request_action.rb:306:in `webui_infos' # ./app/models/bs_request.rb:1064:in `block in webui_actions' Commit: f59ecf7e5fdf62730e49cefe1548fc8c8a4997ad https://github.com/openSUSE/open-build-service/commit/f59ecf7e5fdf62730e49ce... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-04-03 (Tue, 03 Apr 2018) Changed paths: R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_3_5_3_2_1.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_3_5_3_2_2.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_superseded/1_3_5_3_1_1.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_3_7_2_1.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_3_7_2_2.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/with_diff_to_superseded_set/and_the_superseded_request_is_superseded/1_3_7_1_1.yml M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/support/files/bigfile_archive.tar.gz M src/api/spec/support/files/bigfile_archive_2.tar.gz Log Message: ----------- [frontend] Reduce size of test data in request diff test The default file limit for diffs is 10.000. Since we only want to test whether the diff truncation works or not, we can stub the diff size limit with a much lower value (5). This way we can reduce our test data and cassettes quite a bit. Commit: cfd1284da2de3f09cfafe265de8a82f2635d336a https://github.com/openSUSE/open-build-service/commit/cfd1284da2de3f09cfafe2... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-04-04 (Wed, 04 Apr 2018) Changed paths: M src/api/app/models/bs_request_action/differ.rb M src/api/app/models/bs_request_action/differ/for_source.rb R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_3_5_3_2_1.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_3_5_3_2_2.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_superseded/1_3_5_3_1_1.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_3_7_2_1.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_3_7_2_2.yml R src/api/spec/cassettes/Webui_RequestController/GET_show/with_diff_to_superseded_set/and_the_superseded_request_is_superseded/1_3_7_1_1.yml M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/support/files/bigfile_archive.tar.gz M src/api/spec/support/files/bigfile_archive_2.tar.gz Log Message: ----------- Merge pull request #4782 from bgeuken/reduce_cassette_size Reduce cassette size Compare: https://github.com/openSUSE/open-build-service/compare/b8b73bfbdc7f...cfd128...