[obs-commits] [openSUSE/open-build-service] 842260: Add preview for the comment markdown
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8422604be1981de434be5c166ae4b0828e77ca14 https://github.com/openSUSE/open-build-service/commit/8422604be1981de434be5c... Author: Oleksandr Orlov <oorlov@suse.com> Date: 2020-11-13 (Fri, 13 Nov 2020) Changed paths: M src/api/app/assets/javascripts/webui/comment.js M src/api/app/assets/stylesheets/webui/comments.scss M src/api/app/controllers/webui/comments_controller.rb M src/api/app/views/webui/comment/_comment_field.html.haml M src/api/app/views/webui/comment/_new.html.haml M src/api/app/views/webui/comment/_reply.html.haml M src/api/config/routes/webui_routes.rb M src/api/spec/controllers/webui/comments_controller_spec.rb M src/api/spec/features/beta/webui/comments_spec.rb M src/api/spec/features/webui/comments_spec.rb Log Message: ----------- Add preview for the comment markdown It is easy for a MD formatted text to come out looking wrong due to a typo. The commit adds Preview tab for comment section, so that it is possible to view the formatted with markdown comment before saving it. Fixes #10019 Commit: 4ac082fe0a97227b202a1445a3af2bbc0c869ee4 https://github.com/openSUSE/open-build-service/commit/4ac082fe0a97227b202a14... Author: Oleksandr Orlov <oorlov@suse.com> Date: 2020-11-13 (Fri, 13 Nov 2020) Changed paths: M src/api/app/assets/javascripts/webui/comment.js Log Message: ----------- Disable comment submit button if the body is empty On an empty comment being in the "Write" tab and then clicking "Update" or "Add" resulted in "Please fill out this field" warning. But there were no warning when the comment was empty and "Preview" tab was selected. The commit addresses the issue by disabling submit button until text area is filled in. Commit: 6a5c20afe7b6de092a3d75c8b73c8a043d547cf7 https://github.com/openSUSE/open-build-service/commit/6a5c20afe7b6de092a3d75... Author: Victor Pereira <vpereira@suse.de> Date: 2020-11-15 (Sun, 15 Nov 2020) Changed paths: M src/api/app/assets/javascripts/webui/comment.js M src/api/app/assets/stylesheets/webui/comments.scss M src/api/app/controllers/webui/comments_controller.rb M src/api/app/views/webui/comment/_comment_field.html.haml M src/api/app/views/webui/comment/_new.html.haml M src/api/app/views/webui/comment/_reply.html.haml M src/api/config/routes/webui_routes.rb M src/api/spec/controllers/webui/comments_controller_spec.rb M src/api/spec/features/beta/webui/comments_spec.rb M src/api/spec/features/webui/comments_spec.rb Log Message: ----------- Merge pull request #10433 from OleksandrOrlov/10019_preview_comments_markdown Add preview for the comment markdown Compare: https://github.com/openSUSE/open-build-service/compare/92db4fe67263...6a5c20...
participants (1)
-
Victor Pereira