Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: f4c3309a9e2a95aa3cfb0e800d691d7a40473628
https://github.com/openSUSE/open-build-service/commit/f4c3309a9e2a95aa3cfb0e...
Author: Henne Vogelsang
Date: 2023-10-23 (Mon, 23 Oct 2023)
Changed paths:
M src/api/.database_consistency.todo.yml
M src/api/app/controllers/source_controller.rb
M src/api/app/models/linked_project.rb
M src/api/app/models/project/update_from_xml_command.rb
M src/api/app/services/meta_controller_service/meta_validator.rb
A src/api/spec/models/linked_project_spec.rb
Log Message:
-----------
Collect all linked project validations
There are a couple of places throughout the app that validate LinkedProject.
- LinkedProject (duh!)
- Project.validate_link_xml_attribute
- Project.find_package
This just gathers all of them into LinkedProject so the validations in Project
can be dropped some day...
Commit: 1d76f816ac1a57028f26365256d5ba0391316531
https://github.com/openSUSE/open-build-service/commit/1d76f816ac1a57028f2636...
Author: Henne Vogelsang
Date: 2023-10-23 (Mon, 23 Oct 2023)
Changed paths:
R src/api/test/unit/linked_project_test.rb
M src/api/test/unit/project_test.rb
Log Message:
-----------
Adopt LinkedProject minitest tests to new validations
We started to validate LinkedProject link cycles on the model level. So
the cycle protection test for expand_all_projects / expand_all_packages need
to work around them.
We also started to test validations in rspec, so drop the general minitest
validation test.
Commit: 7f5e8735efc9d9ca822d7ad5adc4ef7a60322493
https://github.com/openSUSE/open-build-service/commit/7f5e8735efc9d9ca822d7a...
Author: Henne Vogelsang
Date: 2023-10-26 (Thu, 26 Oct 2023)
Changed paths:
M src/api/.database_consistency.todo.yml
M src/api/app/controllers/source_controller.rb
M src/api/app/models/linked_project.rb
M src/api/app/models/project/update_from_xml_command.rb
M src/api/app/services/meta_controller_service/meta_validator.rb
A src/api/spec/models/linked_project_spec.rb
R src/api/test/unit/linked_project_test.rb
M src/api/test/unit/project_test.rb
Log Message:
-----------
Merge pull request #15061 from hennevogel/refactoring/linked_project-validations
Collect all linked project validations
Compare: https://github.com/openSUSE/open-build-service/compare/cfe9121d0dbe...7f5e87...