[obs-commits] [openSUSE/open-build-service] 9c66a9: [ci] Fix RSpec/FilePath offense
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9c66a9f7d084cb4e4b273a1b3b299b14759a0b3c https://github.com/openSUSE/open-build-service/commit/9c66a9f7d084cb4e4b273a... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-07-02 (Mon, 02 Jul 2018) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml A src/api/spec/controllers/webui/attribute_controller_spec.rb R src/api/spec/controllers/webui/attributes_controller_spec.rb R src/api/spec/controllers/webui/cloud/ec2/upload_job/logs_controller_spec.rb A src/api/spec/controllers/webui/cloud/upload_job/logs_controller_spec.rb R src/api/spec/controllers/webui/users/rss_token_controller_spec.rb A src/api/spec/controllers/webui/users/rss_tokens_controller_spec.rb R src/api/spec/decorators/statistics/maintenance_statistic_decorator.rb A src/api/spec/decorators/statistics/maintenance_statistic_decorator_spec.rb R src/api/spec/helpers/webui/build_result_helper.rb A src/api/spec/helpers/webui/buildresult_helper_spec.rb R src/api/spec/jobs/bs_request_action_webui_infos_job.rb A src/api/spec/jobs/bs_request_action_webui_infos_job_spec.rb A src/api/spec/jobs/create_project_log_entry_job_spec.rb R src/api/spec/jobs/project_log_rotate_job_spec.rb A src/api/spec/models/event/comment_for_project_spec.rb R src/api/spec/models/event/comment_spec.rb R src/api/spec/models/image_template_spec.rb A src/api/spec/models/project/image_template_spec.rb A src/api/spec/script/db/checker_spec.rb R src/api/spec/script/db_checker.rb Log Message: ----------- [ci] Fix RSpec/FilePath offense Fixes two types of RSpec/FilePath offenses: * The RSpec file name should match the one from the tested class. * RSpec test files have to end with '_spec.rb'. Otherwise rspec does not ignores them. Adding the _spec.rb suffix caused that these files were also recognized by the RuboCop RSpec cops and RSpec itself. That's why this commit includes additional RuboCop offense and RSpec test fixes. Commit: 0449be5ecf1c485fd172c9c35e420fc4219b2578 https://github.com/openSUSE/open-build-service/commit/0449be5ecf1c485fd172c9... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-07-02 (Mon, 02 Jul 2018) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml A src/api/spec/controllers/webui/attribute_controller_spec.rb R src/api/spec/controllers/webui/attributes_controller_spec.rb R src/api/spec/controllers/webui/cloud/ec2/upload_job/logs_controller_spec.rb A src/api/spec/controllers/webui/cloud/upload_job/logs_controller_spec.rb R src/api/spec/controllers/webui/users/rss_token_controller_spec.rb A src/api/spec/controllers/webui/users/rss_tokens_controller_spec.rb R src/api/spec/decorators/statistics/maintenance_statistic_decorator.rb A src/api/spec/decorators/statistics/maintenance_statistic_decorator_spec.rb R src/api/spec/helpers/webui/build_result_helper.rb A src/api/spec/helpers/webui/buildresult_helper_spec.rb R src/api/spec/jobs/bs_request_action_webui_infos_job.rb A src/api/spec/jobs/bs_request_action_webui_infos_job_spec.rb A src/api/spec/jobs/create_project_log_entry_job_spec.rb R src/api/spec/jobs/project_log_rotate_job_spec.rb A src/api/spec/models/event/comment_for_project_spec.rb R src/api/spec/models/event/comment_spec.rb R src/api/spec/models/image_template_spec.rb A src/api/spec/models/project/image_template_spec.rb A src/api/spec/script/db/checker_spec.rb R src/api/spec/script/db_checker.rb Log Message: ----------- Merge pull request #5267 from bgeuken/bugfix/fix_rspec_tests_that_did_not_run [ci] Fix RSpec/FilePath offense Compare: https://github.com/openSUSE/open-build-service/compare/5ecf31e8239d...0449be... **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Björn Geuken