[obs-commits] [openSUSE/open-build-service] 7fb7a1: [frontend] Fix undefined method error in user help...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7fb7a12e69f089fb00b951e8ebf7199753cc9f4e https://github.com/openSUSE/open-build-service/commit/7fb7a12e69f089fb00b951... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-07-19 (Thu, 19 Jul 2018) Changed paths: M src/api/app/helpers/webui/user_helper.rb M src/api/spec/helpers/webui/user_helper_spec.rb Log Message: ----------- [frontend] Fix undefined method error in user helper This method got recently moved and refactored (15e02640b95cf), which caused a bug in the _printed_name method. "undefined method `<<' for #<User:0x00007f9f368b6dc0>" We have to duplicate the user login (`user.login.dup`), because otherwise we would assign the object reference of user.login. Which means that any later changes of `printed_name` would alter the login of the user object, e.g. (when we call String#<< later in this method). Commit: 491390491c28fdd1d8792516af7166140f116c0b https://github.com/openSUSE/open-build-service/commit/491390491c28fdd1d87925... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-07-19 (Thu, 19 Jul 2018) Changed paths: M src/api/app/helpers/webui/user_helper.rb M src/api/spec/helpers/webui/user_helper_spec.rb Log Message: ----------- Merge pull request #5405 from bgeuken/bugfix/fix_user_helper Bugfix/fix user helper Compare: https://github.com/openSUSE/open-build-service/compare/c7e6d6fa5051...491390... **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Björn Geuken