Branch: refs/heads/depfu/update/srcapi/shoulda-matchers-4.0.0 Home: https://github.com/openSUSE/open-build-service Commit: ab69df6d37546bafb5e45b4722dc3781190d0b88 https://github.com/openSUSE/open-build-service/commit/ab69df6d37546bafb5e45b... Author: depfu[bot] Date: 2019-02-20 (Wed, 20 Feb 2019) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock M src/api/app/models/cloud/ec2/configuration.rb M src/api/spec/models/cloud/upload_job_spec.rb M src/api/spec/models/download_repository_spec.rb M src/api/spec/models/kiwi/repository_spec.rb M src/api/spec/models/status/check_spec.rb Log Message: ----------- Update shoulda-matchers to version 4.0.0 We use custom validation error messages for some of our models. With the new gem release the error message shoulda matchers would expect stopped matching our custom messages and the tests failed. To solve this we explicitly set the validation message where needed. The "optional: false" parameter for the belongs_to association was superfluous since Rails uses "required" by default and caused some a shoulda matcher to fail. Co-authored-by: Björn Geuken