[obs-commits] [openSUSE/software-o-o] 2263a5: Remove unused instance variables
Branch: refs/heads/master Home: https://github.com/openSUSE/software-o-o Commit: 2263a524eaf1181f1141964a91c25b61be02de84 https://github.com/openSUSE/software-o-o/commit/2263a524eaf1181f1141964a91c2... Author: Alexander Graul <agraul@suse.com> Date: 2018-12-04 (Tue, 04 Dec 2018) Changed paths: M app/controllers/package_controller.rb Log Message: ----------- Remove unused instance variables These variables are not used anywhere and just take up space in memory and in the controller. Commit: 9db22c8343aff4b1918fc71729150abd8cfc8fad https://github.com/openSUSE/software-o-o/commit/9db22c8343aff4b1918fc7172915... Author: Alexander Graul <agraul@suse.com> Date: 2018-12-04 (Tue, 04 Dec 2018) Changed paths: M app/controllers/package_controller.rb Log Message: ----------- Simplify @default_package conditional assignment One @packages.select iteration can be skipped which increases performance. Using || instead of an if-else block improves readability. Commit: 7605f07ebd184c38a30f95c42de7fb2efd4a2fba https://github.com/openSUSE/software-o-o/commit/7605f07ebd184c38a30f95c42de7... Author: Alexander Graul <agraul@suse.com> Date: 2018-12-04 (Tue, 04 Dec 2018) Changed paths: M app/controllers/package_controller.rb Log Message: ----------- Improve pkg_appdata readability Moving .first to the pkg_appdata assignment makes checking if a first element exists easier, a simple if pkg_appdata can be used. Assignments for @name, @appcategories and @homepage are also slightly nicer to read. Commit: b1fa0e718e2a99ce6ab4b9c4815431c309abc428 https://github.com/openSUSE/software-o-o/commit/b1fa0e718e2a99ce6ab4b9c48154... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2018-12-04 (Tue, 04 Dec 2018) Changed paths: M app/controllers/package_controller.rb Log Message: ----------- Merge pull request #443 from alexandergraul/package-controller-cleanup Package controller cleanup Compare: https://github.com/openSUSE/software-o-o/compare/b36554c92d04...b1fa0e718e2a **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Ana María Martínez Gómez