Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9d5b9349053f7d4bfb6eae1bf02d2e7eeae07093 https://github.com/openSUSE/open-build-service/commit/9d5b9349053f7d4bfb6eae... Author: Rubhan Azeem <rubhanazeem@gmail.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M src/api/app/assets/javascripts/webui/packages.js Log Message: ----------- Use body as root to find the collapse/uncollapse buttons It was needed because partials are rendered dynamically by AJAX and getting elements with class is not enough to find the element in DOM. Commit: 64fdf3ce0e8133f459be207eecdae866738414f2 https://github.com/openSUSE/open-build-service/commit/64fdf3ce0e8133f459be20... Author: Rubhan Azeem <rubhanazeem@gmail.com> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/app/assets/javascripts/webui/request.js M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request.rb M src/api/app/views/webui/request/_sourcediff_tab.html.haml A src/api/app/views/webui/request/request_action.js.erb M src/api/app/views/webui/request/show.html.haml M src/api/config/routes/webui_routes.rb M src/api/test/unit/bs_request_test.rb Log Message: ----------- Improve performance of Request#show with multiple actions Request#show was loading the complete diff history in a single HTTP request which was time consuming and even crashing the browser due to large html content. Now the content can be loaded based on separate actions. And we don't make ajax calls for already loaded diffs. Co-authored-by: Saray Cabrera Padrón <scabrerapadron@suse.de> Commit: c836233a9d1cad91135be1bcf9e6eb1b8d6690fc https://github.com/openSUSE/open-build-service/commit/c836233a9d1cad91135be1... Author: Rubhan Azeem <rubhanazeem@gmail.com> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/not_setting_a_target_package/creates_a_BsRequest_with_the_source_package_name.yml M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/prefill_form_for_a_branched_package/fills_in_the_submission_reasons_and_creates_a_BsRequest.yml M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/setting_a_target_package/creates_a_BsRequest_with_target_package_name.yml M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/supersede_a_request/creates_a_BsRequest_and_supersede_only_the_selected_request_s_.yml M src/api/spec/cassettes/Comments/answering_comments.yml M src/api/spec/cassettes/MaintenanceWorkflow/maintenance_workflow.yml M src/api/spec/cassettes/Packages/adding_a_valid_file.yml M src/api/spec/cassettes/Packages/adding_an_invalid_file.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_an_existing_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_non_existent_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_role_to_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Remove_role_from_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Viewing_group_roles.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_an_existing_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_non_existent_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_role_to_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Remove_role_from_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Remove_user_from_package_/_project.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Viewing_user_roles.yml M src/api/spec/cassettes/Packages/branching_a_package_from_another_users_project/with_AutoCleanup.yml M src/api/spec/cassettes/Packages/branching_a_package_from_another_users_project/without_AutoCleanup.yml M src/api/spec/cassettes/Packages/editing_package_files/editing_an_existing_file.yml M src/api/spec/cassettes/Patchinfo/create_Patchinfo/form_complete.yml M src/api/spec/cassettes/Projects/locked_projects/fail_to_unlock.yml M src/api/spec/cassettes/Projects/maintenance_incidents/visiting_the_maintenance_overview.yml M src/api/spec/cassettes/Watchlists/add_projects_to_watchlist.yml M src/api/spec/cassettes/Watchlists/remove_projects_from_watchlist.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_4_1_3_2_1.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_4_1_3_2_2.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_superseded/1_4_1_3_1_1.yml M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/test/unit/bs_request_test.rb Log Message: ----------- Adapt tests and update cassettes Extract diffs test from #show to #request_action and update VCR cassettes Commit: d1f2c1e1601ba9e96f29fab186fbe65af2e254d6 https://github.com/openSUSE/open-build-service/commit/d1f2c1e1601ba9e96f29fa... Author: Rubhan Azeem <rubhanazeem@gmail.com> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/app/assets/javascripts/webui/packages.js M src/api/app/assets/javascripts/webui/request.js M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request.rb M src/api/app/views/webui/request/_sourcediff_tab.html.haml A src/api/app/views/webui/request/request_action.js.erb M src/api/app/views/webui/request/show.html.haml M src/api/config/routes/webui_routes.rb M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/not_setting_a_target_package/creates_a_BsRequest_with_the_source_package_name.yml M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/prefill_form_for_a_branched_package/fills_in_the_submission_reasons_and_creates_a_BsRequest.yml M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/setting_a_target_package/creates_a_BsRequest_with_target_package_name.yml M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/supersede_a_request/creates_a_BsRequest_and_supersede_only_the_selected_request_s_.yml M src/api/spec/cassettes/Comments/answering_comments.yml M src/api/spec/cassettes/MaintenanceWorkflow/maintenance_workflow.yml M src/api/spec/cassettes/Packages/adding_a_valid_file.yml M src/api/spec/cassettes/Packages/adding_an_invalid_file.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_an_existing_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_non_existent_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_role_to_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Remove_role_from_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Viewing_group_roles.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_an_existing_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_non_existent_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_role_to_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Remove_role_from_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Remove_user_from_package_/_project.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Viewing_user_roles.yml M src/api/spec/cassettes/Packages/branching_a_package_from_another_users_project/with_AutoCleanup.yml M src/api/spec/cassettes/Packages/branching_a_package_from_another_users_project/without_AutoCleanup.yml M src/api/spec/cassettes/Packages/editing_package_files/editing_an_existing_file.yml M src/api/spec/cassettes/Patchinfo/create_Patchinfo/form_complete.yml M src/api/spec/cassettes/Projects/locked_projects/fail_to_unlock.yml M src/api/spec/cassettes/Projects/maintenance_incidents/visiting_the_maintenance_overview.yml M src/api/spec/cassettes/Watchlists/add_projects_to_watchlist.yml M src/api/spec/cassettes/Watchlists/remove_projects_from_watchlist.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_4_1_3_2_1.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_4_1_3_2_2.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_superseded/1_4_1_3_1_1.yml M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/test/unit/bs_request_test.rb Log Message: ----------- Merge pull request #11260 from rubhanazeem/improve-req-show Improve performance of Request#show with multiple actions Compare: https://github.com/openSUSE/open-build-service/compare/36b8d065961a...d1f2c1...