Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 69e6a69b95bd40f316fff0fb016bd2f6cfc9603b https://github.com/openSUSE/open-build-service/commit/69e6a69b95bd40f316fff0... Author: Dany Marcoux <dmarcoux@posteo.de> Date: 2022-07-21 (Thu, 21 Jul 2022) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/requests/submissions_controller.rb M src/api/app/models/bs_request.rb M src/api/spec/features/webui/requests_spec.rb M src/api/test/functional/request_controller_test.rb Log Message: ----------- Do not overwrite dynamic finder find_by_number! for BsRequest It's confusing any developer who's used to the built-in dynamic finders for ActiveRecord models. If we want a custom exception message for BsRequest#number, we can still do it without overwriting `find_by_number!`. Commit: 57f598bae81290d00cc479a38c182b3aa354b8de https://github.com/openSUSE/open-build-service/commit/57f598bae81290d00cc479... Author: Dany Marcoux <dmarcoux@posteo.de> Date: 2022-07-25 (Mon, 25 Jul 2022) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/requests/submissions_controller.rb M src/api/app/models/bs_request.rb M src/api/spec/features/webui/requests_spec.rb M src/api/test/functional/request_controller_test.rb Log Message: ----------- Merge pull request #12844 from dmarcoux/remove-class-method-BsRequest-find_by_number Do not overwrite dynamic finder find_by_number! for BsRequest Compare: https://github.com/openSUSE/open-build-service/compare/17dba917af57...57f598...