Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 9ce1e217e9aeb32cd1611ec2343837fb28cef53c
https://github.com/openSUSE/open-build-service/commit/9ce1e217e9aeb32cd1611e...
Author: Lukas Krause
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M src/api/app/controllers/webui/request_controller.rb
Log Message:
-----------
Handle `notification_id` query param gracefully for request show
There is no need to block users from viewing a request when
someone is sharing a link from his notifications with the
`notification_id` attached as a query param. The `notification_id`
query param is used to render the notification toolbar for an
authorized users. If someone without authorization is using the
same link, we should simply not render the toolbar, but still show
the request show view.
Commit: 86c6e5e1766db29b522d90383b215de5efc056bc
https://github.com/openSUSE/open-build-service/commit/86c6e5e1766db29b522d90...
Author: Lukas Krause
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M src/api/app/controllers/webui/reports_controller.rb
Log Message:
-----------
Handle `notification_id` query param gracefully for report show
There is no need to block users from viewing a report when
someone is sharing a link from his notifications with the
`notification_id` attached as a query param. The `notification_id`
query param is used to render the notification toolbar for an
authorized users. If someone without authorization is using the
same link, we should simply not render the toolbar, but still show
the report show view.
Commit: 04c507c23347434e0c2dcb66ea16bb958afc9ae1
https://github.com/openSUSE/open-build-service/commit/04c507c23347434e0c2dcb...
Author: Lukas Krause
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M src/api/app/controllers/webui/users_controller.rb
Log Message:
-----------
Handle `notification_id` query param gracefully for user show
There is no need to block users from viewing a user when
someone is sharing a link from his notifications with the
`notification_id` attached as a query param. The `notification_id`
query param is used to render the notification toolbar for an
authorized users. If someone without authorization is using the
same link, we should simply not render the toolbar, but still show
the user show view.
Commit: 8612fd95f6e8149e23aa50a7fc4169fff805f9c4
https://github.com/openSUSE/open-build-service/commit/8612fd95f6e8149e23aa50...
Author: Lukas Krause
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M src/api/app/controllers/webui/package_controller.rb
Log Message:
-----------
Handle `notification_id` query param gracefully for package show
There is no need to block users from viewing a package when
someone is sharing a link from his notifications with the
`notification_id` attached as a query param. The `notification_id`
query param is used to render the notification toolbar for an
authorized users. If someone without authorization is using the
same link, we should simply not render the toolbar, but still show
the package show view.
Commit: d1906599edf5c5f84550cb97f2c0413e83760f05
https://github.com/openSUSE/open-build-service/commit/d1906599edf5c5f84550cb...
Author: Lukas Krause
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M src/api/app/controllers/webui/project_controller.rb
Log Message:
-----------
Handle `notification_id` query param gracefully for project show
There is no need to block users from viewing a project when
someone is sharing a link from his notifications with the
`notification_id` attached as a query param. The `notification_id`
query param is used to render the notification toolbar for an
authorized users. If someone without authorization is using the
same link, we should simply not render the toolbar, but still show
the project show view.
Commit: c11087ed9df5c1370f511a2a77810d8cda3c135e
https://github.com/openSUSE/open-build-service/commit/c11087ed9df5c1370f511a...
Author: Lukas Krause
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M src/api/app/controllers/webui/package_controller.rb
M src/api/app/controllers/webui/project_controller.rb
M src/api/app/controllers/webui/reports_controller.rb
M src/api/app/controllers/webui/request_controller.rb
M src/api/app/controllers/webui/users_controller.rb
Log Message:
-----------
Merge pull request #16111 from krauselukas/notifications/gracefully_handle_notification_toolbar
Handle `notification_id` query param and notifications toolbar gracefully
Compare: https://github.com/openSUSE/open-build-service/compare/357ccdd7ad46...c11087...
To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications
