[openSUSE/open-build-service] 9a4396: Drop superfluous UpdateReleasedBinariesJob spec

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9a439612c51b60468be28e649614171570f8aab9 https://github.com/openSUSE/open-build-service/commit/9a439612c51b60468be28e... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: R src/api/spec/cassettes/UpdateReleasedBinariesJob/_perform/for_an_event_with_a_repo/1_1_1_1.yml R src/api/spec/cassettes/UpdateReleasedBinariesJob/_perform/for_an_event_without_a_repo/1_1_2_1.yml R src/api/spec/cassettes/UpdateReleasedBinariesJob/_perform/when_perform_raises_an_exception/notifies_airbrake.yml R src/api/spec/jobs/update_released_binaries_job_spec.rb Log Message: ----------- Drop superfluous UpdateReleasedBinariesJob spec This isn't testing anything. Only an `unless` in our code and Airbrake. I'm quite sure both can fend for themselves... Commit: 61d1962568bbb3286ea9ab1c02e33e9c4afd0336 https://github.com/openSUSE/open-build-service/commit/61d1962568bbb3286ea9ab... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/app/jobs/update_released_binaries_job.rb Log Message: ----------- Simplify variables `event` is already a variable, no need to abstract the payload to `pl` Commit: dca5b9e189d733fd0f3296b8306136649682c929 https://github.com/openSUSE/open-build-service/commit/dca5b9e189d733fd0f3296... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/app/jobs/update_released_binaries_job.rb M src/api/app/models/binary_release.rb Log Message: ----------- Move BinaryRelease#update_binary_releases to job The job is the only thing that uses this method... Commit: 279436588971e39d6e4c404416e96ab31c2bb5b3 https://github.com/openSUSE/open-build-service/commit/279436588971e39d6e4c40... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/app/jobs/update_released_binaries_job.rb M src/api/app/models/binary_release.rb Log Message: ----------- Move BinaryRelease#update_binary_releases_via_json to job The job is the only thing that uses this method and it's support methods. Commit: 52b2bf447eff5c6c1783e69f1899cb437ad7dee4 https://github.com/openSUSE/open-build-service/commit/52b2bf447eff5c6c1783e6... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: A src/api/spec/jobs/update_released_binaries_job_spec.rb R src/api/spec/models/binary_release_spec.rb Log Message: ----------- Rename BinaryReleaseSpec It's not testing BinaryRelease, it's testing UpdateReleasedBinariesJob Commit: 65d460fccbd085f98bb95f4ffac48fa70602efee https://github.com/openSUSE/open-build-service/commit/65d460fccbd085f98bb95f... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/spec/jobs/update_released_binaries_job_spec.rb M src/api/test/unit/binary_release_test.rb Log Message: ----------- Adapt spec to new UpdateReleasedBinariesJob Commit: 1872ace5418ae660e6f2ca17261e5246874d40e4 https://github.com/openSUSE/open-build-service/commit/1872ace5418ae660e6f2ca... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml M src/api/config/brakeman.ignore Log Message: ----------- Adapt linter config to new UpdateReleasedBinariesJob Loads of stuff moved here from BinaryRelease Commit: bb90a03632b39910a007f34fa2afae8218183715 https://github.com/openSUSE/open-build-service/commit/bb90a03632b39910a007f3... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/app/jobs/update_released_binaries_job.rb M src/api/spec/jobs/update_released_binaries_job_spec.rb Log Message: ----------- Merge update_binary_releases into perform Just one layer of indirection less... Commit: fbd70dc1b06c99c7758ed2f6a5336c1ad0ec3cd0 https://github.com/openSUSE/open-build-service/commit/fbd70dc1b06c99c7758ed2... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/app/jobs/update_released_binaries_job.rb Log Message: ----------- Add some speaking variables Commit: be9c8febdb21c5a269dc6ee07a039b3adc7095a4 https://github.com/openSUSE/open-build-service/commit/be9c8febdb21c5a269dc6e... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/app/jobs/update_released_binaries_job.rb M src/api/spec/jobs/update_released_binaries_job_spec.rb M src/api/test/unit/binary_release_test.rb Log Message: ----------- Add speaking method names Commit: 3dcaea90e8617272a2f21e54fd929f6eaf68b3d7 https://github.com/openSUSE/open-build-service/commit/3dcaea90e8617272a2f21e... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/app/jobs/update_released_binaries_job.rb Log Message: ----------- Rename to speaking variable name `binary` is actually a hash we've go from the backend. Commit: 5acdc52fa354f30f8153b916ab4db9b9d96af23c https://github.com/openSUSE/open-build-service/commit/5acdc52fa354f30f8153b9... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/app/jobs/update_released_binaries_job.rb Log Message: ----------- Rename to speaking variable name `hash` is actually a hash representation of a BinaryRelease. Commit: 7a3023391f33fefe534f7fc312d2d2d1eafbfbee https://github.com/openSUSE/open-build-service/commit/7a3023391f33fefe534f7f... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/app/jobs/update_released_binaries_job.rb Log Message: ----------- Rename to speaking variable name In the upper part of the loop `entry` is a BinaryRelease that previously existed. In the lower part of the loop `entry` is a BinaryRelease we have just created. Commit: ec539c85dd1fc1290b383d95f8bcd3dcd5c60c55 https://github.com/openSUSE/open-build-service/commit/ec539c85dd1fc1290b383d... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/app/jobs/update_released_binaries_job.rb Log Message: ----------- Add code documentation for this job Commit: 7e1fae801a7d584293e06c5c03b534c072e2cfff https://github.com/openSUSE/open-build-service/commit/7e1fae801a7d584293e06c... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/app/models/binary_release.rb Log Message: ----------- Add attribute aliases to sync with backend The backend uses different attribute names than we do to represent a BinaryInfo. This leads to a lot of code that translates one representation into the other in UpdateReleasedBinariesJob. We can stop doing that if we have attribute aliases... Commit: d725c4f96c10d8a6c18c209cc4e3547ed47f8177 https://github.com/openSUSE/open-build-service/commit/d725c4f96c10d8a6c18c20... Author: Henne Vogelsang Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml M src/api/app/jobs/update_released_binaries_job.rb M src/api/app/models/binary_release.rb M src/api/config/brakeman.ignore R src/api/spec/cassettes/UpdateReleasedBinariesJob/_perform/for_an_event_with_a_repo/1_1_1_1.yml R src/api/spec/cassettes/UpdateReleasedBinariesJob/_perform/for_an_event_without_a_repo/1_1_2_1.yml R src/api/spec/cassettes/UpdateReleasedBinariesJob/_perform/when_perform_raises_an_exception/notifies_airbrake.yml M src/api/spec/jobs/update_released_binaries_job_spec.rb R src/api/spec/models/binary_release_spec.rb M src/api/test/unit/binary_release_test.rb Log Message: ----------- Merge pull request #16358 from hennevogel/refactoring/UpdateReleasedBinariesJob Refactor UpdateReleasedBinariesJob Compare: https://github.com/openSUSE/open-build-service/compare/4f22e34bd22d...d725c4... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications