Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: e30abe9eceda834c552d91e9e3d24ad36f108408
https://github.com/openSUSE/open-build-service/commit/e30abe9eceda834c552d91...
Author: Dany Marcoux
Date: 2023-12-04 (Mon, 04 Dec 2023)
Changed paths:
M src/api/app/assets/javascripts/webui/report.js
M src/api/app/components/bs_request_comment_component.html.haml
M src/api/app/controllers/webui/reports_controller.rb
M src/api/app/views/webui/comment/_content.html.haml
M src/api/app/views/webui/package/_side_links.html.haml
M src/api/app/views/webui/project/_side_links.html.haml
M src/api/app/views/webui/reports/create.js.erb
A src/api/spec/cassettes/Reports/after_reporting_a_comment_on_a_package/displays_the_You_reported_this_comment_message_instantly.yml
A src/api/spec/cassettes/Reports/after_reporting_a_comment_on_a_project/displays_the_You_reported_this_comment_message_instantly.yml
A src/api/spec/cassettes/Reports/after_reporting_a_package/displays_the_You_reported_this_package_message_instantly.yml
A src/api/spec/cassettes/Reports/after_reporting_a_project/displays_the_You_reported_this_project_message_instantly.yml
A src/api/spec/features/beta/webui/reports_spec.rb
Log Message:
-----------
Instantly display the 'You reported the X' message
A page refresh isn't needed anymore for the message to appear.
For comments, the implementation isn't really robust, but considering
how the comments are rendered, this is what we can do without
refactoring a lot of code. In the best scenario, rendering a comment
would be as simple as rendering a single view component. It would then
be unneccessary to fiddle much with JavaScript, re-rendering the comment
view component would be the solution.
As for projects and packages, it's not possible to re-render the
side_links partials since they depend upon so many objects and we don't
have those in webui/reports_controller.
Commit: d6b771ba94519d898cc0aab5fcc36986c051c8da
https://github.com/openSUSE/open-build-service/commit/d6b771ba94519d898cc0aa...
Author: Lukas Krause
Date: 2023-12-04 (Mon, 04 Dec 2023)
Changed paths:
M src/api/app/assets/javascripts/webui/report.js
M src/api/app/components/bs_request_comment_component.html.haml
M src/api/app/controllers/webui/reports_controller.rb
M src/api/app/views/webui/comment/_content.html.haml
M src/api/app/views/webui/package/_side_links.html.haml
M src/api/app/views/webui/project/_side_links.html.haml
M src/api/app/views/webui/reports/create.js.erb
A src/api/spec/cassettes/Reports/after_reporting_a_comment_on_a_package/displays_the_You_reported_this_comment_message_instantly.yml
A src/api/spec/cassettes/Reports/after_reporting_a_comment_on_a_project/displays_the_You_reported_this_comment_message_instantly.yml
A src/api/spec/cassettes/Reports/after_reporting_a_package/displays_the_You_reported_this_package_message_instantly.yml
A src/api/spec/cassettes/Reports/after_reporting_a_project/displays_the_You_reported_this_project_message_instantly.yml
A src/api/spec/features/beta/webui/reports_spec.rb
Log Message:
-----------
Merge pull request #15299 from dmarcoux/report-ux
Instantly display the 'You reported the X' message
Compare: https://github.com/openSUSE/open-build-service/compare/cdbaec8467a7...d6b771...
