Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 84ba48dc577e474d53f3fab5be05f4e722f03631
https://github.com/openSUSE/open-build-service/commit/84ba48dc577e474d53f3fa...
Author: Dani Donisa
Date: 2023-08-21 (Mon, 21 Aug 2023)
Changed paths:
M src/api/app/components/watchlist_component.rb
M src/api/app/views/layouts/webui/webui.html.haml
M src/api/app/views/webui/package/show.html.haml
M src/api/app/views/webui/project/show.html.haml
M src/api/app/views/webui/request/_request_header.html.haml
M src/api/app/views/webui/request/_show_overview.html.haml
M src/api/app/views/webui/watched_items/toggle_watched_item.js.erb
M src/api/spec/components/previews/watchlist_icon_component_preview.rb
M src/api/spec/components/watchlist_component_spec.rb
M src/api/spec/components/watchlist_icon_component_spec.rb
Log Message:
-----------
Extract logic accessing the database from a component
As a best practice, we should not be accessing the database from inside a View Component. The WatchlistComponent now accepts the logic accessing the database as parameters in the constructor.
Commit: 710f21fbbfeb275b5d4a8c61f68733931d4bb1fc
https://github.com/openSUSE/open-build-service/commit/710f21fbbfeb275b5d4a8c...
Author: Dani Donisa
Date: 2023-08-21 (Mon, 21 Aug 2023)
Changed paths:
M src/api/app/controllers/webui/webui_controller.rb
M src/api/app/views/layouts/webui/webui.html.haml
M src/api/app/views/webui/package/show.html.haml
M src/api/app/views/webui/project/show.html.haml
M src/api/app/views/webui/request/_request_header.html.haml
M src/api/app/views/webui/request/_show_overview.html.haml
M src/api/app/views/webui/request/_update.js.erb
M src/api/app/views/webui/request/beta_show.html.haml
M src/api/app/views/webui/request/build_results.html.haml
M src/api/app/views/webui/request/changes.html.haml
M src/api/app/views/webui/request/mentioned_issues.html.haml
M src/api/app/views/webui/request/rpm_lint.html.haml
M src/api/app/views/webui/request/show.html.haml
M src/api/app/views/webui/watched_items/toggle_watched_item.js.erb
Log Message:
-----------
Fetch watchlist items in WebuiController
Commit: c55c390aa5eab611c90473b2d7cca015aec45ae1
https://github.com/openSUSE/open-build-service/commit/c55c390aa5eab611c90473...
Author: Dani Donisa
Date: 2023-08-21 (Mon, 21 Aug 2023)
Changed paths:
M src/api/app/controllers/webui/watched_items_controller.rb
M src/api/app/models/user.rb
R src/api/app/queries/packages_for_watchlist_finder.rb
R src/api/app/queries/projects_for_watchlist_finder.rb
R src/api/app/queries/requests_for_watchlist_finder.rb
M src/api/app/views/person/_watchlist.xml.builder
Log Message:
-----------
Use scopes instead of query objects
We can do the same with scopes.
Co-authored-by: Rubhan Azeem
Commit: e8d0a759b83c74f1849b8be0ff41899c21b80d85
https://github.com/openSUSE/open-build-service/commit/e8d0a759b83c74f1849b8b...
Author: Henne Vogelsang
Date: 2023-08-21 (Mon, 21 Aug 2023)
Changed paths:
M src/api/app/components/watchlist_component.rb
M src/api/app/controllers/webui/watched_items_controller.rb
M src/api/app/controllers/webui/webui_controller.rb
M src/api/app/models/user.rb
R src/api/app/queries/packages_for_watchlist_finder.rb
R src/api/app/queries/projects_for_watchlist_finder.rb
R src/api/app/queries/requests_for_watchlist_finder.rb
M src/api/app/views/layouts/webui/webui.html.haml
M src/api/app/views/person/_watchlist.xml.builder
M src/api/app/views/webui/package/show.html.haml
M src/api/app/views/webui/project/show.html.haml
M src/api/app/views/webui/request/_request_header.html.haml
M src/api/app/views/webui/request/_show_overview.html.haml
M src/api/app/views/webui/request/_update.js.erb
M src/api/app/views/webui/request/beta_show.html.haml
M src/api/app/views/webui/request/build_results.html.haml
M src/api/app/views/webui/request/changes.html.haml
M src/api/app/views/webui/request/mentioned_issues.html.haml
M src/api/app/views/webui/request/rpm_lint.html.haml
M src/api/app/views/webui/request/show.html.haml
M src/api/app/views/webui/watched_items/toggle_watched_item.js.erb
M src/api/spec/components/previews/watchlist_icon_component_preview.rb
M src/api/spec/components/watchlist_component_spec.rb
M src/api/spec/components/watchlist_icon_component_spec.rb
Log Message:
-----------
Merge pull request #14791 from danidoni/avoid-database-queries-on-watchlist-component
Extract logic accessing the database from a component
Compare: https://github.com/openSUSE/open-build-service/compare/dbaeab0f0b90...e8d0a7...
