Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: d44022f15e51989a206c333a323f8603fbdaa161
https://github.com/openSUSE/open-build-service/commit/d44022f15e51989a206c33...
Author: ncounter
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M src/api/app/components/notification_filter_component.rb
M src/api/app/controllers/webui/users/notifications_controller.rb
M src/api/app/views/webui/users/notifications/_update.js.erb
M src/api/app/views/webui/users/notifications/index.html.haml
Log Message:
-----------
Move the counting to the controller to pass only paginated set to the view
Commit: 6e7f3883d39aa1ff5753b0f8670b1c5a1cfcbba5
https://github.com/openSUSE/open-build-service/commit/6e7f3883d39aa1ff5753b0...
Author: ncounter
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
R src/api/app/components/notification_filter_component.html.haml
R src/api/app/components/notification_filter_component.rb
A src/api/app/views/webui/users/notifications/_notification_filter.html.haml
M src/api/app/views/webui/users/notifications/_update.js.erb
M src/api/app/views/webui/users/notifications/index.html.haml
Log Message:
-----------
Downgrade a view component to a simpler partial
Commit: d9213581f11b9d7973d4df17397ae63ce8f3cd25
https://github.com/openSUSE/open-build-service/commit/d9213581f11b9d7973d4df...
Author: ncounter
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M src/api/app/controllers/webui/users/notifications_controller.rb
Log Message:
-----------
Reuse already computed value
Commit: dd111b79c50b746ffd87493be10d5497ba794207
https://github.com/openSUSE/open-build-service/commit/dd111b79c50b746ffd8749...
Author: ncounter
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M src/api/app/controllers/webui/users/notifications_controller.rb
M src/api/app/views/webui/users/notifications/_notification_filter.html.haml
M src/api/app/views/webui/users/notifications/_update.js.erb
M src/api/app/views/webui/users/notifications/index.html.haml
Log Message:
-----------
Move additional queries to the controller
Commit: 526e55fc96d9b16f532e5adf9f17232536c572ca
https://github.com/openSUSE/open-build-service/commit/526e55fc96d9b16f532e5a...
Author: Dario Leidi
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M src/api/app/views/webui/users/notifications/_notification_filter.html.haml
M src/api/app/views/webui/users/notifications/_update.js.erb
M src/api/app/views/webui/users/notifications/index.html.haml
Log Message:
-----------
Get rid of the user variable
Co-authored-by: Henne Vogelsang
Commit: dbaafd0d0c9e3fa13d7ba345e4933bd0aff62edf
https://github.com/openSUSE/open-build-service/commit/dbaafd0d0c9e3fa13d7ba3...
Author: ncounter
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
R src/api/spec/components/notification_filter_component_spec.rb
R src/api/spec/components/previews/notification_filter_component_preview.rb
Log Message:
-----------
Drop no longer used specs
Commit: 393da076355b9474955857ce136038bd78b8aad1
https://github.com/openSUSE/open-build-service/commit/393da076355b9474955857...
Author: ncounter
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M src/api/app/controllers/webui/users/notifications_controller.rb
Log Message:
-----------
Count totals before filtering
Commit: 183d1e56e669e02258b06b89b20b78484aed456f
https://github.com/openSUSE/open-build-service/commit/183d1e56e669e02258b06b...
Author: ncounter
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M src/api/app/controllers/webui/users/notifications_controller.rb
Log Message:
-----------
Update read|unread counting after update
Commit: 09c7cd9b2921368e2d4aa56abac1a956a63d8c92
https://github.com/openSUSE/open-build-service/commit/09c7cd9b2921368e2d4aa5...
Author: Dario Leidi
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M src/api/app/controllers/webui/users/notifications_controller.rb
Log Message:
-----------
Better action naming
Co-authored-by: Henne Vogelsang
Commit: 08b440cc291df2ff9bf15cb5fe8b1a63b4c0c9b1
https://github.com/openSUSE/open-build-service/commit/08b440cc291df2ff9bf15c...
Author: Henne Vogelsang
Date: 2024-06-05 (Wed, 05 Jun 2024)
Changed paths:
M src/api/.rubocop_todo.yml
M src/api/app/controllers/webui/users/notifications_controller.rb
Log Message:
-----------
Update notifications counting after updating
Not as before filter. Counting needs to happen after
updating.
Commit: 0dbad287178437dd602dbc42d654f2077111ccd3
https://github.com/openSUSE/open-build-service/commit/0dbad287178437dd602dbc...
Author: Henne Vogelsang
Date: 2024-06-05 (Wed, 05 Jun 2024)
Changed paths:
M src/api/.rubocop_todo.yml
R src/api/app/components/notification_filter_component.html.haml
R src/api/app/components/notification_filter_component.rb
M src/api/app/controllers/webui/users/notifications_controller.rb
A src/api/app/views/webui/users/notifications/_notification_filter.html.haml
M src/api/app/views/webui/users/notifications/_update.js.erb
M src/api/app/views/webui/users/notifications/index.html.haml
R src/api/spec/components/notification_filter_component_spec.rb
R src/api/spec/components/previews/notification_filter_component_preview.rb
Log Message:
-----------
Merge pull request #16257 from ncounter/deduplicate-notification-query
Count on the controller side to pass only paginated set to the view
Compare: https://github.com/openSUSE/open-build-service/compare/950a1cfee02a...0dbad2...
To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications
