Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 989656a2d35d67b8ff3a3018035fcd63d789f1f8
https://github.com/openSUSE/open-build-service/commit/989656a2d35d67b8ff3a30...
Author: Jacob Michalskie
Date: 2023-10-12 (Thu, 12 Oct 2023)
Changed paths:
M src/api/app/controllers/webui/comments_controller.rb
M src/api/app/policies/comment_policy.rb
M src/api/app/views/webui/comment/_new.html.haml
Log Message:
-----------
Don't display the comment field when the comments are locked
Commit: 97eec663590c84a2c74936c5229c8a28699d96f9
https://github.com/openSUSE/open-build-service/commit/97eec663590c84a2c74936...
Author: Jacob Michalskie
Date: 2023-10-12 (Thu, 12 Oct 2023)
Changed paths:
M src/api/app/models/comment_locking_validator.rb
M src/api/app/policies/comment_policy.rb
Log Message:
-----------
Expand the conditions for what qualifies as locked
Maintainers, admins, moderators and staff should always be able to comment, and we want the package locks to be covered by project locks and request action locks to be covered by request locks
Commit: eec0076aa5e45b03e2f02f354cbe2e200021a554
https://github.com/openSUSE/open-build-service/commit/eec0076aa5e45b03e2f02f...
Author: Jacob Michalskie
Date: 2023-10-12 (Thu, 12 Oct 2023)
Changed paths:
M src/api/app/models/comment_locking_validator.rb
M src/api/app/policies/comment_lock_policy.rb
M src/api/app/policies/comment_policy.rb
M src/api/app/views/webui/comment/_new.html.haml
Log Message:
-----------
Allow maintainers, admins, moderators and staff to comment
Also make sure to still display the message about the comments being locked
Commit: e624603bc708c478d4a07238a555ff3961d39fc8
https://github.com/openSUSE/open-build-service/commit/e624603bc708c478d4a072...
Author: Jacob Michalskie
Date: 2023-10-13 (Fri, 13 Oct 2023)
Changed paths:
M src/api/app/models/comment_locking_validator.rb
M src/api/app/policies/comment_policy.rb
Log Message:
-----------
Make sure the user exists before checking if they are a maintainer
There are scenarios in which comments are created without a User.session
present, like creating comments in factories
Commit: 595a869a6d4285963ef2a0ec7f67645e815bb2fe
https://github.com/openSUSE/open-build-service/commit/595a869a6d4285963ef2a0...
Author: Jacob Michalskie
Date: 2023-10-13 (Fri, 13 Oct 2023)
Changed paths:
M src/api/app/controllers/webui/comments_controller.rb
M src/api/app/models/comment_locking_validator.rb
M src/api/app/policies/comment_lock_policy.rb
M src/api/app/policies/comment_policy.rb
M src/api/app/views/webui/comment/_new.html.haml
Log Message:
-----------
Merge pull request #15053 from hellcp-work/comment-locking-policy
Don't display the comment field when the comments are locked
Compare: https://github.com/openSUSE/open-build-service/compare/3e475d495001...595a86...
