Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: fd779419205bfe439ba8042450dd06637b044306
https://github.com/openSUSE/open-build-service/commit/fd779419205bfe439ba804...
Author: Henne Vogelsang
Date: 2024-06-26 (Wed, 26 Jun 2024)
Changed paths:
M src/api/app/controllers/concerns/triggerable.rb
M src/api/app/controllers/webui/package_controller.rb
M src/api/app/controllers/webui/packages/trigger_controller.rb
M src/api/app/controllers/webui/webui_controller.rb
Log Message:
-----------
Move set_object_to_authorize to WebuiController
This is going to see more wide spread use...
Commit: 67cc159f73088ac8662ae150eb1d8117c63a2f00
https://github.com/openSUSE/open-build-service/commit/67cc159f73088ac8662ae1...
Author: Henne Vogelsang
Date: 2024-06-26 (Wed, 26 Jun 2024)
Changed paths:
M src/api/spec/controllers/webui/packages/build_log_controller_spec.rb
A src/api/spec/fixtures/files/build_result.xml
Log Message:
-----------
Simplify BuildLogController spec
There are a lot of specs testing various "standard" before filters that are
already tested elsewhere. Like multibuild, weird project names, Project/Package
not existing etc.
Both controller actions also use the same before filter chain. There is no need
to test the same thing twice.
There is also no need for VCR, we can mock build results easily.
Commit: 9d9d170186739197d3d0d9ab86fef0edca280665
https://github.com/openSUSE/open-build-service/commit/9d9d170186739197d3d0d9...
Author: Henne Vogelsang
Date: 2024-06-26 (Wed, 26 Jun 2024)
Changed paths:
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/successfully/1_1_1_1_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/successfully_with_a_package_which_name_that_includes_/1_1_1_2_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/successfully_with_a_project_which_name_that_includes_/1_1_1_3_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/with_a_non_existent_package/1_1_1_5_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/with_a_non_existent_package/1_1_1_5_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/with_a_non_existent_project/1_1_1_6_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/with_a_non_existent_project/1_1_1_6_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/with_a_protected_package/1_1_1_4_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/with_a_protected_package/1_1_1_4_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_multibuild_package/1_1_4_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_multibuild_package/1_1_4_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_multibuild_package/1_1_4_3.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_multibuild_package/1_1_4_4.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_multibuild_package/1_1_4_5.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_multibuild_package/1_1_4_6.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_nonexistent_architecture/1_1_3_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_nonexistent_architecture/1_1_3_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_nonexistent_repository/1_1_2_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_nonexistent_repository/1_1_2_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/successfully/1_2_1_1_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/successfully_with_a_package_which_name_that_includes_/1_2_1_2_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/successfully_with_a_project_which_name_that_includes_/1_2_1_3_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/with_a_non_existent_package/1_2_1_5_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/with_a_non_existent_package/1_2_1_5_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/with_a_non_existent_project/1_2_1_6_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/with_a_non_existent_project/1_2_1_6_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/with_a_protected_package/1_2_1_4_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/with_a_protected_package/1_2_1_4_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/for_multibuild_package/1_2_4_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/for_multibuild_package/1_2_4_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/for_multibuild_package/1_2_4_3.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/for_multibuild_package/1_2_4_4.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/for_multibuild_package/1_2_4_5.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/with_a_nonexistent_architecture/1_2_3_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/with_a_nonexistent_architecture/1_2_3_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/with_a_nonexistent_repository/1_2_2_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/with_a_nonexistent_repository/1_2_2_2.yml
Log Message:
-----------
Drop BuildLogController spec cassettes
We don't use VCR anymore for this spec
Commit: 18124e9d2016754d88bb7480cb34aa35ee284669
https://github.com/openSUSE/open-build-service/commit/18124e9d2016754d88bb74...
Author: Henne Vogelsang
Date: 2024-06-26 (Wed, 26 Jun 2024)
Changed paths:
M src/api/app/controllers/webui/packages/build_log_controller.rb
M src/api/app/views/webui/packages/build_log/live_build_log.html.haml
Log Message:
-----------
Use standard before filters
Instead of re-inventing set_project/repository/architecture.
Commit: 28d72ff3e53b3edc94fe8355a160f76bf9a661d9
https://github.com/openSUSE/open-build-service/commit/28d72ff3e53b3edc94fe83...
Author: Henne Vogelsang
Date: 2024-06-26 (Wed, 26 Jun 2024)
Changed paths:
M src/api/app/controllers/webui/packages/build_log_controller.rb
Log Message:
-----------
Drop redundant begin
Commit: 9411e51673c2266f3fc6835f5c62dec11a2feb24
https://github.com/openSUSE/open-build-service/commit/9411e51673c2266f3fc683...
Author: Henne Vogelsang
Date: 2024-06-26 (Wed, 26 Jun 2024)
Changed paths:
M src/api/app/controllers/webui/packages/build_log_controller.rb
M src/api/app/views/webui/packages/build_log/_live_build_log_controls.html.haml
M src/api/app/views/webui/packages/build_log/live_build_log.html.haml
Log Message:
-----------
Drop @can_modify from BuildLogController
Use the standard object_to_authorze before filter and the pundit
policy instead of re-inventing it.
Commit: caab448afc9f0af361a28464d2a8cd9292352b91
https://github.com/openSUSE/open-build-service/commit/caab448afc9f0af361a284...
Author: Henne Vogelsang
Date: 2024-06-26 (Wed, 26 Jun 2024)
Changed paths:
M src/api/app/controllers/webui/packages/build_log_controller.rb
Log Message:
-----------
Use standard set_package before filter
Instead of re-inventing it with check_build_log_access
Commit: baccf42ac0cf5b047b363a9b9804c33ad96b5628
https://github.com/openSUSE/open-build-service/commit/baccf42ac0cf5b047b363a...
Author: Henne Vogelsang
Date: 2024-06-26 (Wed, 26 Jun 2024)
Changed paths:
M src/api/app/controllers/concerns/triggerable.rb
M src/api/app/controllers/webui/package_controller.rb
M src/api/app/controllers/webui/packages/build_log_controller.rb
M src/api/app/controllers/webui/packages/trigger_controller.rb
M src/api/app/controllers/webui/webui_controller.rb
M src/api/app/views/webui/packages/build_log/_live_build_log_controls.html.haml
M src/api/app/views/webui/packages/build_log/live_build_log.html.haml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/successfully/1_1_1_1_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/successfully_with_a_package_which_name_that_includes_/1_1_1_2_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/successfully_with_a_project_which_name_that_includes_/1_1_1_3_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/with_a_non_existent_package/1_1_1_5_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/with_a_non_existent_package/1_1_1_5_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/with_a_non_existent_project/1_1_1_6_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/with_a_non_existent_project/1_1_1_6_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/with_a_protected_package/1_1_1_4_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/behaves_like_build_log/with_a_protected_package/1_1_1_4_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_multibuild_package/1_1_4_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_multibuild_package/1_1_4_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_multibuild_package/1_1_4_3.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_multibuild_package/1_1_4_4.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_multibuild_package/1_1_4_5.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_multibuild_package/1_1_4_6.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_nonexistent_architecture/1_1_3_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_nonexistent_architecture/1_1_3_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_nonexistent_repository/1_1_2_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_package_live_build_log/with_a_nonexistent_repository/1_1_2_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/successfully/1_2_1_1_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/successfully_with_a_package_which_name_that_includes_/1_2_1_2_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/successfully_with_a_project_which_name_that_includes_/1_2_1_3_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/with_a_non_existent_package/1_2_1_5_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/with_a_non_existent_package/1_2_1_5_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/with_a_non_existent_project/1_2_1_6_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/with_a_non_existent_project/1_2_1_6_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/with_a_protected_package/1_2_1_4_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/behaves_like_build_log/with_a_protected_package/1_2_1_4_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/for_multibuild_package/1_2_4_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/for_multibuild_package/1_2_4_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/for_multibuild_package/1_2_4_3.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/for_multibuild_package/1_2_4_4.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/for_multibuild_package/1_2_4_5.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/with_a_nonexistent_architecture/1_2_3_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/with_a_nonexistent_architecture/1_2_3_2.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/with_a_nonexistent_repository/1_2_2_1.yml
R src/api/spec/cassettes/Webui_Packages_BuildLogController/GET_update_build_log/with_a_nonexistent_repository/1_2_2_2.yml
M src/api/spec/controllers/webui/packages/build_log_controller_spec.rb
A src/api/spec/fixtures/files/build_result.xml
Log Message:
-----------
Merge pull request #16407 from hennevogel/refactoring/scm-buildlog
Fix source_access support when viewing build logs of scmsync'ed packages
Compare: https://github.com/openSUSE/open-build-service/compare/e0761c4f48fc...baccf4...
To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications
