Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 8214c5b64475af268997b7c0562ede2eb4f01369
https://github.com/openSUSE/open-build-service/commit/8214c5b64475af268997b7...
Author: Dany Marcoux
Date: 2022-03-24 (Thu, 24 Mar 2022)
Changed paths:
M src/api/app/controllers/trigger_controller.rb
M src/api/app/controllers/trigger_workflow_controller.rb
Log Message:
-----------
Respond with an error when the SCM is unsupported
Before, validate_params was only skipped when the SCM is supported
(GitHub or GitLab). This caused issues whenever a payload from an
unsupported SCM didn't pass the checks in validate_params. For example,
Codeberg seems to include `nil` instead of `null` in its JSON payloads.
This caused validate_params to raise an exception, preventing us from
responding back to the SCM with a helpful error message stating that
Codeberg isn't supported.
Fixes #11861
Commit: 74d50a8aea3a5490acea79fb9526af13b62cbb5b
https://github.com/openSUSE/open-build-service/commit/74d50a8aea3a5490acea79...
Author: Dany Marcoux
Date: 2022-03-28 (Mon, 28 Mar 2022)
Changed paths:
M src/api/app/controllers/trigger_controller.rb
M src/api/app/controllers/trigger_workflow_controller.rb
Log Message:
-----------
Merge pull request #12353 from dmarcoux/do-not-crash-scm-unsupported
Respond with an error when the SCM is unsupported
Compare: https://github.com/openSUSE/open-build-service/compare/be669bb8f07e...74d50a...
