Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: eafebe901db120d11b65dfd7c5af48909a26c094
https://github.com/openSUSE/open-build-service/commit/eafebe901db120d11b65df...
Author: Björn Geuken
Date: 2018-04-17 (Tue, 17 Apr 2018)
Changed paths:
M src/api/spec/models/bs_request_spec.rb
Log Message:
-----------
[frontend] Reduce duplication of created objects in request test
Commit: d0e8f6c4dbf81dad74070ca1641b19673f6080f4
https://github.com/openSUSE/open-build-service/commit/d0e8f6c4dbf81dad74070c...
Author: Björn Geuken
Date: 2018-04-17 (Tue, 17 Apr 2018)
Changed paths:
M src/api/spec/models/bs_request_spec.rb
Log Message:
-----------
[frontend] DRY creation of basic submit request in request test
Define a global submit request object. This way we can easily re-use
this object.
Commit: af1023c84bd414eee3a5331b486c5a7c7bc09fe5
https://github.com/openSUSE/open-build-service/commit/af1023c84bd414eee3a533...
Author: Björn Geuken
Date: 2018-04-17 (Tue, 17 Apr 2018)
Changed paths:
M src/api/app/models/bs_request.rb
Log Message:
-----------
[frontend] Cleanup code for applying reviewers
Use `if *.any?` instead of `unless *.select(..).empty?`.
Commit: 4e1f5bfa311022080e104638a0590c09ce791ae1
https://github.com/openSUSE/open-build-service/commit/4e1f5bfa311022080e1046...
Author: Björn Geuken
Date: 2018-04-17 (Tue, 17 Apr 2018)
Changed paths:
M src/api/app/controllers/webui/request_controller.rb
M src/api/app/models/bs_request.rb
A src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/creates_a_new_submit_request_open_for_review.yml
A src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/creates_a_submit_request_action_with_the_correct_target.yml
A src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/sets_the_logged_in_user_as_creator_of_the_request.yml
A src/api/spec/cassettes/BsRequest/_forward_to/with_options/creates_a_submit_request_action_with_the_correct_target.yml
A src/api/spec/cassettes/BsRequest/_forward_to/with_options/sets_the_given_description.yml
A src/api/spec/cassettes/BsRequest/_forward_to/with_project_and_package_as_parameter/creates_a_submit_request_action_with_the_correct_target.yml
M src/api/spec/models/bs_request_spec.rb
Log Message:
-----------
[frontend] Move request forwarding to bs request model
This code is quite complex and should better be handled in the model.
This also makes it easier to test request forwarding.
Commit: 794572499dd88a29b91c47fa18991e3777519578
https://github.com/openSUSE/open-build-service/commit/794572499dd88a29b91c47...
Author: Björn Geuken
Date: 2018-04-17 (Tue, 17 Apr 2018)
Changed paths:
M src/api/app/models/bs_request_action.rb
Log Message:
-----------
[frontend] Refactor BsRequestAction#find_reviewers
Reviewers of packages and projects are almost handled the same way. This
removes the duplicated code.
Commit: cb599c13f04667311c9dc016c737aa091f2d5c36
https://github.com/openSUSE/open-build-service/commit/cb599c13f04667311c9dc0...
Author: Björn Geuken
Date: 2018-04-17 (Tue, 17 Apr 2018)
Changed paths:
M src/api/app/models/bs_request.rb
Log Message:
-----------
[frontend] Move code for collecting reviewers to separate method
Commit: e5707528197a2851d4ed4c21efe13fcfa445db3e
https://github.com/openSUSE/open-build-service/commit/e5707528197a2851d4ed4c...
Author: Björn Geuken
Date: 2018-04-18 (Wed, 18 Apr 2018)
Changed paths:
M src/api/app/models/bs_request.rb
M src/api/spec/controllers/webui/package_controller_spec.rb
M src/api/spec/models/bs_request_spec.rb
Log Message:
-----------
[frontend] Include request action validations to bs request validations
Before it wasn't possible to see why a bs request action was causing a
bs request to fail. All a user would see was 'Validation failed: Bs
request actions is invalid'.
Now the validation message would include details of the failed request
action.
This allows users to see why a request failed, eg. when forwarding a
request (related to #3730).
Commit: 1b036528420033a6b04da0e354b83502617e44a6
https://github.com/openSUSE/open-build-service/commit/1b036528420033a6b04da0...
Author: Björn Geuken
Date: 2018-04-18 (Wed, 18 Apr 2018)
Changed paths:
M src/api/app/models/bs_request.rb
Log Message:
-----------
[frontend] Further cleanup forward request code
* Drop explicitly setting the state to new. That's the default anyway.
* Refactor building the new bs request action.
Commit: 1232fa112037e7ba93dc73cbb9c7266142d7dd58
https://github.com/openSUSE/open-build-service/commit/1232fa112037e7ba93dc73...
Author: Björn Geuken
Date: 2018-04-18 (Wed, 18 Apr 2018)
Changed paths:
M src/api/app/controllers/webui/request_controller.rb
M src/api/app/models/bs_request.rb
M src/api/app/models/bs_request_action.rb
A src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/creates_a_new_submit_request_open_for_review.yml
A src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/creates_a_submit_request_action_with_the_correct_target.yml
A src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/sets_the_logged_in_user_as_creator_of_the_request.yml
A src/api/spec/cassettes/BsRequest/_forward_to/with_options/creates_a_submit_request_action_with_the_correct_target.yml
A src/api/spec/cassettes/BsRequest/_forward_to/with_options/sets_the_given_description.yml
A src/api/spec/cassettes/BsRequest/_forward_to/with_project_and_package_as_parameter/creates_a_submit_request_action_with_the_correct_target.yml
M src/api/spec/controllers/webui/package_controller_spec.rb
M src/api/spec/models/bs_request_spec.rb
Log Message:
-----------
Merge pull request #4872 from bgeuken/refactor_request_forwarding
Refactor request forwarding and improve propagation of validation errors
Compare: https://github.com/openSUSE/open-build-service/compare/5612f184e0eb...1232fa...
