Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 4cebe3b4b47245b85e36839d442399cf3c508fc9
https://github.com/openSUSE/open-build-service/commit/4cebe3b4b47245b85e3683...
Author: Ana María Martínez Gómez
Date: 2018-06-22 (Fri, 22 Jun 2018)
Changed paths:
M src/api/app/views/webui/request/_superseded_by_message.html.haml
Log Message:
-----------
[api] Do not use succeed + surround
`succeed` appends a string to the end of a Haml block, and `surround`
appends strings to the end and the beginning. Because of that, if we
already need to use `surround`, it doesn't make sense to use `succeed`
as well. It is also more readable, as what we want is just a comma after
the closing parenthesis.
Commit: 4a5709fae5a88fcc085ac72657a97e454a807845
https://github.com/openSUSE/open-build-service/commit/4a5709fae5a88fcc085ac7...
Author: Ana María Martínez Gómez
Date: 2018-06-22 (Fri, 22 Jun 2018)
Changed paths:
M src/api/app/views/webui/request/_superseded_by_message.html.haml
Log Message:
-----------
[api] Use superseding.last instead of index
We want a comma except for the last record, because of that I think that
it is more readable to use `superseding.last` than using an index and
comparing it with `superseding.length - 1`. This way we also don't need
to use `each_with_index`, as we don't really care of what index every
record have.
This may be a matter of taste, but I find it more elegant.
Commit: aa0c1fcbc87b15eb77fcbafaf51a6836b771f88e
https://github.com/openSUSE/open-build-service/commit/aa0c1fcbc87b15eb77fcba...
Author: Ana María Martínez Gómez
Date: 2018-06-22 (Fri, 22 Jun 2018)
Changed paths:
M src/api/app/views/webui/request/_superseded_by_message.html.haml
Log Message:
-----------
Merge pull request #5190 from Ana06/succeed
Refactor how we render superseded requests list
Compare: https://github.com/openSUSE/open-build-service/compare/d0450c522aa6...aa0c1f...
**NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
