Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 066d9c554f71576a4d40abf32058e2986a5c51bf
https://github.com/openSUSE/open-build-service/commit/066d9c554f71576a4d40ab...
Author: Björn Geuken
Date: 2017-10-02 (Mon, 02 Oct 2017)
Changed paths:
M src/api/app/controllers/webui/project_controller.rb
M src/api/app/models/project/update_from_xml_command.rb
M src/api/spec/controllers/webui/project_controller_spec.rb
Log Message:
-----------
[webui] Remove unused exception handling
UnknownObjectError is not raised by any of the methods called in the
controller. This exception can occure only when calling update_from_xml.
But this method is wrapped within a transaction, which will catch the
exception.
This commit removes the unused rescue and adds a test for calling
save_meta with invalid devel projects.
We also update the xml parser code to throw a more explicit error
message.
Commit: 343f2ce69cd6dc97a1b3b9413c9e15f392352f1a
https://github.com/openSUSE/open-build-service/commit/343f2ce69cd6dc97a1b3b9...
Author: Björn Geuken
Date: 2017-10-02 (Mon, 02 Oct 2017)
Changed paths:
M src/api/app/controllers/webui/project_controller.rb
M src/api/app/models/project/update_from_xml_command.rb
M src/api/spec/controllers/webui/project_controller_spec.rb
Log Message:
-----------
Merge pull request #3933 from bgeuken/save_meta
[webui] Remove unused exception handling
Compare: https://github.com/openSUSE/open-build-service/compare/ca31fc661e84...343f2c...
