[obs-commits] [openSUSE/open-build-service] b27fa5: [api][webui] Update OBS to rails v5.0.0

26 Aug 2016

      Branch: refs/heads/master
  Home:   https://github.com/openSUSE/open-build-service
  Commit: b27fa5ef7db59c3261b839aa1a4fd54e04c4c850
      https://github.com/openSUSE/open-build-service/commit/b27fa5ef7db59c3261b839...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-24 (Wed, 24 Aug 2016)

  Changed paths:
    M src/api/Gemfile
    M src/api/Gemfile.lock
    M src/api/config/environments/development.rb
    M src/api/config/environments/test.rb

  Log Message:
  -----------
  [api][webui] Update OBS to rails v5.0.0

  Commit: ea7b5e64259b92640552237e983a547c935ec18b
      https://github.com/openSUSE/open-build-service/commit/ea7b5e64259b9264055223...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-24 (Wed, 24 Aug 2016)

  Changed paths:
    A src/api/app/models/application_record.rb
    M src/api/app/models/architecture.rb
    M src/api/app/models/attrib.rb
    M src/api/app/models/attrib_allowed_value.rb
    M src/api/app/models/attrib_default_value.rb
    M src/api/app/models/attrib_issue.rb
    M src/api/app/models/attrib_namespace.rb
    M src/api/app/models/attrib_namespace_modifiable_by.rb
    M src/api/app/models/attrib_type.rb
    M src/api/app/models/attrib_type_modifiable_by.rb
    M src/api/app/models/attrib_value.rb
    M src/api/app/models/backend_info.rb
    M src/api/app/models/backend_package.rb
    M src/api/app/models/binary_release.rb
    M src/api/app/models/blacklist_tag.rb
    M src/api/app/models/bs_request.rb
    M src/api/app/models/bs_request_action.rb
    M src/api/app/models/bs_request_action_accept_info.rb
    M src/api/app/models/build_container.rb
    M src/api/app/models/cache_line.rb
    M src/api/app/models/channel.rb
    M src/api/app/models/channel_binary.rb
    M src/api/app/models/channel_binary_list.rb
    M src/api/app/models/channel_target.rb
    M src/api/app/models/comment.rb
    M src/api/app/models/configuration.rb
    M src/api/app/models/distribution.rb
    M src/api/app/models/distribution_icon.rb
    M src/api/app/models/download_repository.rb
    M src/api/app/models/event/base.rb
    M src/api/app/models/event_subscription.rb
    M src/api/app/models/flag.rb
    M src/api/app/models/full_text_search.rb
    M src/api/app/models/group.rb
    M src/api/app/models/group_maintainer.rb
    M src/api/app/models/groups_user.rb
    M src/api/app/models/history_element.rb
    M src/api/app/models/incident_updateinfo_counter_value.rb
    M src/api/app/models/issue.rb
    M src/api/app/models/issue_tracker.rb
    M src/api/app/models/linked_project.rb
    M src/api/app/models/maintained_project.rb
    M src/api/app/models/maintenance_incident.rb
    M src/api/app/models/message.rb
    M src/api/app/models/package.rb
    M src/api/app/models/package_issue.rb
    M src/api/app/models/package_kind.rb
    M src/api/app/models/path_element.rb
    M src/api/app/models/product.rb
    M src/api/app/models/product_medium.rb
    M src/api/app/models/product_update_repository.rb
    M src/api/app/models/project.rb
    M src/api/app/models/project_log_entry.rb
    M src/api/app/models/rating.rb
    M src/api/app/models/relationship.rb
    M src/api/app/models/release_target.rb
    M src/api/app/models/repository.rb
    M src/api/app/models/repository_architecture.rb
    M src/api/app/models/review.rb
    M src/api/app/models/role.rb
    M src/api/app/models/roles_static_permission.rb
    M src/api/app/models/roles_user.rb
    M src/api/app/models/static_permission.rb
    M src/api/app/models/status_history.rb
    M src/api/app/models/status_message.rb
    M src/api/app/models/tag.rb
    M src/api/app/models/tagcloud.rb
    M src/api/app/models/tagging.rb
    M src/api/app/models/token.rb
    M src/api/app/models/updateinfo.rb
    M src/api/app/models/updateinfo_counter.rb
    M src/api/app/models/user.rb
    M src/api/app/models/watched_project.rb

  Log Message:
  -----------
  [api] rails 5: Active Record Models Now Inherit from ApplicationRecord by Default

All models now inherit from ApplicationRecord. Check rails guide for details:

http://guides.rubyonrails.org/v5.0//upgrading_ruby_on_rails.html#active-reco...

  Commit: 02271b29b58642d3b6141bd9793b7572e79290a5
      https://github.com/openSUSE/open-build-service/commit/02271b29b58642d3b6141b...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-24 (Wed, 24 Aug 2016)

  Changed paths:
    M src/api/Rakefile
    A src/api/app/jobs/application_job.rb
    M src/api/app/jobs/cleanup_events.rb
    M src/api/app/jobs/consistency_check.rb
    M src/api/app/jobs/project_create_auto_cleanup_requests.rb
    M src/api/app/jobs/update_package_meta_job.rb

  Log Message:
  -----------
  [api] rails 5: ActiveJob Now Inherits from ApplicationJob by Default

Starting with rails 5 Active Jobs inherit from ApplicationJob instead of ActiveJob::Base.
Checkout the rails guide for details:

http://guides.rubyonrails.org/v5.0//upgrading_ruby_on_rails.html#activejob-n...

  Commit: 1724de0b9857f81ef0bc1751d2e23c60f2050693
      https://github.com/openSUSE/open-build-service/commit/1724de0b9857f81ef0bc17...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-24 (Wed, 24 Aug 2016)

  Changed paths:
    M src/api/spec/controllers/webui/monitor_controller_spec.rb
    M src/api/spec/controllers/webui/project_controller_spec.rb

  Log Message:
  -----------
  [ci] rails 5: Update syntax for ajax requests for ActionController::TestCase and ActionDispatch::Integration

Old syntax:
  xhr :get, :create, params: { id: 1 }

New syntax example:
  get :create, params: { id: 1 }, xhr: true

https://github.com/rails/rails/blob/v5.0.0/actionpack/CHANGELOG.md

  Commit: 0668b9bea087d260f834a9e14ce8f581ce6dbf97
      https://github.com/openSUSE/open-build-service/commit/0668b9bea087d260f834a9...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-24 (Wed, 24 Aug 2016)

  Changed paths:
    M src/api/Gemfile
    M src/api/Gemfile.lock

  Log Message:
  -----------
  [ci] rails 5: assigns test helper has been moved to rails-controller-testing gem

http://guides.rubyonrails.org/v5.0//upgrading_ruby_on_rails.html#rails-contr...

  Commit: 007339119211d4273ea66c158d52e130d72f909f
      https://github.com/openSUSE/open-build-service/commit/007339119211d4273ea66c...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-24 (Wed, 24 Aug 2016)

  Changed paths:
    M dist/README.UPDATERS
    M dist/ci/obs_testsuite_travis.sh
    M dist/ci/obs_testsuite_travis_before.sh
    M dist/obs-server.spec
    M dist/obsapidelayed
    M dist/setup-appliance.sh
    M src/api/app/jobs/consistency_check.rb
    M src/api/config/application.rb
    M src/api/config/database.yml.example
    M src/api/config/deploy.rb
    M src/api/lib/tasks/capistrano.rake
    M src/api/lib/tasks/test_webui.rake

  Log Message:
  -----------
  [ci] rails 5: Use bin/rails for running tasks and tests

Rails now uses 'rails' instead of 'rake' for calling rake tasks. For now
both commands are ok to use (in most cases).

http://guides.rubyonrails.org/v5.0//upgrading_ruby_on_rails.html#use-bin-rai...

  Commit: bef6b0e8f844c81fc44fa94835c47e1a8dc2e899
      https://github.com/openSUSE/open-build-service/commit/bef6b0e8f844c81fc44fa9...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-24 (Wed, 24 Aug 2016)

  Changed paths:
    M src/api/Gemfile
    M src/api/Gemfile.lock

  Log Message:
  -----------
  [api][ci] rails 5: XML Serialization got moved into a gem

This was crashing the start backend script

  Commit: c8e2c362dc54dbd0879b5fa6ce76e9839d6ae8ed
      https://github.com/openSUSE/open-build-service/commit/c8e2c362dc54dbd0879b5f...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-24 (Wed, 24 Aug 2016)

  Changed paths:
    M src/api/test/functional/tag_controller_test.rb
    M src/api/test/test_helper.rb

  Log Message:
  -----------
  [ci] rails 5: Adapt to changes made in ActionDispatch::Integration#process

It's now using keyword arguments.
OBS is overloading the process method method. That method is now using
keyword arguments, which broke our tests. This commit updates the our
overloading method to be compatible with the old and new format.

-> actionpack-5.0.0/lib/action_dispatch/testing/integration.rb

  Commit: 44caa1d56e196955a310d438bf37a5f274586062
      https://github.com/openSUSE/open-build-service/commit/44caa1d56e196955a310d4...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-24 (Wed, 24 Aug 2016)

  Changed paths:
    M src/api/app/controllers/application_controller.rb
    M src/api/app/controllers/source_controller.rb
    M src/api/app/controllers/webui/project_controller.rb
    M src/api/lib/opensuse/validator.rb

  Log Message:
  -----------
  [api][webui] rails 5: ActionController::Parameters no longer inherits from HashWithIndifferentAccess

http://guides.rubyonrails.org/v5.0/upgrading_ruby_on_rails.html#actioncontro...

  Commit: c97423978290b369aed20a30c3b9184935ae8c9f
      https://github.com/openSUSE/open-build-service/commit/c97423978290b369aed20a...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    A src/api/test/controllers/.keep
    A src/api/test/helpers/.keep
    A src/api/test/mailers/.keep

  Log Message:
  -----------
  [ci] rails 5: Fix running rails rake test:units / rake test:functionals

Certain directories are now required when running rake test:{units,functionals}.
  units:       "test/models", "test/helpers", "test/unit"
  functionals: "test/controllers", "test/mailers", "test/functional"

-> /usr/lib64/ruby/gems/2.3.0/gems/railties-5.0.0/lib/rails/test_unit/testing.rake

  Commit: d378307d5f1470d37814537c6446197befa4300f
      https://github.com/openSUSE/open-build-service/commit/d378307d5f1470d3781453...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/test/unit/validator_test.rb

  Log Message:
  -----------
  [ci] rails 5: Update TestRequest usage in validator test

TestRequest api changed and 'new' now expects parameters. However create
still doesn't. Hence we can workaround this.

  Commit: 575b7b9a7d6757436adc8a76872ded1217f9b16d
      https://github.com/openSUSE/open-build-service/commit/575b7b9a7d6757436adc8a...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/test/unit/code_quality_test.rb

  Log Message:
  -----------
  [ci] rails 5: Adopt recent changes of flog gem

Path expansion got split into path_expander gem:

https://github.com/seattlerb/path_expander

  Commit: aabb46269823a978e042336cdbf3c63a1e8c53c4
      https://github.com/openSUSE/open-build-service/commit/aabb46269823a978e04233...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M dist/obs-server.spec
    M src/api/bin/rails
    M src/api/config/application.rb
    M src/api/config/boot.rb
    A src/api/config/cable.yml
    M src/api/config/environment.rb
    M src/api/config/environments/development.rb
    M src/api/config/environments/production.rb
    M src/api/config/environments/test.rb
    A src/api/config/initializers/application_controller_renderer.rb
    A src/api/config/initializers/assets.rb
    M src/api/config/initializers/backtrace_silencers.rb
    A src/api/config/initializers/cookies_serializer.rb
    A src/api/config/initializers/filter_parameter_logging.rb
    M src/api/config/initializers/inflections.rb
    M src/api/config/initializers/mime_types.rb
    A src/api/config/initializers/new_framework_defaults.rb
    A src/api/config/locales/en.yml
    A src/api/config/puma.rb
    A src/api/config/secrets.yml
    A src/api/config/spring.rb

  Log Message:
  -----------
  [api][webui] rails 5: Review and integrate changes proposed by rails app:update

http://guides.rubyonrails.org/v5.0/upgrading_ruby_on_rails.html#the-update-t...

  Commit: a0fa328a540e2bb99bd787b4ef4a1804d275855a
      https://github.com/openSUSE/open-build-service/commit/a0fa328a540e2bb99bd787...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/db/structure.sql

  Log Message:
  -----------
  [api] rails 5: Run rails db:migrate

Some rails internals have changed and it's recommended to run rails db:migrate.
=> New ar_internal_metadata table.

  Commit: a765bd4e1d27c2e1f1f8695f2bf3837444f1b408
      https://github.com/openSUSE/open-build-service/commit/a765bd4e1d27c2e1f1f869...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/app/controllers/application_controller.rb

  Log Message:
  -----------
  [api][webui] Rails 5: Remove old workaround in render_error method

This was causing tests to fail due to an exception: RuntimeError: can't modify frozen String

  Commit: e251a8f28de37dfe2be44a8ba2f6fc6453003523
      https://github.com/openSUSE/open-build-service/commit/e251a8f28de37dfe2be44a...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/app/models/bs_request_action_maintenance_release.rb

  Log Message:
  -----------
  [ci][api] rails 5: Fix ActiveRecord::ReadOnlyRecord error

In Rails 5 spkg.project started to return a readonly marked project. This
prevents this from happening.

==============

ActiveRecord::ReadOnlyRecord (Project is marked as readonly):

app/models/project.rb:883:in `block in store'
app/models/project.rb:882:in `store'
app/models/bs_request_action_maintenance_release.rb:160:in `create_post_permissions_hook'
app/models/bs_request.rb:985:in `block in apply_default_reviewers'
app/models/bs_request.rb:982:in `apply_default_reviewers'
app/models/bs_request.rb:963:in `sanitize!'
app/models/bs_request.rb:62:in `save!'
app/controllers/request_controller.rb:151:in `block in request_create'
app/controllers/request_controller.rb:147:in `request_create'

  Commit: e03e407fa6d29ce663b62f0a143c66b1b286a637
      https://github.com/openSUSE/open-build-service/commit/e03e407fa6d29ce663b62f...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/.rubocop_todo.yml

  Log Message:
  -----------
  [ci][api] rails 5: Style/DeprecatedHashMethods offence got renamed to Style/PreferredHashMethods

https://github.com/bbatsov/rubocop/pull/3226

  Commit: 915f901b04c23a5ed9a06304373cb52f402f6f03
      https://github.com/openSUSE/open-build-service/commit/915f901b04c23a5ed9a063...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/.rubocop.yml

  Log Message:
  -----------
  [ci] rails 5: Update enablement of rails cops in .rubocop.yml

=========

Error: obsolete parameter RunRailsCops (for AllCops) found in /vagrant/src/api/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

  Commit: db7fe291ac7e33177b7250a3c27359101eddfc87
      https://github.com/openSUSE/open-build-service/commit/db7fe291ac7e33177b7250...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/test/test_helper.rb

  Log Message:
  -----------
  [api] Make Rubocop happy

  Commit: f4b5164fbe5173eaf3515066114ef34f175bf65a
      https://github.com/openSUSE/open-build-service/commit/f4b5164fbe5173eaf35150...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/.rubocop_todo.yml

  Log Message:
  -----------
  [ci] rails 5: Update rubocop todo file after rubocop update

  Commit: 4775b2a21dd3536504366835b7f81fbc570ab530
      https://github.com/openSUSE/open-build-service/commit/4775b2a21dd35365043668...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/spec/controllers/webui/user_controller_spec.rb

  Log Message:
  -----------
  [ci] rails 5: Fix ruby 2.0 parser error reported by rubocop

========

spec/controllers/webui/user_controller_spec.rb:101:43: E: unexpected token tCOLON
(Using Ruby 2.0 parser; configure using TargetRubyVersion parameter, under AllCops)
      expect(response.body).to eq({"sEcho": 2, "iTotalRecords": 1, "iTotalDisplayRecords": 1, "aaData": []}.to_json)

  Commit: 2f6d9b3ec3d81b015675e097e7258899643d85bc
      https://github.com/openSUSE/open-build-service/commit/2f6d9b3ec3d81b015675e0...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/test/functional/zzz_post_consistency_test.rb

  Log Message:
  -----------
  [ci] rails5: Update post consistency test

Replace deprecated assert_tag with assert_xml_tag

  Commit: 7a9f0910990824d2760490bc7c1b0cf79a7af51e
      https://github.com/openSUSE/open-build-service/commit/7a9f0910990824d2760490...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/Gemfile
    M src/api/Gemfile.lock
    M src/api/app/assets/javascripts/webui/application/project.js
    M src/api/app/assets/stylesheets/webui/application.css
    M src/api/app/assets/stylesheets/webui/application/project.css.scss
    M src/api/app/controllers/webui/user_controller.rb
    M src/api/app/controllers/webui/webui_controller.rb
    M src/api/app/views/shared/_involved_users.html.erb
    M src/api/app/views/shared/_requests.html.erb
    M src/api/app/views/webui/groups/index.html.erb
    M src/api/app/views/webui/home/index.html.erb
    M src/api/app/views/webui/package/_files_view.html.erb
    M src/api/app/views/webui/project/subprojects.html.haml
    M src/api/app/views/webui/user/index.html.haml
    M src/api/app/views/webui/user/show.html.erb
    M src/api/spec/controllers/webui/user_controller_spec.rb
    M src/api/test/functional/webui/request_controller_test.rb

  Log Message:
  -----------
  [webui] Update dataTable to version 3.4

This commit upgrades dataTable from v1.9.4 (legacy) to v3.4, which is required
for upgrading to rails 5.

Paging type had to be set explicitly now (to simple) to have the previous / next format.

Icons (and css) are missing right now
  https://datatables.net/reference/option/pagingType

Converted parameter names are documented here:
  https://datatables.net/upgrade/1.10-convert
  https://datatables.net/manual/server-side

  Commit: e2fb231275d02d0b68d6cecdfb3c5e7b4de90262
      https://github.com/openSUSE/open-build-service/commit/e2fb231275d02d0b68d6ce...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/spec/support/shared_examples/features/flags_tables.rb

  Log Message:
  -----------
  [ci] Rails 5, capybara: Explicitly search for invisble element

The element we select in our test, and we later on check for a changed label,
is invisible until the user hovers over it. To do so in our tests we have to
find() and then hover() the element.

With the recent capybara update we need to explicitly set the visible: false
parameter when calling find().

  Commit: dbef2684f0e0384e238208ab1caf9d87863eebf3
      https://github.com/openSUSE/open-build-service/commit/dbef2684f0e0384e238208...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/app/controllers/webui/project_controller.rb

  Log Message:
  -----------
  [webui] Fix handling of stringified bolleans in index action of project controller

When a browser, or capybara, provided the (boolean) value of show_all parameter as
a string, the setting were always interpreted as true. This caused one of our tests
to fail and was also reproducable in firefox (44.0.2).

=======

3) Webui::ProjectController GET #index showing not home projects should eq 1

     Failure/Error: it { expect(assigns(:projects).length).to eq(1) }
       expected: 1
      got: 2
  (compared using ==)

     # ./spec/controllers/webui/project_controller_spec.rb:53:in `block (4 levels) in <top (required)>'
     # ./spec/support/logging.rb:4:in `block (2 levels) in <top (required)>'

  Commit: 76d388f7652bb038020dddf25e7a43bb64965cfa
      https://github.com/openSUSE/open-build-service/commit/76d388f7652bb038020ddd...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/app/models/package.rb

  Log Message:
  -----------
  [api] rails 5: Validate parameters before sending requests to /build

Follow up of changes made in rails 5 regarding parameter handling.

Also fixes:

test_trigger_rebuild_via_binaries_view                         ERROR (56.67s)
Capybara::ElementNotFound:         Capybara::ElementNotFound: Unable to find css "#flash-messages"
      test/functional/webui/package_controller_test.rb:544:in `test_trigger_rebuild_via_binaries_view'
      test/test_helper.rb:124:in `block in __run'
      test/test_helper.rb:124:in `map'
      test/test_helper.rb:124:in `__run'

  Commit: b782e028e791fdd0decae346b09a22dc8456edca
      https://github.com/openSUSE/open-build-service/commit/b782e028e791fdd0decae3...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/test/functional/webui/add_repo_test.rb

  Log Message:
  -----------
  [ci] Fix test failure in add_repo test

Minitest::Assertion:
    --- expected
    +++ actual
    @@ -1 +1 @@
    -[{"name"=>"images", "arch"=>["x86_64", "i586"]}, {"name"=>"Base_repo", "path"=>{"project"=>"BaseDistro2.0", "repository"=>"BaseDistro2_repo"}, "arch"=>["x86_64", "i586"]}, {"name"=>"10.2", "path"=>{"project"=>"BaseDistro", "repository"=>"BaseDistro_repo"}, "arch"=>["i586", "x86_64"]}]
    +[X({"name"=>"images", "arch"=>["x86_64", "i586"]}), X({"name"=>"Base_repo", "path"=>X({"project"=>"BaseDistro2.0", "repository"=>"BaseDistro2_repo"}), "arch"=>["i586", "x86_64"]}), X({"name"=>"10.2", "path"=>X({"project"=>"BaseDistro", "repository"=>"BaseDistro_repo"}), "arch"=>["i586", "x86_64"]})]
    test/functional/webui/add_repo_test.rb:27:in `test_add_default'

  Commit: b76e98e60320637803beb12c5f7621db65128037
      https://github.com/openSUSE/open-build-service/commit/b76e98e60320637803beb1...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/.rubocop_todo.yml
    M src/api/app/controllers/search_controller.rb
    M src/api/app/controllers/statistics_controller.rb
    M src/api/app/controllers/webui/monitor_controller.rb
    M src/api/app/controllers/webui/package_controller.rb
    M src/api/app/helpers/webui/project_helper.rb
    M src/api/app/models/channel.rb
    M src/api/app/models/event/request.rb
    M src/api/app/models/owner.rb
    M src/api/app/models/repository.rb
    M src/api/app/models/service.rb
    M src/api/app/models/tagcloud.rb
    M src/api/app/models/update_notification_events.rb
    M src/api/db/checker.rb
    M src/api/db/migrate/20140908125426_convert_request_history.rb
    M src/api/test/unit/schema_test.rb

  Log Message:
  -----------
  [api][webui] Update rubocop todo file and fix a few offenses

  Commit: 21d49eb3443f7f4b86a13dc279933ca695362bd1
      https://github.com/openSUSE/open-build-service/commit/21d49eb3443f7f4b86a13d...
  Author: Christian Bruckmayer <cbruckmayer@suse.com>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/lib/opensuse/backend.rb
    M src/api/test/functional/source_controller_test.rb

  Log Message:
  -----------
  [api] Adapt Illegal Encoding test

because Rails raises now an ActionController::BadRequest error, so raising an ApiException is not necessary anymore.
See Rails commit 59ab2d1ee5995d9ea27ca60e92576518c1898c59.

  Commit: 8239e9754cae56ace69fff24b84debecd42eb373
      https://github.com/openSUSE/open-build-service/commit/8239e9754cae56ace69fff...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/test/functional/channel_maintenance_test.rb
    M src/api/test/functional/kgraft_maintenance_test.rb
    M src/api/test/functional/maintenance_test.rb

  Log Message:
  -----------
  [ci] rails 5: Fix a couple of tests by using raw_post

Some tests started to fail due to encoding errors when doing http POSTs.
Since those tests were sending the data in the request body, not the parameter,
we could simply switch back to using raw_post. As we did before.

Partly reverts 6ad6ed6f0e8cdd56676cc7f7bb4d6a614d7c4e02

  Commit: 99bd43b962e4a904ed942ace9abf0c99541972f7
      https://github.com/openSUSE/open-build-service/commit/99bd43b962e4a904ed942a...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/app/views/webui/user/show.html.erb

  Log Message:
  -----------
  [webui] DataTable: Set a valid default entry for packages / projects

This will set the default entries on the user page to 10. Valid values are 10, 25, 50 and 100.

  Commit: 1a29972dba2cde64eea85f147cb6272ba36c4a34
      https://github.com/openSUSE/open-build-service/commit/1a29972dba2cde64eea85f...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/.rubocop_todo.yml

  Log Message:
  -----------
  [ci] Update .rubocop_todo.yml

  Commit: 4caa1d20bd7badf6bad4e2d0808667f9ba008b96
      https://github.com/openSUSE/open-build-service/commit/4caa1d20bd7badf6bad4e2...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/test/functional/webui/add_repo_test.rb

  Log Message:
  -----------
  [ci] Skip test to avoid random test failure in our ci which is running inside our rpm package build....

  Commit: d5c87417035866d9bd6839fdab6d12dc0c2ea74c
      https://github.com/openSUSE/open-build-service/commit/d5c87417035866d9bd6839...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/spec/controllers/webui/patchinfo_controller_spec.rb

  Log Message:
  -----------
  [ci] Fix broken patchinfo tests

Empty params get skipped currently. Might be related to https://github.com/rails/rails/issues/23438

This commit workarounds the problem.

  Commit: 15f0a228f3c0df01ff934c8254494e59fbbd35bf
      https://github.com/openSUSE/open-build-service/commit/15f0a228f3c0df01ff934c...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M src/api/spec/features/webui/packages_spec.rb

  Log Message:
  -----------
  [ci] Skip test fails after upgrading to rails 5

======

Failures:

  1) Packages editing package files editing an existing file
     Failure/Error: page.execute_script("$('.CodeMirror')[0].CodeMirror.setValue('added some new text')")

     Capybara::Poltergeist::JavascriptError:
       One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).
  TypeError: 'undefined' is not an object (evaluating '$('.CodeMirror')[0].CodeMirror')
       TypeError: 'undefined' is not an object (evaluating '$('.CodeMirror')[0].CodeMirror')
     at phantomjs://webpage.evaluate():1
     at phantomjs://webpage.evaluate():1
     at phantomjs://webpage.evaluate():1
     at phantomjs://webpage.evaluate():1
     # ./spec/features/webui/packages_spec.rb:58:in `block (3 levels) in <top (required)>'
     # ./spec/support/logging.rb:4:in `block (2 levels) in <top (required)>'

  Commit: 3a675e1cefdd344bde5a9d253feab64b9ef59a32
      https://github.com/openSUSE/open-build-service/commit/3a675e1cefdd344bde5a9d...
  Author: Björn Geuken <bgeuken@suse.de>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M dist/README.UPDATERS
    M dist/ci/obs_testsuite_travis.sh
    M dist/ci/obs_testsuite_travis_before.sh
    M dist/obs-server.spec
    M dist/obsapidelayed
    M dist/setup-appliance.sh
    M src/api/.rubocop.yml
    M src/api/.rubocop_todo.yml
    M src/api/Gemfile
    M src/api/Gemfile.lock
    M src/api/Rakefile
    M src/api/app/assets/javascripts/webui/application/project.js
    M src/api/app/assets/stylesheets/webui/application.css
    M src/api/app/assets/stylesheets/webui/application/project.css.scss
    M src/api/app/controllers/application_controller.rb
    M src/api/app/controllers/search_controller.rb
    M src/api/app/controllers/source_controller.rb
    M src/api/app/controllers/statistics_controller.rb
    M src/api/app/controllers/webui/monitor_controller.rb
    M src/api/app/controllers/webui/package_controller.rb
    M src/api/app/controllers/webui/project_controller.rb
    M src/api/app/controllers/webui/user_controller.rb
    M src/api/app/controllers/webui/webui_controller.rb
    M src/api/app/helpers/webui/project_helper.rb
    A src/api/app/jobs/application_job.rb
    M src/api/app/jobs/cleanup_events.rb
    M src/api/app/jobs/consistency_check.rb
    M src/api/app/jobs/project_create_auto_cleanup_requests.rb
    M src/api/app/jobs/update_package_meta_job.rb
    A src/api/app/models/application_record.rb
    M src/api/app/models/architecture.rb
    M src/api/app/models/attrib.rb
    M src/api/app/models/attrib_allowed_value.rb
    M src/api/app/models/attrib_default_value.rb
    M src/api/app/models/attrib_issue.rb
    M src/api/app/models/attrib_namespace.rb
    M src/api/app/models/attrib_namespace_modifiable_by.rb
    M src/api/app/models/attrib_type.rb
    M src/api/app/models/attrib_type_modifiable_by.rb
    M src/api/app/models/attrib_value.rb
    M src/api/app/models/backend_info.rb
    M src/api/app/models/backend_package.rb
    M src/api/app/models/binary_release.rb
    M src/api/app/models/blacklist_tag.rb
    M src/api/app/models/bs_request.rb
    M src/api/app/models/bs_request_action.rb
    M src/api/app/models/bs_request_action_accept_info.rb
    M src/api/app/models/bs_request_action_maintenance_release.rb
    M src/api/app/models/build_container.rb
    M src/api/app/models/cache_line.rb
    M src/api/app/models/channel.rb
    M src/api/app/models/channel_binary.rb
    M src/api/app/models/channel_binary_list.rb
    M src/api/app/models/channel_target.rb
    M src/api/app/models/comment.rb
    M src/api/app/models/configuration.rb
    M src/api/app/models/distribution.rb
    M src/api/app/models/distribution_icon.rb
    M src/api/app/models/download_repository.rb
    M src/api/app/models/event/base.rb
    M src/api/app/models/event/request.rb
    M src/api/app/models/event_subscription.rb
    M src/api/app/models/flag.rb
    M src/api/app/models/full_text_search.rb
    M src/api/app/models/group.rb
    M src/api/app/models/group_maintainer.rb
    M src/api/app/models/groups_user.rb
    M src/api/app/models/history_element.rb
    M src/api/app/models/incident_updateinfo_counter_value.rb
    M src/api/app/models/issue.rb
    M src/api/app/models/issue_tracker.rb
    M src/api/app/models/linked_project.rb
    M src/api/app/models/maintained_project.rb
    M src/api/app/models/maintenance_incident.rb
    M src/api/app/models/message.rb
    M src/api/app/models/owner.rb
    M src/api/app/models/package.rb
    M src/api/app/models/package_issue.rb
    M src/api/app/models/package_kind.rb
    M src/api/app/models/path_element.rb
    M src/api/app/models/product.rb
    M src/api/app/models/product_medium.rb
    M src/api/app/models/product_update_repository.rb
    M src/api/app/models/project.rb
    M src/api/app/models/project_log_entry.rb
    M src/api/app/models/rating.rb
    M src/api/app/models/relationship.rb
    M src/api/app/models/release_target.rb
    M src/api/app/models/repository.rb
    M src/api/app/models/repository_architecture.rb
    M src/api/app/models/review.rb
    M src/api/app/models/role.rb
    M src/api/app/models/roles_static_permission.rb
    M src/api/app/models/roles_user.rb
    M src/api/app/models/service.rb
    M src/api/app/models/static_permission.rb
    M src/api/app/models/status_history.rb
    M src/api/app/models/status_message.rb
    M src/api/app/models/tag.rb
    M src/api/app/models/tagcloud.rb
    M src/api/app/models/tagging.rb
    M src/api/app/models/token.rb
    M src/api/app/models/update_notification_events.rb
    M src/api/app/models/updateinfo.rb
    M src/api/app/models/updateinfo_counter.rb
    M src/api/app/models/user.rb
    M src/api/app/models/watched_project.rb
    M src/api/app/views/shared/_involved_users.html.erb
    M src/api/app/views/shared/_requests.html.erb
    M src/api/app/views/webui/groups/index.html.erb
    M src/api/app/views/webui/home/index.html.erb
    M src/api/app/views/webui/package/_files_view.html.erb
    M src/api/app/views/webui/project/subprojects.html.haml
    M src/api/app/views/webui/user/index.html.haml
    M src/api/app/views/webui/user/show.html.erb
    M src/api/bin/rails
    M src/api/config/application.rb
    M src/api/config/boot.rb
    A src/api/config/cable.yml
    M src/api/config/database.yml.example
    M src/api/config/deploy.rb
    M src/api/config/environment.rb
    M src/api/config/environments/development.rb
    M src/api/config/environments/production.rb
    M src/api/config/environments/test.rb
    A src/api/config/initializers/application_controller_renderer.rb
    A src/api/config/initializers/assets.rb
    M src/api/config/initializers/backtrace_silencers.rb
    A src/api/config/initializers/cookies_serializer.rb
    A src/api/config/initializers/filter_parameter_logging.rb
    M src/api/config/initializers/inflections.rb
    M src/api/config/initializers/mime_types.rb
    A src/api/config/initializers/new_framework_defaults.rb
    A src/api/config/locales/en.yml
    A src/api/config/puma.rb
    A src/api/config/secrets.yml
    A src/api/config/spring.rb
    M src/api/db/checker.rb
    M src/api/db/migrate/20140908125426_convert_request_history.rb
    M src/api/db/structure.sql
    M src/api/lib/opensuse/backend.rb
    M src/api/lib/opensuse/validator.rb
    M src/api/lib/tasks/capistrano.rake
    M src/api/lib/tasks/test_webui.rake
    M src/api/spec/controllers/webui/monitor_controller_spec.rb
    M src/api/spec/controllers/webui/patchinfo_controller_spec.rb
    M src/api/spec/controllers/webui/project_controller_spec.rb
    M src/api/spec/controllers/webui/user_controller_spec.rb
    M src/api/spec/features/webui/packages_spec.rb
    M src/api/spec/support/shared_examples/features/flags_tables.rb
    A src/api/test/controllers/.keep
    M src/api/test/functional/channel_maintenance_test.rb
    M src/api/test/functional/kgraft_maintenance_test.rb
    M src/api/test/functional/maintenance_test.rb
    M src/api/test/functional/source_controller_test.rb
    M src/api/test/functional/tag_controller_test.rb
    M src/api/test/functional/webui/add_repo_test.rb
    M src/api/test/functional/webui/request_controller_test.rb
    M src/api/test/functional/zzz_post_consistency_test.rb
    A src/api/test/helpers/.keep
    A src/api/test/mailers/.keep
    M src/api/test/test_helper.rb
    M src/api/test/unit/code_quality_test.rb
    M src/api/test/unit/schema_test.rb
    M src/api/test/unit/validator_test.rb

  Log Message:
  -----------
  Merge pull request #2060 from bgeuken/rails5

Update OBS to Rails5

Compare: https://github.com/openSUSE/open-build-service/compare/ebdc6d4de412...3a675e...