Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 62cb9e06f5f72716c5ea794946ce10ff49be3274
https://github.com/openSUSE/open-build-service/commit/62cb9e06f5f72716c5ea79...
Author: Eduardo Navarro
Date: 2019-09-02 (Mon, 02 Sep 2019)
Changed paths:
M src/api/app/helpers/webui/package_helper.rb
M src/api/spec/helpers/webui/package_helper_spec.rb
Log Message:
-----------
Remove package_bread_crumb Bento helper and
... its skipped test.
Now that we are only using the new web interface, we want to get rid
of all the helpers only used with Bento.
Remove also unused repo_type_and_priority helper.
Commit: 98aba5517380266ef1a0f730c189c6c49c32de01
https://github.com/openSUSE/open-build-service/commit/98aba5517380266ef1a0f7...
Author: Eduardo Navarro
Date: 2019-09-02 (Mon, 02 Sep 2019)
Changed paths:
M src/api/app/helpers/webui/package_helper.rb
Log Message:
-----------
Include webui helpers, and not project helpers
As no longer needed Bento helpers were removed from
Webui::PackageHelper, there is no need to include
Webui::ProjectHelper.
We need to include Webui::WebuiHelper, as there are still
helpers from webui that are used in packages views. For example
"elide".
Commit: e87e54d79ce513a28ac081f65d261762a4c14a3a
https://github.com/openSUSE/open-build-service/commit/e87e54d79ce513a28ac081...
Author: Eduardo Navarro
Date: 2019-09-02 (Mon, 02 Sep 2019)
Changed paths:
M src/api/app/helpers/webui/packages/job_history_helper.rb
R src/api/spec/helpers/webui/packages/job_history_helper_spec.rb
Log Message:
-----------
Remove link_to_package_... Bento helper
Now that we are only using the new web interface, we want to get rid
of all the helpers only used with Bento.
Commit: 9e3e1e928fc9995a1e3ae76c87f581af35276e2a
https://github.com/openSUSE/open-build-service/commit/9e3e1e928fc9995a1e3ae7...
Author: Eduardo Navarro
Date: 2019-09-02 (Mon, 02 Sep 2019)
Changed paths:
M src/api/app/helpers/webui/patchinfo_helper.rb
R src/api/spec/helpers/webui/patchinfo_helper_spec.rb
Log Message:
-----------
Remove patchinfo_bread_crumb Bento helper
... and its test.
Now that we are only using the new web interface, we want to get rid
of all the helpers only used with Bento.
Commit: e69b67cd4582f86e5d01ad9cc94cefe3d6e77995
https://github.com/openSUSE/open-build-service/commit/e69b67cd4582f86e5d01ad...
Author: Eduardo Navarro
Date: 2019-09-02 (Mon, 02 Sep 2019)
Changed paths:
M src/api/app/helpers/webui/request_helper.rb
R src/api/app/views/shared/_single_request.html.haml
Log Message:
-----------
Remove helpers only used in an unused partial
As _single_request partial is not used in any part in the code, and the
helpers priority_number and priority_description are only used in this
unused helper, we remove both, the unused partial, and these helpers.
Commit: 8694e2f45cc43e77980643d23de0af504a99051b
https://github.com/openSUSE/open-build-service/commit/8694e2f45cc43e77980643...
Author: Eduardo Navarro
Date: 2019-09-02 (Mon, 02 Sep 2019)
Changed paths:
M src/api/app/helpers/webui/request_helper.rb
Log Message:
-----------
Remove Bento helpers used in requests
Now that we are only using the new web interface, we want to get rid
of all the helpers only used with Bento.
Commit: 3c717c967bcc43aab6f65f6d657819d2d5825e3b
https://github.com/openSUSE/open-build-service/commit/3c717c967bcc43aab6f65f...
Author: Eduardo Navarro
Date: 2019-09-03 (Tue, 03 Sep 2019)
Changed paths:
M src/api/app/helpers/webui/project_helper.rb
M src/api/spec/helpers/webui/project_helper_spec.rb
Log Message:
-----------
Remove Bento helpers for projects
Now that we are only using the new web interface, we want to get rid
of all the helpers only used with Bento.
Remove also unused escape_list helper.
Commit: 6465dde4c1bf1ed8c95537760b838864754048bb
https://github.com/openSUSE/open-build-service/commit/6465dde4c1bf1ed8c95537...
Author: Eduardo Navarro
Date: 2019-09-03 (Tue, 03 Sep 2019)
Changed paths:
M src/api/.rubocop_todo.yml
M src/api/app/helpers/webui/obs_factory/application_helper.rb
M src/api/app/helpers/webui/project_helper.rb
M src/api/spec/helpers/webui/obs_factory/application_helper_spec.rb
M src/api/spec/helpers/webui/project_helper_spec.rb
Log Message:
-----------
Move project_bread_crumb helper to obs_factory
Now that we are only using the new web interface, we want to get rid
of all the helpers only used with Bento.
We still use this helper, only in obs_factory, so we isolate it. This
way we make sure the application is not using this helper, except the
obs_factory part.
An exclude line in the RuboCop TODO file was also added, as now
instance variables are used in this helper.
Commit: b0d448278ff4ce1b998a063af166207d800f1269
https://github.com/openSUSE/open-build-service/commit/b0d448278ff4ce1b998a06...
Author: Henne Vogelsang
Date: 2019-09-03 (Tue, 03 Sep 2019)
Changed paths:
M src/api/.rubocop_todo.yml
M src/api/app/helpers/webui/obs_factory/application_helper.rb
M src/api/app/helpers/webui/package_helper.rb
M src/api/app/helpers/webui/packages/job_history_helper.rb
M src/api/app/helpers/webui/patchinfo_helper.rb
M src/api/app/helpers/webui/project_helper.rb
M src/api/app/helpers/webui/request_helper.rb
M src/api/spec/helpers/webui/obs_factory/application_helper_spec.rb
M src/api/spec/helpers/webui/package_helper_spec.rb
R src/api/spec/helpers/webui/packages/job_history_helper_spec.rb
R src/api/spec/helpers/webui/patchinfo_helper_spec.rb
M src/api/spec/helpers/webui/project_helper_spec.rb
Log Message:
-----------
Merge pull request #8226 from eduardoj/remove_bento_helpers_2
Remove Bento helpers, 2nd part
Compare: https://github.com/openSUSE/open-build-service/compare/5b41a63ad8dc...b0d448...
