[obs-commits] [openSUSE/open-build-service] 716bd9: [frontend] Fix Style/StringLiterals offenses

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 716bd937f6ab7b930b9d022e30f20eb1d3eb604e https://github.com/openSUSE/open-build-service/commit/716bd937f6ab7b930b9d02... Author: David Kang Date: 2017-12-20 (Wed, 20 Dec 2017) Changed paths: M .rubocop_todo.yml M Rakefile M docs/dev/controller_template_example.rb M docs/dev/model_template_example.rb M src/api/Gemfile M src/api/app/controllers/application_controller.rb M src/api/app/controllers/architectures_controller.rb M src/api/app/controllers/attribute_controller.rb M src/api/app/controllers/build/file_controller.rb M src/api/app/controllers/build_controller.rb M src/api/app/controllers/configurations_controller.rb M src/api/app/controllers/distributions_controller.rb M src/api/app/controllers/group_controller.rb M src/api/app/controllers/issue_trackers_controller.rb M src/api/app/controllers/main_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/published_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/search_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/statistics_controller.rb M src/api/app/controllers/test_controller.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/webui/apidocs_controller.rb M src/api/app/controllers/webui/download_on_demand_controller.rb M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/controllers/webui/groups_controller.rb M src/api/app/controllers/webui/main_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/search_controller.rb M src/api/app/controllers/webui/user_controller.rb M src/api/app/controllers/webui/users/rss_tokens_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/model_helper.rb M src/api/app/helpers/public_helper.rb M src/api/app/helpers/webui/buildresult_helper.rb M src/api/app/helpers/webui/monitor_helper.rb M src/api/app/helpers/webui/package_helper.rb M src/api/app/helpers/webui/request_helper.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/indices/package_index.rb M src/api/app/indices/project_index.rb M src/api/app/jobs/accept_requests.rb M src/api/app/jobs/consistency_check_job.rb M src/api/app/jobs/issue_tracker_write_to_backend_job.rb M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/jobs/status_history_rescaler_job.rb M src/api/app/mailers/admin_mailer.rb M src/api/app/mixins/build_log_support.rb M src/api/app/mixins/has_attributes.rb M src/api/app/mixins/parse_package_diff.rb M src/api/app/mixins/request_source_diff.rb M src/api/app/mixins/webui/load_buildresults.rb M src/api/app/models/architecture.rb M src/api/app/models/attrib.rb M src/api/app/models/attrib_namespace.rb M src/api/app/models/attrib_type.rb M src/api/app/models/attrib_value.rb M src/api/app/models/binary_release.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_add_role.rb M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/bs_request_action_maintenance_incident.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/bs_request_action_set_bugowner.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/bs_request_counter.rb M src/api/app/models/bs_request_permission_check.rb M src/api/app/models/buildresult.rb M src/api/app/models/channel.rb M src/api/app/models/channel_binary.rb M src/api/app/models/channel_target.rb M src/api/app/models/comment.rb M src/api/app/models/configuration.rb M src/api/app/models/distribution.rb M src/api/app/models/download_repository.rb M src/api/app/models/event.rb M src/api/app/models/event/factory.rb M src/api/app/models/event/review_wanted.rb M src/api/app/models/flag.rb M src/api/app/models/full_text_search.rb M src/api/app/models/group_maintainer.rb M src/api/app/models/groups_user.rb M src/api/app/models/history_element.rb M src/api/app/models/issue.rb M src/api/app/models/issue_tracker.rb M src/api/app/models/kiwi/image.rb M src/api/app/models/kiwi/image/xml_builder.rb M src/api/app/models/kiwi/image/xml_parser.rb M src/api/app/models/kiwi/repository.rb M src/api/app/models/linked_project.rb M src/api/app/models/maintained_project.rb M src/api/app/models/maintenance_incident.rb M src/api/app/models/message.rb M src/api/app/models/owner.rb M src/api/app/models/package.rb M src/api/app/models/package_build_status.rb M src/api/app/models/package_issue.rb M src/api/app/models/patchinfo.rb M src/api/app/models/product.rb M src/api/app/models/product_medium.rb M src/api/app/models/product_update_repository.rb M src/api/app/models/project.rb M src/api/app/models/project/update_from_xml_command.rb M src/api/app/models/project_log_entry.rb M src/api/app/models/project_status/calculator.rb M src/api/app/models/rating.rb M src/api/app/models/relationship.rb M src/api/app/models/repository.rb M src/api/app/models/review.rb M src/api/app/models/service.rb M src/api/app/models/status_message.rb M src/api/app/models/unregistered_user.rb M src/api/app/models/update_notification_events.rb M src/api/app/models/user.rb M src/api/app/models/user_ldap_strategy.rb M src/api/app/policies/application_policy.rb M src/api/app/policies/comment_policy.rb M src/api/app/views/about/index.xml.builder M src/api/app/views/distributions/index.xml.builder M src/api/app/views/models/_configuration.xml.builder M src/api/app/views/models/_project.xml.builder M src/api/app/views/person/command_token.xml.builder M src/api/app/views/result/packageresult.xml.builder M src/api/app/views/result/projectresult.xml.builder M src/api/app/views/source/package_meta.xml.builder M src/api/app/views/status.xml.builder M src/api/app/views/webui/feeds/commits.atom.builder M src/api/app/views/webui/feeds/notifications.rss.builder M src/api/app/views/webui/main/sitemap_projects.builder M src/api/bin/pry M src/api/bin/rdoc M src/api/bin/ri M src/api/bin/rspec M src/api/bin/rubocop M src/api/config/application.rb M src/api/config/environment.rb M src/api/config/environments/development.rb M src/api/config/environments/production.rb M src/api/config/environments/stage.rb M src/api/config/environments/test.rb M src/api/config/initializers/02_apiversion.rb M src/api/config/initializers/delayed_job_config.rb M src/api/config/initializers/logging.rb M src/api/config/initializers/nokogiri_builder.rb M src/api/config/initializers/secret_token.rb M src/api/config/initializers/wrap_parameters.rb M src/api/config/puma.rb M src/api/config/routes.rb M src/api/db/attribute_descriptions.rb M src/api/db/checker.rb M src/api/db/migrate/001_initial_database.rb M src/api/db/migrate/20140213101042_add_admin_email_configuration.rb M src/api/db/migrate/20140624101042_add_package_tracking.rb M src/api/db/migrate/20140627071042_product_media_tracking.rb M src/api/db/migrate/20140717101042_add_updateinfo_tracking.rb M src/api/db/migrate/20140718112346_flexible_updateinfoid.rb M src/api/db/migrate/20140729101042_updateinfo_tracking_second_attempt.rb M src/api/db/migrate/20140819071042_group_maintainer.rb M src/api/db/migrate/20140827105426_add_index_for_product_tracking.rb M src/api/db/migrate/20140908125426_convert_request_history.rb M src/api/db/migrate/20140908135426_incident_priority_attribute.rb M src/api/db/migrate/20140916135426_project_maintains.rb M src/api/db/migrate/20140930135426_track_product_media_archs.rb M src/api/db/migrate/20141002130129_new_suse_bugzillas.rb M src/api/db/migrate/20141002231042_add_default_tracker_configuration.rb M src/api/db/migrate/20141022105426_add_index_for_history.rb M src/api/db/migrate/20141107135426_embargo_attribute.rb M src/api/db/migrate/20141110105426_fix_product_media_uniq_index.rb M src/api/db/migrate/20141201135426_make_origin_older_attribute.rb M src/api/db/migrate/20150112135426_adapt_cve_tracker.rb M src/api/db/migrate/20150127135426_add_channel_index.rb M src/api/db/migrate/20150129135426_add_roles_users_id.rb M src/api/db/migrate/20150129135427_add_group_requests_id.rb M src/api/db/migrate/20150227063641_add_obs_branch_skip_repositories_attribute.rb M src/api/db/migrate/20150623063641_reindex_sphinx_db.rb M src/api/db/migrate/20150625105426_multiple_incident_counters.rb M src/api/db/migrate/20150716124906_add_type_to_project.rb M src/api/db/migrate/20150807105426_new_dod_table.rb M src/api/db/migrate/20150916084813_add_modify_time_to_binary_release.rb M src/api/db/migrate/20160321085300_add_aarch64_ilp32.rb M src/api/db/migrate/20160321104000_add_k1om.rb M src/api/db/migrate/20160321105300_request_counter.rb M src/api/db/migrate/20160610105300_simplify_user_states.rb M src/api/db/migrate/20160808135426_planned_release_attribute.rb M src/api/db/migrate/20161123124803_image_templates_attribute.rb M src/api/db/migrate/20161124133941_datetime_not_zero_default_null.rb M src/api/db/migrate/20170123115500_remove_duplicate_indexes.rb M src/api/db/migrate/20170821110838_remove_blacklist_tags.rb M src/api/db/migrate/20170821110918_remove_projects_tags.rb M src/api/db/migrate/20170821110941_remove_taggings.rb M src/api/db/migrate/20170821110946_remove_tags.rb M src/api/db/seeds.rb M src/api/lib/activexml/transport.rb M src/api/lib/api_exception.rb M src/api/lib/authenticator.rb M src/api/lib/backend/api/build/project.rb M src/api/lib/backend/api/build_results/binaries.rb M src/api/lib/backend/api/build_results/status.rb M src/api/lib/backend/api/search.rb M src/api/lib/backend/api/server.rb M src/api/lib/backend/api/sources/package.rb M src/api/lib/backend/api/sources/project.rb M src/api/lib/backend/connection.rb M src/api/lib/backend/connection_helper.rb M src/api/lib/backend/logger.rb M src/api/lib/backend/test.rb M src/api/lib/memory_debugger.rb M src/api/lib/obsapi/test_sphinx.rb M src/api/lib/opensuse/permission.rb M src/api/lib/statistics_calculations.rb M src/api/lib/tasks/capistrano.rake M src/api/lib/tasks/cleanup_sessions.rake M src/api/lib/tasks/coverage.rake M src/api/lib/tasks/databases.rake M src/api/lib/tasks/delayed_job.rake M src/api/lib/tasks/dev.rake M src/api/lib/tasks/git_cop.rake M src/api/lib/tasks/history.rake M src/api/lib/tasks/make_user_an_admin.rake M src/api/lib/tasks/project_log_rotate_manually.rake M src/api/lib/tasks/sprites.rake M src/api/lib/tasks/statistics/bs_requests.rake M src/api/lib/tasks/statistics/current.rake M src/api/lib/tasks/statistics/github/code_frequency.rake M src/api/lib/tasks/statistics/github/commit_activity.rake M src/api/lib/tasks/statistics/users.rake M src/api/lib/tasks/test_webui.rake M src/api/lib/xpath_engine.rb M src/api/script/delayed_job_stats.rb M src/api/script/import M src/api/script/reformat_memprof M src/api/script/start_test_backend M src/api/spec/browser_helper.rb M src/api/spec/controllers/group_controller_spec.rb M src/api/spec/controllers/person_controller_spec.rb M src/api/spec/controllers/public_controller_spec.rb M src/api/spec/controllers/source/key_info_controller_controller_spec.rb M src/api/spec/controllers/source_controller_spec.rb M src/api/spec/controllers/webui/apidocs_controller_spec.rb M src/api/spec/controllers/webui/architectures_controller_spec.rb M src/api/spec/controllers/webui/attributes_controller_spec.rb M src/api/spec/controllers/webui/comments_controller_spec.rb M src/api/spec/controllers/webui/download_on_demand_controller_spec.rb M src/api/spec/controllers/webui/feeds_controller_spec.rb M src/api/spec/controllers/webui/groups_controller_spec.rb M src/api/spec/controllers/webui/image_templates_controller_spec.rb M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb M src/api/spec/controllers/webui/main_controller_spec.rb M src/api/spec/controllers/webui/monitor_controller_spec.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/packages/build_reason_controller_spec.rb M src/api/spec/controllers/webui/packages/job_history_controller_spec.rb M src/api/spec/controllers/webui/patchinfo_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/controllers/webui/projects/public_key_controller_spec.rb M src/api/spec/controllers/webui/projects/ssl_certificate_controller_spec.rb M src/api/spec/controllers/webui/repositories_controller_spec.rb M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/controllers/webui/search_controller_spec.rb M src/api/spec/controllers/webui/user_controller_spec.rb M src/api/spec/controllers/webui/users/rss_token_controller_spec.rb M src/api/spec/db/data/convert_notifications_event_payload_to_json_spec.rb M src/api/spec/factories/bs_requests.rb M src/api/spec/factories/distribution.rb M src/api/spec/factories/download_repository_factory.rb M src/api/spec/factories/event_subscriptions.rb M src/api/spec/factories/project.rb M src/api/spec/factories/status_message.rb M src/api/spec/factories/users.rb M src/api/spec/features/webui/attributes_spec.rb M src/api/spec/features/webui/comments_spec.rb M src/api/spec/features/webui/groups_spec.rb M src/api/spec/features/webui/image_templates_spec.rb M src/api/spec/features/webui/login_spec.rb M src/api/spec/features/webui/main_page_spec.rb M src/api/spec/features/webui/maintenance_workflow_spec.rb M src/api/spec/features/webui/packages_spec.rb M src/api/spec/features/webui/projects_spec.rb M src/api/spec/features/webui/repositories_spec.rb M src/api/spec/features/webui/requests_spec.rb M src/api/spec/features/webui/search_spec.rb M src/api/spec/features/webui/sign_up_spec.rb M src/api/spec/features/webui/users/user_admin_edit_spec.rb M src/api/spec/features/webui/users/user_home_page_spec.rb M src/api/spec/features/webui/users/users_home_project_spec.rb M src/api/spec/features/webui/users/users_icons_spec.rb M src/api/spec/features/webui/users/users_notifications_settings_spec.rb M src/api/spec/features/webui/watchlists_spec.rb M src/api/spec/helpers/event_mailer_helper_spec.rb M src/api/spec/helpers/validation_helper_spec.rb M src/api/spec/helpers/webui/build_result_helper.rb M src/api/spec/helpers/webui/flash_helper_spec.rb M src/api/spec/helpers/webui/package_helper_spec.rb M src/api/spec/helpers/webui/packages/job_history_helper_spec.rb M src/api/spec/helpers/webui/patchinfo_helper_spec.rb M src/api/spec/helpers/webui/request_helper_spec.rb M src/api/spec/helpers/webui/webui_helper_spec.rb M src/api/spec/jobs/issue_tracker_write_to_backend_job_spec.rb M src/api/spec/jobs/update_released_binaries_job_spec.rb M src/api/spec/lib/authenticator_spec.rb M src/api/spec/lib/backend/connection_helper_spec.rb M src/api/spec/lib/statistics_calculations_spec.rb M src/api/spec/mixins/build_log_support_spec.rb M src/api/spec/mixins/parse_package_diff_spec.rb M src/api/spec/models/attrib_spec.rb M src/api/spec/models/backend/file_spec.rb M src/api/spec/models/branch_package_spec.rb M src/api/spec/models/bs_request_spec.rb M src/api/spec/models/buildresult_spec.rb M src/api/spec/models/comment_spec.rb M src/api/spec/models/download_repository_spec.rb M src/api/spec/models/image_template_spec.rb M src/api/spec/models/kiwi/image_spec.rb M src/api/spec/models/kiwi/repository_spec.rb M src/api/spec/models/notification/rss_feed_item_spec.rb M src/api/spec/models/notification_spec.rb M src/api/spec/models/package_spec.rb M src/api/spec/models/project/update_from_xml_command_spec.rb M src/api/spec/models/project_spec.rb M src/api/spec/models/repository_spec.rb M src/api/spec/models/role_spec.rb M src/api/spec/models/user_ldap_strategy_spec.rb M src/api/spec/models/user_spec.rb M src/api/spec/nyan_unicorn_formatter.rb M src/api/spec/policies/comment_policy_spec.rb M src/api/spec/requests/kerberos_login_spec.rb M src/api/spec/requests/webui/apidocs_spec.rb M src/api/spec/routing/api_matcher_spec.rb M src/api/spec/script/db_checker.rb M src/api/spec/spec_helper.rb M src/api/spec/support/features/features_authentification.rb M src/api/spec/support/shared_contexts/a_set_of_bs_requests.rb M src/api/spec/support/shared_examples/features/flags_tables.rb M src/api/spec/support/shared_examples/features/user_tab.rb M src/api/test/activexml_matcher.rb M src/api/test/functional/aaa_pre_consistency_test.rb M src/api/test/functional/about_controller_test.rb M src/api/test/functional/architectures_controller_test.rb M src/api/test/functional/attributes_test.rb M src/api/test/functional/backend_test.rb M src/api/test/functional/binary_release_test.rb M src/api/test/functional/branch_publish_flag_test.rb M src/api/test/functional/build_controller_test.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/comments_controller_test.rb M src/api/test/functional/configurations_controller_test.rb M src/api/test/functional/cross_build_test.rb M src/api/test/functional/distributions_controller_test.rb M src/api/test/functional/group_request_test.rb M src/api/test/functional/group_test.rb M src/api/test/functional/interconnect_test.rb M src/api/test/functional/issue_controller_test.rb M src/api/test/functional/issue_trackers_controller_test.rb M src/api/test/functional/kgraft_maintenance_test.rb M src/api/test/functional/main_controller_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/person_controller_test.rb M src/api/test/functional/product_test.rb M src/api/test/functional/public_controller_test.rb M src/api/test/functional/published_controller_test.rb M src/api/test/functional/read_permission_test.rb M src/api/test/functional/release_management_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/request_events_test.rb M src/api/test/functional/search_controller_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/source_services_test.rb M src/api/test/functional/statistics_controller_test.rb M src/api/test/functional/status_controller_test.rb M src/api/test/functional/zzz_post_consistency_test.rb M src/api/test/integration/last_events_test.rb M src/api/test/models/backend_info_test.rb M src/api/test/models/full_text_search_test.rb M src/api/test/models/project_log_entry_test.rb M src/api/test/models/status_history_test.rb M src/api/test/test_consistency_helper.rb M src/api/test/test_helper.rb M src/api/test/unit/attrib_test.rb M src/api/test/unit/attribute_test.rb M src/api/test/unit/binary_release.rb M src/api/test/unit/bs_request_test.rb M src/api/test/unit/build_flag_test.rb M src/api/test/unit/channel_test.rb M src/api/test/unit/comment_test.rb M src/api/test/unit/debug_flag_test.rb M src/api/test/unit/event_mailer_test.rb M src/api/test/unit/flag_test.rb M src/api/test/unit/groups_users_test.rb M src/api/test/unit/history_test.rb M src/api/test/unit/ichain_notifier_test.rb M src/api/test/unit/issue_test.rb M src/api/test/unit/linked_project_test.rb M src/api/test/unit/package_group_role_relationship_test.rb M src/api/test/unit/package_remove_test.rb M src/api/test/unit/package_test.rb M src/api/test/unit/patchinfo_test.rb M src/api/test/unit/product_test.rb M src/api/test/unit/project_remove_test.rb M src/api/test/unit/project_test.rb M src/api/test/unit/publish_flag_test.rb M src/api/test/unit/role_test.rb M src/api/test/unit/status_helper_test.rb M src/api/test/unit/status_message_test.rb M src/api/test/unit/user_ldap_strategy_test.rb M src/api/test/unit/user_test.rb M src/api/test/unit/validator_test.rb M src/api/test/unit/watched_project_test.rb M src/api/test/unit/worker_status_test.rb Log Message: ----------- [frontend] Fix Style/StringLiterals offenses Pair-programming with: @bgeuken Commit: 2f66b8a6ffd12470b68cddf132303f668975a50a https://github.com/openSUSE/open-build-service/commit/2f66b8a6ffd12470b68cdd... Author: Moisés Déniz Alemán Date: 2017-12-20 (Wed, 20 Dec 2017) Changed paths: M .rubocop_todo.yml M Rakefile M docs/dev/controller_template_example.rb M docs/dev/model_template_example.rb M src/api/Gemfile M src/api/app/controllers/application_controller.rb M src/api/app/controllers/architectures_controller.rb M src/api/app/controllers/attribute_controller.rb M src/api/app/controllers/build/file_controller.rb M src/api/app/controllers/build_controller.rb M src/api/app/controllers/configurations_controller.rb M src/api/app/controllers/distributions_controller.rb M src/api/app/controllers/group_controller.rb M src/api/app/controllers/issue_trackers_controller.rb M src/api/app/controllers/main_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/published_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/search_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/statistics_controller.rb M src/api/app/controllers/test_controller.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/webui/apidocs_controller.rb M src/api/app/controllers/webui/download_on_demand_controller.rb M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/controllers/webui/groups_controller.rb M src/api/app/controllers/webui/main_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/search_controller.rb M src/api/app/controllers/webui/user_controller.rb M src/api/app/controllers/webui/users/rss_tokens_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/model_helper.rb M src/api/app/helpers/public_helper.rb M src/api/app/helpers/webui/buildresult_helper.rb M src/api/app/helpers/webui/monitor_helper.rb M src/api/app/helpers/webui/package_helper.rb M src/api/app/helpers/webui/request_helper.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/indices/package_index.rb M src/api/app/indices/project_index.rb M src/api/app/jobs/accept_requests.rb M src/api/app/jobs/consistency_check_job.rb M src/api/app/jobs/issue_tracker_write_to_backend_job.rb M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/jobs/status_history_rescaler_job.rb M src/api/app/mailers/admin_mailer.rb M src/api/app/mixins/build_log_support.rb M src/api/app/mixins/has_attributes.rb M src/api/app/mixins/parse_package_diff.rb M src/api/app/mixins/request_source_diff.rb M src/api/app/mixins/webui/load_buildresults.rb M src/api/app/models/architecture.rb M src/api/app/models/attrib.rb M src/api/app/models/attrib_namespace.rb M src/api/app/models/attrib_type.rb M src/api/app/models/attrib_value.rb M src/api/app/models/binary_release.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_add_role.rb M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/bs_request_action_maintenance_incident.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/bs_request_action_set_bugowner.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/bs_request_counter.rb M src/api/app/models/bs_request_permission_check.rb M src/api/app/models/buildresult.rb M src/api/app/models/channel.rb M src/api/app/models/channel_binary.rb M src/api/app/models/channel_target.rb M src/api/app/models/comment.rb M src/api/app/models/configuration.rb M src/api/app/models/distribution.rb M src/api/app/models/download_repository.rb M src/api/app/models/event.rb M src/api/app/models/event/factory.rb M src/api/app/models/event/review_wanted.rb M src/api/app/models/flag.rb M src/api/app/models/full_text_search.rb M src/api/app/models/group_maintainer.rb M src/api/app/models/groups_user.rb M src/api/app/models/history_element.rb M src/api/app/models/issue.rb M src/api/app/models/issue_tracker.rb M src/api/app/models/kiwi/image.rb M src/api/app/models/kiwi/image/xml_builder.rb M src/api/app/models/kiwi/image/xml_parser.rb M src/api/app/models/kiwi/repository.rb M src/api/app/models/linked_project.rb M src/api/app/models/maintained_project.rb M src/api/app/models/maintenance_incident.rb M src/api/app/models/message.rb M src/api/app/models/owner.rb M src/api/app/models/package.rb M src/api/app/models/package_build_status.rb M src/api/app/models/package_issue.rb M src/api/app/models/patchinfo.rb M src/api/app/models/product.rb M src/api/app/models/product_medium.rb M src/api/app/models/product_update_repository.rb M src/api/app/models/project.rb M src/api/app/models/project/update_from_xml_command.rb M src/api/app/models/project_log_entry.rb M src/api/app/models/project_status/calculator.rb M src/api/app/models/rating.rb M src/api/app/models/relationship.rb M src/api/app/models/repository.rb M src/api/app/models/review.rb M src/api/app/models/service.rb M src/api/app/models/status_message.rb M src/api/app/models/unregistered_user.rb M src/api/app/models/update_notification_events.rb M src/api/app/models/user.rb M src/api/app/models/user_ldap_strategy.rb M src/api/app/policies/application_policy.rb M src/api/app/policies/comment_policy.rb M src/api/app/views/about/index.xml.builder M src/api/app/views/distributions/index.xml.builder M src/api/app/views/models/_configuration.xml.builder M src/api/app/views/models/_project.xml.builder M src/api/app/views/person/command_token.xml.builder M src/api/app/views/result/packageresult.xml.builder M src/api/app/views/result/projectresult.xml.builder M src/api/app/views/source/package_meta.xml.builder M src/api/app/views/status.xml.builder M src/api/app/views/webui/feeds/commits.atom.builder M src/api/app/views/webui/feeds/notifications.rss.builder M src/api/app/views/webui/main/sitemap_projects.builder M src/api/bin/pry M src/api/bin/rdoc M src/api/bin/ri M src/api/bin/rspec M src/api/bin/rubocop M src/api/config/application.rb M src/api/config/environment.rb M src/api/config/environments/development.rb M src/api/config/environments/production.rb M src/api/config/environments/stage.rb M src/api/config/environments/test.rb M src/api/config/initializers/02_apiversion.rb M src/api/config/initializers/delayed_job_config.rb M src/api/config/initializers/logging.rb M src/api/config/initializers/nokogiri_builder.rb M src/api/config/initializers/secret_token.rb M src/api/config/initializers/wrap_parameters.rb M src/api/config/puma.rb M src/api/config/routes.rb M src/api/db/attribute_descriptions.rb M src/api/db/checker.rb M src/api/db/migrate/001_initial_database.rb M src/api/db/migrate/20140213101042_add_admin_email_configuration.rb M src/api/db/migrate/20140624101042_add_package_tracking.rb M src/api/db/migrate/20140627071042_product_media_tracking.rb M src/api/db/migrate/20140717101042_add_updateinfo_tracking.rb M src/api/db/migrate/20140718112346_flexible_updateinfoid.rb M src/api/db/migrate/20140729101042_updateinfo_tracking_second_attempt.rb M src/api/db/migrate/20140819071042_group_maintainer.rb M src/api/db/migrate/20140827105426_add_index_for_product_tracking.rb M src/api/db/migrate/20140908125426_convert_request_history.rb M src/api/db/migrate/20140908135426_incident_priority_attribute.rb M src/api/db/migrate/20140916135426_project_maintains.rb M src/api/db/migrate/20140930135426_track_product_media_archs.rb M src/api/db/migrate/20141002130129_new_suse_bugzillas.rb M src/api/db/migrate/20141002231042_add_default_tracker_configuration.rb M src/api/db/migrate/20141022105426_add_index_for_history.rb M src/api/db/migrate/20141107135426_embargo_attribute.rb M src/api/db/migrate/20141110105426_fix_product_media_uniq_index.rb M src/api/db/migrate/20141201135426_make_origin_older_attribute.rb M src/api/db/migrate/20150112135426_adapt_cve_tracker.rb M src/api/db/migrate/20150127135426_add_channel_index.rb M src/api/db/migrate/20150129135426_add_roles_users_id.rb M src/api/db/migrate/20150129135427_add_group_requests_id.rb M src/api/db/migrate/20150227063641_add_obs_branch_skip_repositories_attribute.rb M src/api/db/migrate/20150623063641_reindex_sphinx_db.rb M src/api/db/migrate/20150625105426_multiple_incident_counters.rb M src/api/db/migrate/20150716124906_add_type_to_project.rb M src/api/db/migrate/20150807105426_new_dod_table.rb M src/api/db/migrate/20150916084813_add_modify_time_to_binary_release.rb M src/api/db/migrate/20160321085300_add_aarch64_ilp32.rb M src/api/db/migrate/20160321104000_add_k1om.rb M src/api/db/migrate/20160321105300_request_counter.rb M src/api/db/migrate/20160610105300_simplify_user_states.rb M src/api/db/migrate/20160808135426_planned_release_attribute.rb M src/api/db/migrate/20161123124803_image_templates_attribute.rb M src/api/db/migrate/20161124133941_datetime_not_zero_default_null.rb M src/api/db/migrate/20170123115500_remove_duplicate_indexes.rb M src/api/db/migrate/20170821110838_remove_blacklist_tags.rb M src/api/db/migrate/20170821110918_remove_projects_tags.rb M src/api/db/migrate/20170821110941_remove_taggings.rb M src/api/db/migrate/20170821110946_remove_tags.rb M src/api/db/seeds.rb M src/api/lib/activexml/transport.rb M src/api/lib/api_exception.rb M src/api/lib/authenticator.rb M src/api/lib/backend/api/build/project.rb M src/api/lib/backend/api/build_results/binaries.rb M src/api/lib/backend/api/build_results/status.rb M src/api/lib/backend/api/search.rb M src/api/lib/backend/api/server.rb M src/api/lib/backend/api/sources/package.rb M src/api/lib/backend/api/sources/project.rb M src/api/lib/backend/connection.rb M src/api/lib/backend/connection_helper.rb M src/api/lib/backend/logger.rb M src/api/lib/backend/test.rb M src/api/lib/memory_debugger.rb M src/api/lib/obsapi/test_sphinx.rb M src/api/lib/opensuse/permission.rb M src/api/lib/statistics_calculations.rb M src/api/lib/tasks/capistrano.rake M src/api/lib/tasks/cleanup_sessions.rake M src/api/lib/tasks/coverage.rake M src/api/lib/tasks/databases.rake M src/api/lib/tasks/delayed_job.rake M src/api/lib/tasks/dev.rake M src/api/lib/tasks/git_cop.rake M src/api/lib/tasks/history.rake M src/api/lib/tasks/make_user_an_admin.rake M src/api/lib/tasks/project_log_rotate_manually.rake M src/api/lib/tasks/sprites.rake M src/api/lib/tasks/statistics/bs_requests.rake M src/api/lib/tasks/statistics/current.rake M src/api/lib/tasks/statistics/github/code_frequency.rake M src/api/lib/tasks/statistics/github/commit_activity.rake M src/api/lib/tasks/statistics/users.rake M src/api/lib/tasks/test_webui.rake M src/api/lib/xpath_engine.rb M src/api/script/delayed_job_stats.rb M src/api/script/import M src/api/script/reformat_memprof M src/api/script/start_test_backend M src/api/spec/browser_helper.rb M src/api/spec/controllers/group_controller_spec.rb M src/api/spec/controllers/person_controller_spec.rb M src/api/spec/controllers/public_controller_spec.rb M src/api/spec/controllers/source/key_info_controller_controller_spec.rb M src/api/spec/controllers/source_controller_spec.rb M src/api/spec/controllers/webui/apidocs_controller_spec.rb M src/api/spec/controllers/webui/architectures_controller_spec.rb M src/api/spec/controllers/webui/attributes_controller_spec.rb M src/api/spec/controllers/webui/comments_controller_spec.rb M src/api/spec/controllers/webui/download_on_demand_controller_spec.rb M src/api/spec/controllers/webui/feeds_controller_spec.rb M src/api/spec/controllers/webui/groups_controller_spec.rb M src/api/spec/controllers/webui/image_templates_controller_spec.rb M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb M src/api/spec/controllers/webui/main_controller_spec.rb M src/api/spec/controllers/webui/monitor_controller_spec.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/packages/build_reason_controller_spec.rb M src/api/spec/controllers/webui/packages/job_history_controller_spec.rb M src/api/spec/controllers/webui/patchinfo_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/controllers/webui/projects/public_key_controller_spec.rb M src/api/spec/controllers/webui/projects/ssl_certificate_controller_spec.rb M src/api/spec/controllers/webui/repositories_controller_spec.rb M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/controllers/webui/search_controller_spec.rb M src/api/spec/controllers/webui/user_controller_spec.rb M src/api/spec/controllers/webui/users/rss_token_controller_spec.rb M src/api/spec/db/data/convert_notifications_event_payload_to_json_spec.rb M src/api/spec/factories/bs_requests.rb M src/api/spec/factories/distribution.rb M src/api/spec/factories/download_repository_factory.rb M src/api/spec/factories/event_subscriptions.rb M src/api/spec/factories/project.rb M src/api/spec/factories/status_message.rb M src/api/spec/factories/users.rb M src/api/spec/features/webui/attributes_spec.rb M src/api/spec/features/webui/comments_spec.rb M src/api/spec/features/webui/groups_spec.rb M src/api/spec/features/webui/image_templates_spec.rb M src/api/spec/features/webui/login_spec.rb M src/api/spec/features/webui/main_page_spec.rb M src/api/spec/features/webui/maintenance_workflow_spec.rb M src/api/spec/features/webui/packages_spec.rb M src/api/spec/features/webui/projects_spec.rb M src/api/spec/features/webui/repositories_spec.rb M src/api/spec/features/webui/requests_spec.rb M src/api/spec/features/webui/search_spec.rb M src/api/spec/features/webui/sign_up_spec.rb M src/api/spec/features/webui/users/user_admin_edit_spec.rb M src/api/spec/features/webui/users/user_home_page_spec.rb M src/api/spec/features/webui/users/users_home_project_spec.rb M src/api/spec/features/webui/users/users_icons_spec.rb M src/api/spec/features/webui/users/users_notifications_settings_spec.rb M src/api/spec/features/webui/watchlists_spec.rb M src/api/spec/helpers/event_mailer_helper_spec.rb M src/api/spec/helpers/validation_helper_spec.rb M src/api/spec/helpers/webui/build_result_helper.rb M src/api/spec/helpers/webui/flash_helper_spec.rb M src/api/spec/helpers/webui/package_helper_spec.rb M src/api/spec/helpers/webui/packages/job_history_helper_spec.rb M src/api/spec/helpers/webui/patchinfo_helper_spec.rb M src/api/spec/helpers/webui/request_helper_spec.rb M src/api/spec/helpers/webui/webui_helper_spec.rb M src/api/spec/jobs/issue_tracker_write_to_backend_job_spec.rb M src/api/spec/jobs/update_released_binaries_job_spec.rb M src/api/spec/lib/authenticator_spec.rb M src/api/spec/lib/backend/connection_helper_spec.rb M src/api/spec/lib/statistics_calculations_spec.rb M src/api/spec/mixins/build_log_support_spec.rb M src/api/spec/mixins/parse_package_diff_spec.rb M src/api/spec/models/attrib_spec.rb M src/api/spec/models/backend/file_spec.rb M src/api/spec/models/branch_package_spec.rb M src/api/spec/models/bs_request_spec.rb M src/api/spec/models/buildresult_spec.rb M src/api/spec/models/comment_spec.rb M src/api/spec/models/download_repository_spec.rb M src/api/spec/models/image_template_spec.rb M src/api/spec/models/kiwi/image_spec.rb M src/api/spec/models/kiwi/repository_spec.rb M src/api/spec/models/notification/rss_feed_item_spec.rb M src/api/spec/models/notification_spec.rb M src/api/spec/models/package_spec.rb M src/api/spec/models/project/update_from_xml_command_spec.rb M src/api/spec/models/project_spec.rb M src/api/spec/models/repository_spec.rb M src/api/spec/models/role_spec.rb M src/api/spec/models/user_ldap_strategy_spec.rb M src/api/spec/models/user_spec.rb M src/api/spec/nyan_unicorn_formatter.rb M src/api/spec/policies/comment_policy_spec.rb M src/api/spec/requests/kerberos_login_spec.rb M src/api/spec/requests/webui/apidocs_spec.rb M src/api/spec/routing/api_matcher_spec.rb M src/api/spec/script/db_checker.rb M src/api/spec/spec_helper.rb M src/api/spec/support/features/features_authentification.rb M src/api/spec/support/shared_contexts/a_set_of_bs_requests.rb M src/api/spec/support/shared_examples/features/flags_tables.rb M src/api/spec/support/shared_examples/features/user_tab.rb M src/api/test/activexml_matcher.rb M src/api/test/functional/aaa_pre_consistency_test.rb M src/api/test/functional/about_controller_test.rb M src/api/test/functional/architectures_controller_test.rb M src/api/test/functional/attributes_test.rb M src/api/test/functional/backend_test.rb M src/api/test/functional/binary_release_test.rb M src/api/test/functional/branch_publish_flag_test.rb M src/api/test/functional/build_controller_test.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/comments_controller_test.rb M src/api/test/functional/configurations_controller_test.rb M src/api/test/functional/cross_build_test.rb M src/api/test/functional/distributions_controller_test.rb M src/api/test/functional/group_request_test.rb M src/api/test/functional/group_test.rb M src/api/test/functional/interconnect_test.rb M src/api/test/functional/issue_controller_test.rb M src/api/test/functional/issue_trackers_controller_test.rb M src/api/test/functional/kgraft_maintenance_test.rb M src/api/test/functional/main_controller_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/person_controller_test.rb M src/api/test/functional/product_test.rb M src/api/test/functional/public_controller_test.rb M src/api/test/functional/published_controller_test.rb M src/api/test/functional/read_permission_test.rb M src/api/test/functional/release_management_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/request_events_test.rb M src/api/test/functional/search_controller_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/source_services_test.rb M src/api/test/functional/statistics_controller_test.rb M src/api/test/functional/status_controller_test.rb M src/api/test/functional/zzz_post_consistency_test.rb M src/api/test/integration/last_events_test.rb M src/api/test/models/backend_info_test.rb M src/api/test/models/full_text_search_test.rb M src/api/test/models/project_log_entry_test.rb M src/api/test/models/status_history_test.rb M src/api/test/test_consistency_helper.rb M src/api/test/test_helper.rb M src/api/test/unit/attrib_test.rb M src/api/test/unit/attribute_test.rb M src/api/test/unit/binary_release.rb M src/api/test/unit/bs_request_test.rb M src/api/test/unit/build_flag_test.rb M src/api/test/unit/channel_test.rb M src/api/test/unit/comment_test.rb M src/api/test/unit/debug_flag_test.rb M src/api/test/unit/event_mailer_test.rb M src/api/test/unit/flag_test.rb M src/api/test/unit/groups_users_test.rb M src/api/test/unit/history_test.rb M src/api/test/unit/ichain_notifier_test.rb M src/api/test/unit/issue_test.rb M src/api/test/unit/linked_project_test.rb M src/api/test/unit/package_group_role_relationship_test.rb M src/api/test/unit/package_remove_test.rb M src/api/test/unit/package_test.rb M src/api/test/unit/patchinfo_test.rb M src/api/test/unit/product_test.rb M src/api/test/unit/project_remove_test.rb M src/api/test/unit/project_test.rb M src/api/test/unit/publish_flag_test.rb M src/api/test/unit/role_test.rb M src/api/test/unit/status_helper_test.rb M src/api/test/unit/status_message_test.rb M src/api/test/unit/user_ldap_strategy_test.rb M src/api/test/unit/user_test.rb M src/api/test/unit/validator_test.rb M src/api/test/unit/watched_project_test.rb M src/api/test/unit/worker_status_test.rb Log Message: ----------- Merge pull request #4257 from DavidKang/feature/rubocop/string Rubocop is really your friend Compare: https://github.com/openSUSE/open-build-service/compare/a1a328692b9c...2f66b8...