Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 1f6371e1d2e5148c65d0b7ab7b237aedb33de964
https://github.com/openSUSE/open-build-service/commit/1f6371e1d2e5148c65d0b7...
Author: Ana María Martínez Gómez
Date: 2016-11-08 (Tue, 08 Nov 2016)
Changed paths:
M src/api/.rubocop.yml
M src/api/.rubocop_todo.yml
M src/api/app/controllers/attribute_controller.rb
M src/api/app/controllers/source_controller.rb
M src/api/app/jobs/consistency_check.rb
M src/api/app/models/attrib.rb
M src/api/app/models/binary_release.rb
M src/api/app/models/branch_package.rb
M src/api/app/models/bs_request.rb
M src/api/app/models/bs_request_action.rb
M src/api/app/models/event_find_subscribers.rb
M src/api/app/models/flag.rb
M src/api/app/models/group_maintainer.rb
M src/api/app/models/groups_user.rb
M src/api/app/models/incident_updateinfo_counter_value.rb
M src/api/app/models/linked_project.rb
M src/api/app/models/owner.rb
M src/api/app/models/package.rb
M src/api/app/models/project.rb
M src/api/app/models/repository.rb
M src/api/app/models/tag.rb
M src/api/app/models/updateinfo_counter.rb
M src/api/app/models/user.rb
Log Message:
-----------
[api] Enable the Rails/FindBy cop in Rubocop
Note that where(..).first is not exactly the same as find_by(...) as
they order records differently, so the "first" record can be different.
Because of this reason the Rubocop autocorrect option doesn't work and
all the changes were done manually.
Commit: 17b41719f7d37b324cc6c3dc5692c6fc62a3b674
https://github.com/openSUSE/open-build-service/commit/17b41719f7d37b324cc6c3...
Author: Ana María Martínez Gómez
Date: 2016-11-08 (Tue, 08 Nov 2016)
Changed paths:
M src/api/app/models/updateinfo_counter.rb
Log Message:
-----------
[api] Refactor UpdateinfoCounter#find_or_create
Commit: 3271934e216593ddaf2f3576a125abdb3d707d6c
https://github.com/openSUSE/open-build-service/commit/3271934e216593ddaf2f35...
Author: Björn Geuken
Date: 2016-11-08 (Tue, 08 Nov 2016)
Changed paths:
M src/api/.rubocop.yml
M src/api/.rubocop_todo.yml
M src/api/app/controllers/attribute_controller.rb
M src/api/app/controllers/source_controller.rb
M src/api/app/jobs/consistency_check.rb
M src/api/app/models/attrib.rb
M src/api/app/models/binary_release.rb
M src/api/app/models/branch_package.rb
M src/api/app/models/bs_request.rb
M src/api/app/models/bs_request_action.rb
M src/api/app/models/event_find_subscribers.rb
M src/api/app/models/flag.rb
M src/api/app/models/group_maintainer.rb
M src/api/app/models/groups_user.rb
M src/api/app/models/incident_updateinfo_counter_value.rb
M src/api/app/models/linked_project.rb
M src/api/app/models/owner.rb
M src/api/app/models/package.rb
M src/api/app/models/project.rb
M src/api/app/models/repository.rb
M src/api/app/models/tag.rb
M src/api/app/models/updateinfo_counter.rb
M src/api/app/models/user.rb
Log Message:
-----------
Merge pull request #2298 from Ana06/rubocop-findby
Enable the Rails/FindBy cop in Rubocop && Refactor UpdateinfoCounter#find_or_create
Compare: https://github.com/openSUSE/open-build-service/compare/775c785e413c...327193...