Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 5b84009e99881044b148e549814663ab7ec862b3
https://github.com/openSUSE/open-build-service/commit/5b84009e99881044b148e5...
Author: Henne Vogelsang
Date: 2020-08-13 (Thu, 13 Aug 2020)
Changed paths:
M src/api/app/lib/backend/api/sources/package.rb
M src/api/app/models/bs_request_action.rb
M src/api/app/models/bs_request_action/differ/for_source.rb
Log Message:
-----------
Speed up request creation
by avoiding generating large diff without any consumer.
The frontend should not overwrite backend defaults in general.
It may make sense to do it for specific views.
Co-authored-by: Adrian Schröter
Commit: c5f18868a9f3e8bb4cef62ad88c28d75b03381ad
https://github.com/openSUSE/open-build-service/commit/c5f18868a9f3e8bb4cef62...
Author: Henne Vogelsang
Date: 2020-08-13 (Thu, 13 Aug 2020)
Changed paths:
M src/api/spec/cassettes/BackfillNotifiedProjects/up/backfills_the_notifications_projects_table_with_all_projects_from_existing_notifications.yml
M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/not_setting_a_target_package/creates_a_BsRequest_with_the_source_package_name.yml
M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/prefill_form_for_a_branched_package/fills_in_the_submission_reasons_and_creates_a_BsRequest.yml
M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/setting_a_target_package/creates_a_BsRequest_with_target_package_name.yml
M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/supersede_a_request/creates_a_BsRequest_and_supersede_only_the_selected_request_s_.yml
R src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/raises_exception_on_missing_by__paramter.yml
R src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/raises_exception_on_wrong_user.yml
R src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/with_the_proper_reviewer/moves_to_new.yml
R src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/with_the_proper_reviewer/sends_3_events.yml
R src/api/spec/cassettes/BsRequest/_changestate/when_bs_request_is_staged/1_6_4_1.yml
M src/api/spec/cassettes/BsRequest/_changestate/when_bs_request_is_staged/when_a_staged_bs_request_is_accepted/1_6_4_2_1.yml
R src/api/spec/cassettes/BsRequest/_delayed_auto_accept/1_8_1.yml
R src/api/spec/cassettes/BsRequest/_delayed_auto_accept/1_8_2.yml
M src/api/spec/cassettes/BsRequest/_forward_to/only_forwards_submit_requests.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/creates_a_new_submit_request_open_for_review.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/creates_a_submit_request_action_with_the_correct_target.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/does_not_set_the_sourceupdate.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/sets_the_logged_in_user_as_creator_of_the_request.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_options/creates_a_submit_request_action_with_the_correct_target.yml
R src/api/spec/cassettes/BsRequest/_forward_to/with_options/does_not_copy_the_sourceupdate_attribute.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_options/sets_the_given_description.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_project_and_package_as_parameter/creates_a_submit_request_action_with_the_correct_target.yml
M src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_creator_doesn_t_have_permissions_for_the_target_project/1_9_2_3_1.yml
M src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_the_request_is_pending/1_9_2_1_1.yml
M src/api/spec/cassettes/BsRequest/auto_accept/_delayed_auto_accept/1_9_1_1.yml
M src/api/spec/cassettes/BsRequest/auto_accept/_delayed_auto_accept/1_9_1_2.yml
R src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set/1_11_1_4_1.yml
M src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set/1_12_1_4_1.yml
R src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_cleanup/1_11_1_1_1.yml
M src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_cleanup/1_12_1_1_1.yml
R src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_update/1_11_1_2_1.yml
M src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_update/1_12_1_2_1.yml
R src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_set_to_noupdate/1_11_1_3_1.yml
M src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_set_to_noupdate/1_12_1_3_1.yml
R src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new_from_xml/1_11_2_1.yml
M src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new_from_xml/1_12_2_1.yml
M src/api/spec/cassettes/BsRequestAction/create_expand_package/Everything_should_work/1_8_2_1.yml
M src/api/spec/cassettes/BsRequestAction/create_expand_package/Should_return_an_array/1_8_3_1.yml
M src/api/spec/cassettes/MaintenanceWorkflow/maintenance_workflow.yml
M src/api/spec/cassettes/RequestController/_global_command_cmd_create_/requesting_creation_of_a_source_project_that_has_a_project_link_that_is_not_owned_by_the_requester/prohibits_creation_of_request.yml
M src/api/spec/cassettes/Webui_RequestController/POST_changerequest/with_valid_parameters/forwards.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/having_whitespaces_in_parameters/behaves_like_a_response_of_a_successful_submit_request/1_1_5_1_1.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/having_whitespaces_in_parameters/behaves_like_a_response_of_a_successful_submit_request/1_1_5_1_2.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/sending_a_submit_request_for_an_older_submission/behaves_like_a_response_of_a_successful_submit_request/1_1_6_1_1.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/sending_a_submit_request_for_an_older_submission/behaves_like_a_response_of_a_successful_submit_request/1_1_6_1_2.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/sending_a_submit_request_for_an_older_submission/creates_a_submit_request_for_the_correct_revision.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/unchanged_sources/1_1_9_1.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/unchanged_sources/1_1_9_2.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/unchanged_sources/1_1_9_3.yml
M src/api/spec/factories/project.rb
M src/api/spec/models/bs_request_spec.rb
Log Message:
-----------
Adopt Request specs to backend changes
In 5b84009e99881044b148e549814663ab7ec862b3 we introduced a new
parameter for many backend diff requests. Adopt the request specs
to it.
Commit: e88af6f5541942aa4fa20927506332150e7b8456
https://github.com/openSUSE/open-build-service/commit/e88af6f5541942aa4fa209...
Author: Henne Vogelsang
Date: 2020-08-13 (Thu, 13 Aug 2020)
Changed paths:
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/gets_delivered.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/has_a_subject.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/has_custom_headers.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/has_subscribers.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/has_the_default_headers.yml
A src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/renders_links_absolute.yml
A src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/when_comment_contains_emoji/1_1_2_8_1.yml
A src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/when_comment_contains_emoji/1_1_2_8_2.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/when_originator_is_subscribed/does_not_send_to_the_originator.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_Request/uses_default_for_FROM_if_display_name_does_not_exist.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_Request/uses_display_name_for_FROM_if_originator_exists.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_Request/when_source_project_does_not_exist/the_email_also_gets_delivered.yml
M src/api/spec/mailers/event_mailer_spec.rb
Log Message:
-----------
Adopt EventMailer specs to backend changes
In 5b84009e99881044b148e549814663ab7ec862b3 we introduced a new
parameter for many backend diff requests. Adopt the event mailer
spec to it.
Commit: efe068f19a8872d963b7c46bfce0e020dcd79973
https://github.com/openSUSE/open-build-service/commit/efe068f19a8872d963b7c4...
Author: Henne Vogelsang
Date: 2020-08-13 (Thu, 13 Aug 2020)
Changed paths:
M src/api/app/lib/backend/api/sources/package.rb
M src/api/app/models/bs_request_action.rb
M src/api/app/models/bs_request_action/differ/for_source.rb
M src/api/spec/cassettes/BackfillNotifiedProjects/up/backfills_the_notifications_projects_table_with_all_projects_from_existing_notifications.yml
M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/not_setting_a_target_package/creates_a_BsRequest_with_the_source_package_name.yml
M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/prefill_form_for_a_branched_package/fills_in_the_submission_reasons_and_creates_a_BsRequest.yml
M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/setting_a_target_package/creates_a_BsRequest_with_target_package_name.yml
M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/supersede_a_request/creates_a_BsRequest_and_supersede_only_the_selected_request_s_.yml
R src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/raises_exception_on_missing_by__paramter.yml
R src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/raises_exception_on_wrong_user.yml
R src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/with_the_proper_reviewer/moves_to_new.yml
R src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/with_the_proper_reviewer/sends_3_events.yml
R src/api/spec/cassettes/BsRequest/_changestate/when_bs_request_is_staged/1_6_4_1.yml
M src/api/spec/cassettes/BsRequest/_changestate/when_bs_request_is_staged/when_a_staged_bs_request_is_accepted/1_6_4_2_1.yml
R src/api/spec/cassettes/BsRequest/_delayed_auto_accept/1_8_1.yml
R src/api/spec/cassettes/BsRequest/_delayed_auto_accept/1_8_2.yml
M src/api/spec/cassettes/BsRequest/_forward_to/only_forwards_submit_requests.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/creates_a_new_submit_request_open_for_review.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/creates_a_submit_request_action_with_the_correct_target.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/does_not_set_the_sourceupdate.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/sets_the_logged_in_user_as_creator_of_the_request.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_options/creates_a_submit_request_action_with_the_correct_target.yml
R src/api/spec/cassettes/BsRequest/_forward_to/with_options/does_not_copy_the_sourceupdate_attribute.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_options/sets_the_given_description.yml
M src/api/spec/cassettes/BsRequest/_forward_to/with_project_and_package_as_parameter/creates_a_submit_request_action_with_the_correct_target.yml
M src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_creator_doesn_t_have_permissions_for_the_target_project/1_9_2_3_1.yml
M src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_the_request_is_pending/1_9_2_1_1.yml
M src/api/spec/cassettes/BsRequest/auto_accept/_delayed_auto_accept/1_9_1_1.yml
M src/api/spec/cassettes/BsRequest/auto_accept/_delayed_auto_accept/1_9_1_2.yml
R src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set/1_11_1_4_1.yml
M src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set/1_12_1_4_1.yml
R src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_cleanup/1_11_1_1_1.yml
M src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_cleanup/1_12_1_1_1.yml
R src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_update/1_11_1_2_1.yml
M src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_update/1_12_1_2_1.yml
R src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_set_to_noupdate/1_11_1_3_1.yml
M src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_set_to_noupdate/1_12_1_3_1.yml
R src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new_from_xml/1_11_2_1.yml
M src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new_from_xml/1_12_2_1.yml
M src/api/spec/cassettes/BsRequestAction/create_expand_package/Everything_should_work/1_8_2_1.yml
M src/api/spec/cassettes/BsRequestAction/create_expand_package/Should_return_an_array/1_8_3_1.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/gets_delivered.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/has_a_subject.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/has_custom_headers.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/has_subscribers.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/has_the_default_headers.yml
A src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/renders_links_absolute.yml
A src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/when_comment_contains_emoji/1_1_2_8_1.yml
A src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/when_comment_contains_emoji/1_1_2_8_2.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_CommentForProject/when_originator_is_subscribed/does_not_send_to_the_originator.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_Request/uses_default_for_FROM_if_display_name_does_not_exist.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_Request/uses_display_name_for_FROM_if_originator_exists.yml
M src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_Request/when_source_project_does_not_exist/the_email_also_gets_delivered.yml
M src/api/spec/cassettes/MaintenanceWorkflow/maintenance_workflow.yml
M src/api/spec/cassettes/RequestController/_global_command_cmd_create_/requesting_creation_of_a_source_project_that_has_a_project_link_that_is_not_owned_by_the_requester/prohibits_creation_of_request.yml
M src/api/spec/cassettes/Webui_RequestController/POST_changerequest/with_valid_parameters/forwards.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/having_whitespaces_in_parameters/behaves_like_a_response_of_a_successful_submit_request/1_1_5_1_1.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/having_whitespaces_in_parameters/behaves_like_a_response_of_a_successful_submit_request/1_1_5_1_2.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/sending_a_submit_request_for_an_older_submission/behaves_like_a_response_of_a_successful_submit_request/1_1_6_1_1.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/sending_a_submit_request_for_an_older_submission/behaves_like_a_response_of_a_successful_submit_request/1_1_6_1_2.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/sending_a_submit_request_for_an_older_submission/creates_a_submit_request_for_the_correct_revision.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/unchanged_sources/1_1_9_1.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/unchanged_sources/1_1_9_2.yml
M src/api/spec/cassettes/Webui_Requests_SubmissionsController/POST_create/unchanged_sources/1_1_9_3.yml
M src/api/spec/factories/project.rb
M src/api/spec/mailers/event_mailer_spec.rb
M src/api/spec/models/bs_request_spec.rb
Log Message:
-----------
Merge pull request #9406 from adrianschroeter/speed_up_request_creation
[frontend] speed up request creation
Compare: https://github.com/openSUSE/open-build-service/compare/0914a0787e16...efe068...
