Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3c6bed7f8b8b2cb6ef4c54bf566291512189f05e https://github.com/openSUSE/open-build-service/commit/3c6bed7f8b8b2cb6ef4c54... Author: Eduardo Navarro <enavarro@suse.com> Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M src/api/app/models/token/errors.rb M src/api/app/models/token/workflow.rb Log Message: ----------- Include message of exception in error definition From now own, if we have to raise this exception, we will not have to include the same message in every raise call. Commit: 78d9402e8cc36cf51959559e9d83bf5dad3d8608 https://github.com/openSUSE/open-build-service/commit/78d9402e8cc36cf5195955... Author: Eduardo Navarro <enavarro@suse.com> Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M src/api/app/models/token/workflow.rb M src/api/app/services/github_status_reporter.rb M src/api/app/services/workflows/yaml_downloader.rb Log Message: ----------- Refactor handling of Octokit::Unauthorized exceptions We prefer to handle this exception just after an Octokit client is used, instead of in some other upper level. Commit: 981f2ce49850c2731d43d6b643f7be70628fd52f https://github.com/openSUSE/open-build-service/commit/981f2ce49850c2731d43d6... Author: Eduardo Navarro <enavarro@suse.com> Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M src/api/app/models/token/workflow.rb M src/api/app/services/gitlab_status_reporter.rb M src/api/app/services/workflows/yaml_downloader.rb Log Message: ----------- Refactor handling of Gitlab::Error::Unauthorized ... ... exceptions We prefer to handle this exception just after a Gitlab client is used, instead of in some other upper level. Commit: dd8de375d1173d2c0ea53c3d0299983c8719479d https://github.com/openSUSE/open-build-service/commit/dd8de375d1173d2c0ea53c... Author: Eduardo Navarro <enavarro@suse.com> Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_closed_PR/when_the_token_user_is_authorized/revokes_previous_submit_requests.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_newly_opened_PR/creates_a_submit_request.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_newly_opened_PR/creates_an_event_subcription.yml R src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_newly_opened_PR/creates_workflow_artifacts.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_push_event/creates_a_submit_request.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_push_event/creates_an_event_subcription.yml R src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_push_event/creates_workflow_artifacts.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_tag_push_event/creates_a_submit_request.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_tag_push_event/creates_no_event_subcription.yml R src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_tag_push_event/creates_workflow_artifacts.yml R src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_an_updated_PR/when_the_token_user_is_authorized/creates_the_workflow_artifact.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_an_updated_PR/when_the_token_user_is_authorized/supersedes_previously_created_submit_request_and_opens_a_new_one.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_an_updated_PR/when_the_token_user_is_not_authorized/does_not_supersede_the_previously_created_submit_request.yml M src/api/spec/models/token/workflow_spec.rb M src/api/spec/models/workflow/step/submit_request_step_spec.rb M src/api/spec/services/workflows/yaml_downloader_spec.rb Log Message: ----------- Adapt specs after refactoring unauthorized exceptions Commit: fb90d9f06a9359642b13d8783b9f08ab89319acc https://github.com/openSUSE/open-build-service/commit/fb90d9f06a9359642b13d8... Author: Eduardo J <enavarro@suse.com> Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M src/api/app/models/token/errors.rb M src/api/app/models/token/workflow.rb M src/api/app/services/github_status_reporter.rb M src/api/app/services/gitlab_status_reporter.rb M src/api/app/services/workflows/yaml_downloader.rb M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_closed_PR/when_the_token_user_is_authorized/revokes_previous_submit_requests.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_newly_opened_PR/creates_a_submit_request.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_newly_opened_PR/creates_an_event_subcription.yml R src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_newly_opened_PR/creates_workflow_artifacts.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_push_event/creates_a_submit_request.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_push_event/creates_an_event_subcription.yml R src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_push_event/creates_workflow_artifacts.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_tag_push_event/creates_a_submit_request.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_tag_push_event/creates_no_event_subcription.yml R src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_a_tag_push_event/creates_workflow_artifacts.yml R src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_an_updated_PR/when_the_token_user_is_authorized/creates_the_workflow_artifact.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_an_updated_PR/when_the_token_user_is_authorized/supersedes_previously_created_submit_request_and_opens_a_new_one.yml M src/api/spec/cassettes/Workflow_Step_SubmitRequest/_call/for_an_updated_PR/when_the_token_user_is_not_authorized/does_not_supersede_the_previously_created_submit_request.yml M src/api/spec/models/token/workflow_spec.rb M src/api/spec/models/workflow/step/submit_request_step_spec.rb M src/api/spec/services/workflows/yaml_downloader_spec.rb Log Message: ----------- Merge pull request #15986 from eduardoj/refactoring/token_workflow_exceptions Refactor handling of unauthorized exceptions for SCM clients Compare: https://github.com/openSUSE/open-build-service/compare/7b663463843d...fb90d9... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications